All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_
Date: Fri, 16 Feb 2018 09:39:13 +0000	[thread overview]
Message-ID: <1518773953.22495.366.camel@linux.intel.com> (raw)
In-Reply-To: <3ba388af-286a-df63-e78f-c82c1d084439@users.sourceforge.net>

On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 15 Feb 2018 22:15:25 +0100
> 
> Omit an extra message for a memory allocation failure in this
> function.
> 
> This issue was detected by using the Coccinelle software.

Tejun, it's up to you. In case you are fine with the change,

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/ata/sata_dwc_460ex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_dwc_460ex.c
> b/drivers/ata/sata_dwc_460ex.c
> index 6af4ec3c88c3..ce3d6674ef80 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -901,7 +901,6 @@ static int sata_dwc_port_start(struct ata_port
> *ap)
>  	/* Allocate Port Struct */
>  	hsdevp = kzalloc(sizeof(*hsdevp), GFP_KERNEL);
>  	if (!hsdevp) {
> -		dev_err(ap->dev, "%s: kmalloc failed for hsdevp\n",
> __func__);
>  		err = -ENOMEM;
>  		goto CLEANUP;
>  	}

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()
Date: Fri, 16 Feb 2018 11:39:13 +0200	[thread overview]
Message-ID: <1518773953.22495.366.camel@linux.intel.com> (raw)
In-Reply-To: <3ba388af-286a-df63-e78f-c82c1d084439@users.sourceforge.net>

On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 15 Feb 2018 22:15:25 +0100
> 
> Omit an extra message for a memory allocation failure in this
> function.
> 
> This issue was detected by using the Coccinelle software.

Tejun, it's up to you. In case you are fine with the change,

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/ata/sata_dwc_460ex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_dwc_460ex.c
> b/drivers/ata/sata_dwc_460ex.c
> index 6af4ec3c88c3..ce3d6674ef80 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -901,7 +901,6 @@ static int sata_dwc_port_start(struct ata_port
> *ap)
>  	/* Allocate Port Struct */
>  	hsdevp = kzalloc(sizeof(*hsdevp), GFP_KERNEL);
>  	if (!hsdevp) {
> -		dev_err(ap->dev, "%s: kmalloc failed for hsdevp\n",
> __func__);
>  		err = -ENOMEM;
>  		goto CLEANUP;
>  	}

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2018-02-16  9:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 21:22 [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_star SF Markus Elfring
2018-02-15 21:22 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() SF Markus Elfring
2018-02-16  9:39 ` Andy Shevchenko [this message]
2018-02-16  9:39   ` Andy Shevchenko
2018-02-18 13:22   ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_ Tejun Heo
2018-02-18 13:22     ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() Tejun Heo
2018-02-18 14:16     ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_ Andy Shevchenko
2018-02-18 14:16       ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518773953.22495.366.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.