From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_
Date: Sun, 18 Feb 2018 13:22:56 +0000 [thread overview]
Message-ID: <20180218132256.GC695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1518773953.22495.366.camel@linux.intel.com>
On Fri, Feb 16, 2018 at 11:39:13AM +0200, Andy Shevchenko wrote:
> On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 15 Feb 2018 22:15:25 +0100
> >
> > Omit an extra message for a memory allocation failure in this
> > function.
> >
> > This issue was detected by using the Coccinelle software.
>
> Tejun, it's up to you. In case you are fine with the change,
Yeah, these are marginal at best and one may be able to argue that
emitting a message with device identifier is still useful but these
allocations are order-zero and can't fail to begin with, so...
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()
Date: Sun, 18 Feb 2018 05:22:56 -0800 [thread overview]
Message-ID: <20180218132256.GC695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1518773953.22495.366.camel@linux.intel.com>
On Fri, Feb 16, 2018 at 11:39:13AM +0200, Andy Shevchenko wrote:
> On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 15 Feb 2018 22:15:25 +0100
> >
> > Omit an extra message for a memory allocation failure in this
> > function.
> >
> > This issue was detected by using the Coccinelle software.
>
> Tejun, it's up to you. In case you are fine with the change,
Yeah, these are marginal at best and one may be able to argue that
emitting a message with device identifier is still useful but these
allocations are order-zero and can't fail to begin with, so...
Thanks.
--
tejun
next prev parent reply other threads:[~2018-02-18 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 21:22 [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_star SF Markus Elfring
2018-02-15 21:22 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() SF Markus Elfring
2018-02-16 9:39 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_ Andy Shevchenko
2018-02-16 9:39 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() Andy Shevchenko
2018-02-18 13:22 ` Tejun Heo [this message]
2018-02-18 13:22 ` Tejun Heo
2018-02-18 14:16 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_ Andy Shevchenko
2018-02-18 14:16 ` [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218132256.GC695913@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.