From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private
Date: Sat, 17 Feb 2018 17:41:24 +0100 [thread overview]
Message-ID: <1518885684.2883.111.camel@baylibre.com> (raw)
In-Reply-To: <20180217140820.30257-4-martin.blumenstingl@googlemail.com>
On Sat, 2018-02-17 at 15:08 +0100, Martin Blumenstingl wrote:
> The common clock framework needs access to the "clock configuration"
> structs during runtime.
> However, only the common clock framework should access these. Ensure
> this by moving the configuration structs out of struct meson8b_dwmac,
> so only meson8b_init_rgmii_tx_clk() and the common clock framework know
> about these configurations.
>
> Suggested-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 45 ++++++++++++----------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> index 0dfce35c5583..2d5d4aea3bcb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> @@ -49,19 +49,17 @@
>
> struct meson8b_dwmac {
> struct device *dev;
> -
> void __iomem *regs;
> -
> phy_interface_t phy_mode;
> + struct clk *rgmii_tx_clk;
> + u32 tx_delay_ns;
> +};
>
> +struct meson8b_dwmac_clk_configs {
Not too sure we needed a struct for this, but it does work and does not matter
much
> struct clk_mux m250_mux;
> struct clk_divider m250_div;
> struct clk_fixed_factor fixed_div2;
> struct clk_gate rgmii_tx_en;
> -
> - struct clk *rgmii_tx_clk;
> -
> - u32 tx_delay_ns;
> };
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, netdev@vger.kernel.org
Cc: khilman@baylibre.com, carlo@caione.org, narmstrong@baylibre.com
Subject: Re: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private
Date: Sat, 17 Feb 2018 17:41:24 +0100 [thread overview]
Message-ID: <1518885684.2883.111.camel@baylibre.com> (raw)
In-Reply-To: <20180217140820.30257-4-martin.blumenstingl@googlemail.com>
On Sat, 2018-02-17 at 15:08 +0100, Martin Blumenstingl wrote:
> The common clock framework needs access to the "clock configuration"
> structs during runtime.
> However, only the common clock framework should access these. Ensure
> this by moving the configuration structs out of struct meson8b_dwmac,
> so only meson8b_init_rgmii_tx_clk() and the common clock framework know
> about these configurations.
>
> Suggested-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 45 ++++++++++++----------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> index 0dfce35c5583..2d5d4aea3bcb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> @@ -49,19 +49,17 @@
>
> struct meson8b_dwmac {
> struct device *dev;
> -
> void __iomem *regs;
> -
> phy_interface_t phy_mode;
> + struct clk *rgmii_tx_clk;
> + u32 tx_delay_ns;
> +};
>
> +struct meson8b_dwmac_clk_configs {
Not too sure we needed a struct for this, but it does work and does not matter
much
> struct clk_mux m250_mux;
> struct clk_divider m250_div;
> struct clk_fixed_factor fixed_div2;
> struct clk_gate rgmii_tx_en;
> -
> - struct clk *rgmii_tx_clk;
> -
> - u32 tx_delay_ns;
> };
next prev parent reply other threads:[~2018-02-17 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 14:08 [net-next PATCH v1 0/3] dwmac-meson8b: small cleanup Martin Blumenstingl
2018-02-17 14:08 ` Martin Blumenstingl
2018-02-17 14:08 ` [net-next PATCH v1 1/3] net: stmmac: dwmac-meson8b: simplify clock registration Martin Blumenstingl
2018-02-17 14:08 ` Martin Blumenstingl
2018-02-17 16:38 ` Jerome Brunet
2018-02-17 16:38 ` Jerome Brunet
2018-02-17 14:08 ` [net-next PATCH v1 2/3] net: stmmac: dwmac-meson8b: only keep struct device around Martin Blumenstingl
2018-02-17 14:08 ` Martin Blumenstingl
2018-02-17 14:08 ` [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private Martin Blumenstingl
2018-02-17 14:08 ` Martin Blumenstingl
2018-02-17 16:41 ` Jerome Brunet [this message]
2018-02-17 16:41 ` Jerome Brunet
2018-02-17 17:42 ` Martin Blumenstingl
2018-02-17 17:42 ` Martin Blumenstingl
2018-02-19 16:27 ` [net-next PATCH v1 0/3] dwmac-meson8b: small cleanup David Miller
2018-02-19 16:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518885684.2883.111.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.