From: Oliver Neukum <oneukum@suse.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Andrew F. Davis" <afd@ti.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
Date: Mon, 12 Mar 2018 10:03:58 +0000 [thread overview]
Message-ID: <1520849038.29340.3.camel@suse.com> (raw)
In-Reply-To: <019cc24b-d9c0-d782-35e8-f9f8be0534db@users.sourceforge.net>
Am Samstag, den 10.03.2018, 19:26 +0100 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 18:53:28 +0100
>
> Use three values directly for a condition check without assigning them
> to intermediate variables.
Hi,
what is the benefit of this? It looks like needless code churn to me.
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Andrew F. Davis" <afd@ti.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
Date: Mon, 12 Mar 2018 11:03:58 +0100 [thread overview]
Message-ID: <1520849038.29340.3.camel@suse.com> (raw)
Am Samstag, den 10.03.2018, 19:26 +0100 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 18:53:28 +0100
>
> Use three values directly for a condition check without assigning them
> to intermediate variables.
Hi,
what is the benefit of this? It looks like needless code churn to me.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Andrew F. Davis" <afd@ti.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()
Date: Mon, 12 Mar 2018 11:03:58 +0100 [thread overview]
Message-ID: <1520849038.29340.3.camel@suse.com> (raw)
In-Reply-To: <019cc24b-d9c0-d782-35e8-f9f8be0534db@users.sourceforge.net>
Am Samstag, den 10.03.2018, 19:26 +0100 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 18:53:28 +0100
>
> Use three values directly for a condition check without assigning them
> to intermediate variables.
Hi,
what is the benefit of this? It looks like needless code churn to me.
Regards
Oliver
next prev parent reply other threads:[~2018-03-12 10:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 18:26 [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:26 ` SF Markus Elfring
2018-03-10 18:26 ` [2/2] " SF Markus Elfring
2018-03-12 10:03 ` Oliver Neukum [this message]
2018-03-12 10:03 ` [PATCH 2/2] " Oliver Neukum
2018-03-12 10:03 ` [2/2] " Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2018-03-13 7:24 SF Markus Elfring
2018-03-13 7:24 ` SF Markus Elfring
2018-03-13 7:24 ` SF Markus Elfring
2018-03-13 10:26 ` Oliver Neukum
2018-03-13 10:26 ` Oliver Neukum
2018-03-13 10:26 ` Oliver Neukum
2018-03-10 18:24 [PATCH 1/2] net/usb/ax88179_178a: Use common code " SF Markus Elfring
2018-03-10 18:24 ` SF Markus Elfring
2018-03-10 18:24 ` [1/2] " SF Markus Elfring
2018-03-10 18:41 ` [PATCH 1/2] " Joe Perches
2018-03-10 18:41 ` Joe Perches
2018-03-10 18:41 ` [1/2] " Joe Perches
2018-03-10 18:48 ` [PATCH 1/2] " Andy Shevchenko
2018-03-10 18:48 ` Andy Shevchenko
2018-03-10 18:48 ` [1/2] " Andy Shevchenko
2018-03-10 18:22 [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:22 ` SF Markus Elfring
2018-03-10 19:17 ` Andrew Lunn
2018-03-10 19:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520849038.29340.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=afd@ti.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.