From: Andrew Lunn <andrew@lunn.ch>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
"Andrew F. Davis" <afd@ti.com>, "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()
Date: Sat, 10 Mar 2018 19:17:44 +0000 [thread overview]
Message-ID: <20180310191744.GN27783@lunn.ch> (raw)
In-Reply-To: <b92bebdb-c1dc-a9d3-2e3a-845d8dc4998f@users.sourceforge.net>
On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 19:05:45 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
"Andrew F. Davis" <afd@ti.com>, "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Philippe Reynes" <tremyfr@gmail.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()
Date: Sat, 10 Mar 2018 20:17:44 +0100 [thread overview]
Message-ID: <20180310191744.GN27783@lunn.ch> (raw)
In-Reply-To: <b92bebdb-c1dc-a9d3-2e3a-845d8dc4998f@users.sourceforge.net>
On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 10 Mar 2018 19:05:45 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().
Andrew
next prev parent reply other threads:[~2018-03-10 19:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 18:22 [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:22 ` SF Markus Elfring
2018-03-10 19:17 ` Andrew Lunn [this message]
2018-03-10 19:17 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2018-03-10 18:24 [PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee() SF Markus Elfring
2018-03-10 18:24 ` SF Markus Elfring
2018-03-10 18:24 ` [1/2] " SF Markus Elfring
2018-03-10 18:41 ` [PATCH 1/2] " Joe Perches
2018-03-10 18:41 ` Joe Perches
2018-03-10 18:41 ` [1/2] " Joe Perches
2018-03-10 18:48 ` [PATCH 1/2] " Andy Shevchenko
2018-03-10 18:48 ` Andy Shevchenko
2018-03-10 18:48 ` [1/2] " Andy Shevchenko
2018-03-10 18:26 [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables " SF Markus Elfring
2018-03-10 18:26 ` SF Markus Elfring
2018-03-10 18:26 ` [2/2] " SF Markus Elfring
2018-03-12 10:03 ` [PATCH 2/2] " Oliver Neukum
2018-03-12 10:03 ` Oliver Neukum
2018-03-12 10:03 ` [2/2] " Oliver Neukum
2018-03-13 7:24 SF Markus Elfring
2018-03-13 7:24 ` SF Markus Elfring
2018-03-13 7:24 ` SF Markus Elfring
2018-03-13 10:26 ` Oliver Neukum
2018-03-13 10:26 ` Oliver Neukum
2018-03-13 10:26 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310191744.GN27783@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.