From: Oliver Neukum <oneukum@suse.com>
To: Richard Leitner <dev@g0hl1n.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: bhelgaas@google.com, mathias.nyman@intel.com,
gregkh@linuxfoundation.org, richard.leitner@skidata.com
Subject: Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic
Date: Wed, 14 Mar 2018 13:17:34 +0100 [thread overview]
Message-ID: <1521029854.4511.12.camel@suse.com> (raw)
In-Reply-To: <20180314102933.21367-3-dev@g0hl1n.net>
Am Mittwoch, den 14.03.2018, 11:29 +0100 schrieb Richard Leitner:
> From: Richard Leitner <richard.leitner@skidata.com>
>
> Replace the hardcoded PCI vendor ID of Netlogic with a definition in
> pci_ids.h
Hi,
in general, why?
Does this patch generate any benefit for any developer
reading the source? I don't see it. Does it cause an
issue for anybody who has a log file with the nummerical
ID and needs to grep for it? Yes it does.
Where is the point of this patch?
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: Richard Leitner <dev@g0hl1n.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: bhelgaas@google.com, mathias.nyman@intel.com,
gregkh@linuxfoundation.org, richard.leitner@skidata.com
Subject: [2/3] usb: host: pci: introduce PCI vendor ID for Netlogic
Date: Wed, 14 Mar 2018 13:17:34 +0100 [thread overview]
Message-ID: <1521029854.4511.12.camel@suse.com> (raw)
Am Mittwoch, den 14.03.2018, 11:29 +0100 schrieb Richard Leitner:
> From: Richard Leitner <richard.leitner@skidata.com>
>
> Replace the hardcoded PCI vendor ID of Netlogic with a definition in
> pci_ids.h
Hi,
in general, why?
Does this patch generate any benefit for any developer
reading the source? I don't see it. Does it cause an
issue for anybody who has a log file with the nummerical
ID and needs to grep for it? Yes it does.
Where is the point of this patch?
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-14 12:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 10:29 [PATCH 0/3] usb: host: pci: PCI ID consolidation Richard Leitner
2018-03-14 10:29 ` [PATCH 1/3] usb: host: pci: use existing Intel PCI ID macros Richard Leitner
2018-03-14 10:29 ` [1/3] " Richard Leitner
2018-03-14 10:48 ` [PATCH 1/3] " Greg KH
2018-03-14 10:48 ` [1/3] " Greg Kroah-Hartman
2018-03-14 10:29 ` [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic Richard Leitner
2018-03-14 10:29 ` [2/3] " Richard Leitner
2018-03-14 10:48 ` [PATCH 2/3] " Greg KH
2018-03-14 10:48 ` [2/3] " Greg Kroah-Hartman
2018-03-14 11:36 ` [PATCH 2/3] " Richard Leitner
2018-03-14 11:36 ` [2/3] " Richard Leitner
2018-03-14 11:49 ` [PATCH 2/3] " Greg KH
2018-03-14 11:49 ` [2/3] " Greg Kroah-Hartman
2018-03-14 12:17 ` Oliver Neukum [this message]
2018-03-14 12:17 ` Oliver Neukum
2018-03-14 13:31 ` [PATCH 2/3] " Richard Leitner
2018-03-14 13:31 ` [2/3] " Richard Leitner
2018-03-14 15:27 ` [PATCH 2/3] " Oliver Neukum
2018-03-14 15:27 ` [2/3] " Oliver Neukum
2018-03-14 15:44 ` [PATCH 2/3] " Richard Leitner
2018-03-14 15:44 ` [2/3] " Richard Leitner
2018-03-15 9:26 ` [PATCH 2/3] " Oliver Neukum
2018-03-15 9:26 ` [2/3] " Oliver Neukum
2018-03-15 9:47 ` [PATCH 2/3] " Richard Leitner
2018-03-15 9:47 ` [2/3] " Richard Leitner
2018-03-14 10:29 ` [PATCH 3/3] usb: host: pci: replace hardcoded renesas PCI IDs Richard Leitner
2018-03-14 10:29 ` [3/3] " Richard Leitner
2018-03-14 10:49 ` [PATCH 3/3] " Greg KH
2018-03-14 10:49 ` [3/3] " Greg Kroah-Hartman
2018-03-14 11:38 ` [PATCH 3/3] " Richard Leitner
2018-03-14 11:38 ` [3/3] " Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521029854.4511.12.camel@suse.com \
--to=oneukum@suse.com \
--cc=bhelgaas@google.com \
--cc=dev@g0hl1n.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.