All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	Sean Paul <seanpaul@chromium.org>,
	David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
Date: Thu, 15 Mar 2018 07:48:30 -0700	[thread overview]
Message-ID: <1521125310.22221.4.camel@perches.com> (raw)
In-Reply-To: <7dac9dbd-b57b-6e37-c1bb-9ab6c2711613@linux.intel.com>

On Thu, 2018-03-15 at 14:22 +0100, Maarten Lankhorst wrote:
> Op 13-03-18 om 23:02 schreef Joe Perches:
> > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > arguments that can be removed by creating separate functins.
> > 
> > Create specific functions for these calls to reduce x86/64 defconfig
> > size by ~20k.
> > 
> > Modify the existing macros to use the specific calls.
> > 
> > new:
> > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > 1876562	  44542	    995	1922099	 1d5433	(TOTALS)
> > 
> > old:
> > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > 1897565	  44542	    995	1943102	 1da63e	(TOTALS)
[]
> I guess this adds up. Nice reduction. :)

Yup. 1% of all drm object code.

> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
[]
> >  
> > -	drm_printk(level, category, "mismatch in %s %pV", name, &vaf);
> > +	if (adjust)
> > +		drm_dbg(DRM_UT_KMS, "mismatch in %s %pV", name, &vaf);
> > +	else
> > +		drm_err("mismatch in %s %pV", name, &vaf);
> 
> Could this use DRM_DEBUG_KMS/DRM_ERROR?
> 
> Rest looks good, so I can fix up if you want.

If want you change something like that, it should be separate patch.

btw: There was  separate patch that also reduced object size
of the drm_dev_printk calls several months ago.  Never applied.

https://lkml.org/lkml/2017/9/25/247

cheers, Joe

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	Sean Paul <seanpaul@chromium.org>,
	David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
Date: Thu, 15 Mar 2018 07:48:30 -0700	[thread overview]
Message-ID: <1521125310.22221.4.camel@perches.com> (raw)
In-Reply-To: <7dac9dbd-b57b-6e37-c1bb-9ab6c2711613@linux.intel.com>

On Thu, 2018-03-15 at 14:22 +0100, Maarten Lankhorst wrote:
> Op 13-03-18 om 23:02 schreef Joe Perches:
> > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > arguments that can be removed by creating separate functins.
> > 
> > Create specific functions for these calls to reduce x86/64 defconfig
> > size by ~20k.
> > 
> > Modify the existing macros to use the specific calls.
> > 
> > new:
> > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > 1876562	  44542	    995	1922099	 1d5433	(TOTALS)
> > 
> > old:
> > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > 1897565	  44542	    995	1943102	 1da63e	(TOTALS)
[]
> I guess this adds up. Nice reduction. :)

Yup. 1% of all drm object code.

> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
[]
> >  
> > -	drm_printk(level, category, "mismatch in %s %pV", name, &vaf);
> > +	if (adjust)
> > +		drm_dbg(DRM_UT_KMS, "mismatch in %s %pV", name, &vaf);
> > +	else
> > +		drm_err("mismatch in %s %pV", name, &vaf);
> 
> Could this use DRM_DEBUG_KMS/DRM_ERROR?
> 
> Rest looks good, so I can fix up if you want.

If want you change something like that, it should be separate patch.

btw: There was  separate patch that also reduced object size
of the drm_dev_printk calls several months ago.  Never applied.

https://lkml.org/lkml/2017/9/25/247

cheers, Joe

  reply	other threads:[~2018-03-15 14:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 22:02 [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Joe Perches
2018-03-13 23:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-14  2:16 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-15 13:22 ` [PATCH] " Maarten Lankhorst
2018-03-15 13:22   ` Maarten Lankhorst
2018-03-15 14:48   ` Joe Perches [this message]
2018-03-15 14:48     ` Joe Perches
2018-03-15 13:30 ` Ville Syrjälä
2018-03-15 13:30   ` Ville Syrjälä
2018-03-15 14:04   ` Maarten Lankhorst
2018-03-15 14:04     ` Maarten Lankhorst
2018-03-15 15:05     ` Ville Syrjälä
2018-03-15 15:05       ` Ville Syrjälä
2018-03-15 15:17       ` Joe Perches
2018-03-15 15:37         ` Ville Syrjälä
2018-03-15 15:37           ` Ville Syrjälä
2018-03-15 15:44           ` Joe Perches
2018-03-15 15:44             ` Joe Perches
2018-03-15 16:14             ` Ville Syrjälä
2018-03-15 16:14               ` Ville Syrjälä
2018-03-15 16:29               ` Joe Perches
2018-03-15 16:29                 ` Joe Perches
2018-03-16  7:41 ` Daniel Vetter
2018-03-16  7:41   ` Daniel Vetter
2018-03-16 12:29   ` Joe Perches
2018-03-19 13:53     ` Daniel Vetter
2018-03-19 13:53       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521125310.22221.4.camel@perches.com \
    --to=joe@perches.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.