From: Daniel Vetter <daniel@ffwll.ch>
To: Joe Perches <joe@perches.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
Date: Mon, 19 Mar 2018 14:53:51 +0100 [thread overview]
Message-ID: <20180319135351.GL14155@phenom.ffwll.local> (raw)
In-Reply-To: <1521203342.6119.5.camel@perches.com>
On Fri, Mar 16, 2018 at 05:29:02AM -0700, Joe Perches wrote:
> On Fri, 2018-03-16 at 08:41 +0100, Daniel Vetter wrote:
> > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote:
> > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > > arguments that can be removed by creating separate functins.
> > >
> > > Create specific functions for these calls to reduce x86/64 defconfig
> > > size by ~20k.
> > >
> > > Modify the existing macros to use the specific calls.
> > >
> > > new:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1876562 44542 995 1922099 1d5433 (TOTALS)
> > >
> > > old:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1897565 44542 995 1943102 1da63e (TOTALS)
> > >
> > > Miscellanea:
> > >
> > > o intel_display requires a change to use the specific calls.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Impressed with the size of the bikeshed piled on top of this I decided to
> > cut this all short by merging it.
>
> Thanks.
>
> There was a similar patch for the DRM_DEV_ macros
> awhile ago that also reduced object code.
>
> https://lkml.org/lkml/2017/9/25/247
>
> Never applied.
>
> Want a remerge resend?
Yeah dropped out of my inbox, resending is easier. Please do so.
In case you wonder, I try to fairly intentionally drop stuff on the floor,
to force other people on dri-devel to not load everything onto me, making
me a bottleneck. But then occasionally a patch drops through all nets
because tracking mailing lists is impossible :-/
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Joe Perches <joe@perches.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
Date: Mon, 19 Mar 2018 14:53:51 +0100 [thread overview]
Message-ID: <20180319135351.GL14155@phenom.ffwll.local> (raw)
In-Reply-To: <1521203342.6119.5.camel@perches.com>
On Fri, Mar 16, 2018 at 05:29:02AM -0700, Joe Perches wrote:
> On Fri, 2018-03-16 at 08:41 +0100, Daniel Vetter wrote:
> > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote:
> > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > > arguments that can be removed by creating separate functins.
> > >
> > > Create specific functions for these calls to reduce x86/64 defconfig
> > > size by ~20k.
> > >
> > > Modify the existing macros to use the specific calls.
> > >
> > > new:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1876562 44542 995 1922099 1d5433 (TOTALS)
> > >
> > > old:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1897565 44542 995 1943102 1da63e (TOTALS)
> > >
> > > Miscellanea:
> > >
> > > o intel_display requires a change to use the specific calls.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Impressed with the size of the bikeshed piled on top of this I decided to
> > cut this all short by merging it.
>
> Thanks.
>
> There was a similar patch for the DRM_DEV_ macros
> awhile ago that also reduced object code.
>
> https://lkml.org/lkml/2017/9/25/247
>
> Never applied.
>
> Want a remerge resend?
Yeah dropped out of my inbox, resending is easier. Please do so.
In case you wonder, I try to fairly intentionally drop stuff on the floor,
to force other people on dri-devel to not load everything onto me, making
me a bottleneck. But then occasionally a patch drops through all nets
because tracking mailing lists is impossible :-/
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2018-03-19 13:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 22:02 [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Joe Perches
2018-03-13 23:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-14 2:16 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-15 13:22 ` [PATCH] " Maarten Lankhorst
2018-03-15 13:22 ` Maarten Lankhorst
2018-03-15 14:48 ` Joe Perches
2018-03-15 14:48 ` Joe Perches
2018-03-15 13:30 ` Ville Syrjälä
2018-03-15 13:30 ` Ville Syrjälä
2018-03-15 14:04 ` Maarten Lankhorst
2018-03-15 14:04 ` Maarten Lankhorst
2018-03-15 15:05 ` Ville Syrjälä
2018-03-15 15:05 ` Ville Syrjälä
2018-03-15 15:17 ` Joe Perches
2018-03-15 15:37 ` Ville Syrjälä
2018-03-15 15:37 ` Ville Syrjälä
2018-03-15 15:44 ` Joe Perches
2018-03-15 15:44 ` Joe Perches
2018-03-15 16:14 ` Ville Syrjälä
2018-03-15 16:14 ` Ville Syrjälä
2018-03-15 16:29 ` Joe Perches
2018-03-15 16:29 ` Joe Perches
2018-03-16 7:41 ` Daniel Vetter
2018-03-16 7:41 ` Daniel Vetter
2018-03-16 12:29 ` Joe Perches
2018-03-19 13:53 ` Daniel Vetter [this message]
2018-03-19 13:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319135351.GL14155@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.