All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs
Date: Wed, 21 Mar 2018 14:56:10 -0400	[thread overview]
Message-ID: <1521658572-26354-7-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521658572-26354-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel() in multiple places. writel()
already has a barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 6bf778a..774b2a6 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,
 		 * such as IA-64).
 		 */
 		wmb();
-		writel(i, rx_ring->tail);
+		writel_relaxed(i, rx_ring->tail);
 	}
 }
 
@@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,
 	tx_ring->next_to_use = i;
 
 	/* notify HW of packet */
-	writel(i, tx_ring->tail);
+	writel_relaxed(i, tx_ring->tail);
 
 	return;
 dma_error:
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, timur@codeaurora.org,
	sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs
Date: Wed, 21 Mar 2018 14:56:10 -0400	[thread overview]
Message-ID: <1521658572-26354-7-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521658572-26354-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel() in multiple places. writel()
already has a barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 6bf778a..774b2a6 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,
 		 * such as IA-64).
 		 */
 		wmb();
-		writel(i, rx_ring->tail);
+		writel_relaxed(i, rx_ring->tail);
 	}
 }
 
@@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,
 	tx_ring->next_to_use = i;
 
 	/* notify HW of packet */
-	writel(i, tx_ring->tail);
+	writel_relaxed(i, tx_ring->tail);
 
 	return;
 dma_error:
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs
Date: Wed, 21 Mar 2018 14:56:10 -0400	[thread overview]
Message-ID: <1521658572-26354-7-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521658572-26354-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel() in multiple places. writel()
already has a barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 6bf778a..774b2a6 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,
 		 * such as IA-64).
 		 */
 		wmb();
-		writel(i, rx_ring->tail);
+		writel_relaxed(i, rx_ring->tail);
 	}
 }
 
@@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,
 	tx_ring->next_to_use = i;
 
 	/* notify HW of packet */
-	writel(i, tx_ring->tail);
+	writel_relaxed(i, tx_ring->tail);
 
 	return;
 dma_error:
-- 
2.7.4

  parent reply	other threads:[~2018-03-21 18:56 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 18:56 [PATCH REPOST v4 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56 ` Sinan Kaya
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 1/7] i40e/i40evf: " Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-22 18:52   ` [Intel-wired-lan] " Bowers, AndrewX
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-22 18:51   ` [Intel-wired-lan] " Bowers, AndrewX
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 3/7] igbvf: " Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 4/7] igb: " Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 21:48   ` [Intel-wired-lan] " Jeff Kirsher
2018-03-21 21:48     ` Jeff Kirsher
2018-03-21 21:48     ` Jeff Kirsher
2018-03-21 21:51     ` [Intel-wired-lan] " okaya
2018-03-21 21:51       ` okaya at codeaurora.org
2018-03-21 21:51       ` okaya
2018-03-21 21:53       ` [Intel-wired-lan] " Alexander Duyck
2018-03-21 21:53         ` Alexander Duyck
2018-03-21 21:53         ` Alexander Duyck
2018-03-21 21:54     ` David Miller
2018-03-21 21:54       ` David Miller
2018-03-21 21:54       ` David Miller
2018-03-21 22:14       ` [Intel-wired-lan] " okaya
2018-03-21 22:14         ` okaya at codeaurora.org
2018-03-21 22:14         ` okaya
2018-03-21 18:56 ` Sinan Kaya [this message]
2018-03-21 18:56   ` [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56 ` [Intel-wired-lan] [PATCH REPOST v4 7/7] fm10k: Eliminate " Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya
2018-03-21 18:56   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521658572-26354-7-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.