From: Abhishek Sahu <absahu@codeaurora.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, Andy Gross <andy.gross@linaro.org>,
Archit Taneja <architt@codeaurora.org>,
Abhishek Sahu <absahu@codeaurora.org>
Subject: [PATCH 4/9] mtd: nand: qcom: fix null pointer access for erased buffer detection
Date: Wed, 4 Apr 2018 18:12:20 +0530 [thread overview]
Message-ID: <1522845745-6624-5-git-send-email-absahu@codeaurora.org> (raw)
In-Reply-To: <1522845745-6624-1-git-send-email-absahu@codeaurora.org>
parse_read_errors can be called with only oob buf also in which
case data_buf will be NULL. If data_buf is NULL, then don’t
treat this page as completely erased in case of ECC uncorrectable
error.
Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
---
drivers/mtd/nand/qcom_nandc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
index 57c16a6..0ebcc55 100644
--- a/drivers/mtd/nand/qcom_nandc.c
+++ b/drivers/mtd/nand/qcom_nandc.c
@@ -1607,9 +1607,11 @@ static int parse_read_errors(struct qcom_nand_host *host, u8 *data_buf,
if (host->bch_enabled) {
erased = (erased_cw & ERASED_CW) == ERASED_CW ?
true : false;
- } else {
+ } else if (data_buf) {
erased = erased_chunk_check_and_fixup(data_buf,
data_len);
+ } else {
+ erased = false;
}
if (erased) {
@@ -1652,7 +1654,8 @@ static int parse_read_errors(struct qcom_nand_host *host, u8 *data_buf,
max_bitflips = max(max_bitflips, stat);
}
- data_buf += data_len;
+ if (data_buf)
+ data_buf += data_len;
if (oob_buf)
oob_buf += oob_len + ecc->bytes;
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-04-04 12:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 12:42 [PATCH 0/9] Update for QCOM NAND driver Abhishek Sahu
2018-04-04 12:42 ` [PATCH 1/9] mtd: nand: qcom: use the ecc strength from device parameter Abhishek Sahu
2018-04-06 12:31 ` Miquel Raynal
2018-04-10 6:09 ` Abhishek Sahu
2018-04-10 7:46 ` Miquel Raynal
2018-04-10 7:55 ` Miquel Raynal
2018-04-10 8:07 ` Boris Brezillon
2018-04-12 9:59 ` Abhishek Sahu
2018-04-22 16:34 ` Miquel Raynal
2018-04-23 6:44 ` Abhishek Sahu
2018-04-23 7:05 ` Miquel Raynal
2018-04-24 6:25 ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 2/9] mtd: nand: qcom: wait for desc completion in all BAM channels Abhishek Sahu
2018-04-04 12:42 ` [PATCH 3/9] mtd: nand: qcom: erased page detection for uncorrectable errors only Abhishek Sahu
2018-04-10 8:59 ` Miquel Raynal
2018-04-12 6:33 ` Abhishek Sahu
2018-04-12 6:49 ` Miquel Raynal
2018-04-12 6:58 ` Abhishek Sahu
2018-04-04 12:42 ` Abhishek Sahu [this message]
2018-04-10 9:12 ` [PATCH 4/9] mtd: nand: qcom: fix null pointer access for erased buffer detection Miquel Raynal
2018-04-12 6:54 ` Abhishek Sahu
2018-04-22 16:25 ` Miquel Raynal
2018-04-23 6:29 ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 5/9] mtd: nand: qcom: parse read errors for read oob also Abhishek Sahu
2018-04-10 10:03 ` Miquel Raynal
2018-04-12 7:10 ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 6/9] mtd: nand: qcom: support for checking read errors for last codeword Abhishek Sahu
2018-04-10 10:05 ` Miquel Raynal
[not found] ` <d9f06fe59fa76d2dbf97cb0b5de75bc7@codeaurora.org>
2018-04-22 16:15 ` Miquel Raynal
2018-04-23 6:08 ` Abhishek Sahu
2018-04-23 6:56 ` Miquel Raynal
2018-04-04 12:42 ` [PATCH 7/9] mtd: nand: qcom: check for operation errors in case of raw read Abhishek Sahu
2018-04-10 10:12 ` Miquel Raynal
2018-04-12 7:33 ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 8/9] mtd: nand: qcom: helper function for " Abhishek Sahu
2018-04-10 9:44 ` Miquel Raynal
2018-04-12 7:06 ` Abhishek Sahu
2018-04-22 16:19 ` Miquel Raynal
2018-04-23 6:28 ` Abhishek Sahu
2018-04-23 6:58 ` Miquel Raynal
2018-04-25 6:32 ` Abhishek Sahu
2018-04-25 12:59 ` Miquel Raynal
2018-04-26 5:53 ` Abhishek Sahu
2018-04-26 7:11 ` Miquel Raynal
2018-04-26 7:42 ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 9/9] mtd: nand: qcom: erased page bitflips detection Abhishek Sahu
2018-04-10 10:30 ` Miquel Raynal
2018-04-12 8:00 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522845745-6624-5-git-send-email-absahu@codeaurora.org \
--to=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.