Re: [PATCH 6/9] mtd: nand: qcom: support for checking read errors for last codeword

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Abhishek,

On Thu, 12 Apr 2018 12:47:42 +0530, Abhishek Sahu
<absahu@codeaurora.org> wrote:

> On 2018-04-10 15:35, Miquel Raynal wrote:
> > Hi Abhishek,  
> > > On Wed,  4 Apr 2018 18:12:22 +0530, Abhishek Sahu  
> > <absahu@codeaurora.org> wrote:  
> > >> Add boolean function argument in parse_read_errors to identify  
> >> whether the read error has been called for complete page read or
> >> only last codeword read. This will help in subsequent patches to
> >> detect ECC errors in case of last codeword read.
> > > Can you explain when this happen: "last codeword read"? I don't see the  
> > use case.  
> 
>   Hi Miquel,
> 
>   This is happening inside qcom_nandc_write_oob where the last subpage
>   data is being copied first.

I still don't understand the use case.

What to you mean last 'subpage copied first'?

> 
>     host->use_ecc = true;
> 
>     clear_bam_transaction(nandc);
>     ret = copy_last_cw(host, page);
>     if (ret)
>         return ret;
> 
>   you can refer function comment of qcom_nandc_write_oob  for more
>   detail.
> 
>   Thanks,
>   Abhishek



-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com