All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhishek Sahu <absahu@codeaurora.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Archit Taneja <architt@codeaurora.org>,
	Richard Weinberger <richard@nod.at>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	Andy Gross <andy.gross@linaro.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 5/9] mtd: nand: qcom: parse read errors for read oob also
Date: Thu, 12 Apr 2018 12:40:13 +0530	[thread overview]
Message-ID: <8342d92074d94d98106f29ea40f779f4@codeaurora.org> (raw)
In-Reply-To: <20180410120338.663d5925@xps13>

On 2018-04-10 15:33, Miquel Raynal wrote:
> Hi Abhishek,
> 
> On Wed,  4 Apr 2018 18:12:21 +0530, Abhishek Sahu
> <absahu@codeaurora.org> wrote:
> 
>> read_page and read_oob both calls the read_page_ecc function.
>> The QCOM NAND controller protect the OOB available bytes with
>> ECC so read errors should be checked for read_oob also. Now
>> this patch moves the error checking code inside read_page_ecc
>> so caller does not have to check explicitly for read errors.
>> 
>> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> 
> Nitpick: the prefix should be "mtd: rawnand: qcom: " now as this driver
> has been moved to drivers/mtd/nand/raw/.
> 
> Otherwise:
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

  Thanks Miquel for your review.

  I will update the same in this patch and other patches.
  and rebase my patches over 4.17-rc1 once its available.

  Thanks,
  Abhishek

  reply	other threads:[~2018-04-12  7:10 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 12:42 [PATCH 0/9] Update for QCOM NAND driver Abhishek Sahu
2018-04-04 12:42 ` [PATCH 1/9] mtd: nand: qcom: use the ecc strength from device parameter Abhishek Sahu
2018-04-06 12:31   ` Miquel Raynal
2018-04-10  6:09     ` Abhishek Sahu
2018-04-10  7:46       ` Miquel Raynal
2018-04-10  7:55         ` Miquel Raynal
2018-04-10  8:07           ` Boris Brezillon
2018-04-12  9:59             ` Abhishek Sahu
2018-04-22 16:34               ` Miquel Raynal
2018-04-23  6:44                 ` Abhishek Sahu
2018-04-23  7:05                   ` Miquel Raynal
2018-04-24  6:25                     ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 2/9] mtd: nand: qcom: wait for desc completion in all BAM channels Abhishek Sahu
2018-04-04 12:42 ` [PATCH 3/9] mtd: nand: qcom: erased page detection for uncorrectable errors only Abhishek Sahu
2018-04-10  8:59   ` Miquel Raynal
2018-04-12  6:33     ` Abhishek Sahu
2018-04-12  6:49       ` Miquel Raynal
2018-04-12  6:58         ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 4/9] mtd: nand: qcom: fix null pointer access for erased buffer detection Abhishek Sahu
2018-04-10  9:12   ` Miquel Raynal
2018-04-12  6:54     ` Abhishek Sahu
2018-04-22 16:25       ` Miquel Raynal
2018-04-23  6:29         ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 5/9] mtd: nand: qcom: parse read errors for read oob also Abhishek Sahu
2018-04-10 10:03   ` Miquel Raynal
2018-04-12  7:10     ` Abhishek Sahu [this message]
2018-04-04 12:42 ` [PATCH 6/9] mtd: nand: qcom: support for checking read errors for last codeword Abhishek Sahu
2018-04-10 10:05   ` Miquel Raynal
     [not found]     ` <d9f06fe59fa76d2dbf97cb0b5de75bc7@codeaurora.org>
2018-04-22 16:15       ` Miquel Raynal
2018-04-23  6:08         ` Abhishek Sahu
2018-04-23  6:56           ` Miquel Raynal
2018-04-04 12:42 ` [PATCH 7/9] mtd: nand: qcom: check for operation errors in case of raw read Abhishek Sahu
2018-04-10 10:12   ` Miquel Raynal
2018-04-12  7:33     ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 8/9] mtd: nand: qcom: helper function for " Abhishek Sahu
2018-04-10  9:44   ` Miquel Raynal
2018-04-12  7:06     ` Abhishek Sahu
2018-04-22 16:19       ` Miquel Raynal
2018-04-23  6:28         ` Abhishek Sahu
2018-04-23  6:58           ` Miquel Raynal
2018-04-25  6:32             ` Abhishek Sahu
2018-04-25 12:59               ` Miquel Raynal
2018-04-26  5:53                 ` Abhishek Sahu
2018-04-26  7:11                   ` Miquel Raynal
2018-04-26  7:42                     ` Abhishek Sahu
2018-04-04 12:42 ` [PATCH 9/9] mtd: nand: qcom: erased page bitflips detection Abhishek Sahu
2018-04-10 10:30   ` Miquel Raynal
2018-04-12  8:00     ` Abhishek Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8342d92074d94d98106f29ea40f779f4@codeaurora.org \
    --to=absahu@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=architt@codeaurora.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.