All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mehta, Sohil" <sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "gary.hook-5C7GfCeVMHo@public.gmane.org"
	<gary.hook-5C7GfCeVMHo@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Tue, 17 Apr 2018 00:52:29 +0000	[thread overview]
Message-ID: <1523926423.2747.19.camel@intel.com> (raw)
In-Reply-To: <152302067362.47565.628887796165116844.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>

On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
> 
> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
> index 5eb1121d54b9..0ca250f626d9 100644
> --- a/drivers/iommu/Makefile
> +++ b/drivers/iommu/Makefile
> @@ -11,6 +11,7 @@ obj-$(CONFIG_IOMMU_IOVA) += iova.o
>  obj-$(CONFIG_OF_IOMMU) += of_iommu.o
>  obj-$(CONFIG_MSM_IOMMU) += msm_iommu.o
>  obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o
> +obj-$(CONFIG_IOMMU_DEBUG) += amd_iommu_debugfs.o

Compiling amd_iommu_debugfs.c seems to depend only
on CONFIG_IOMMU_DEBUG. Can we prevent the code within
amd_iommu_debugfs.c from getting compiled when either CONFIG_AMD_IOMMU
or CONFIG_IOMMU_DEBUG is disabled?

>  obj-$(CONFIG_AMD_IOMMU_V2) += amd_iommu_v2.o
>  obj-$(CONFIG_ARM_SMMU) += arm-smmu.o
>  obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: "Mehta, Sohil" <sohil.mehta@intel.com>
To: "gary.hook@amd.com" <gary.hook@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Tue, 17 Apr 2018 00:52:29 +0000	[thread overview]
Message-ID: <1523926423.2747.19.camel@intel.com> (raw)
In-Reply-To: <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com>

On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
> 
> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
> index 5eb1121d54b9..0ca250f626d9 100644
> --- a/drivers/iommu/Makefile
> +++ b/drivers/iommu/Makefile
> @@ -11,6 +11,7 @@ obj-$(CONFIG_IOMMU_IOVA) += iova.o
>  obj-$(CONFIG_OF_IOMMU) += of_iommu.o
>  obj-$(CONFIG_MSM_IOMMU) += msm_iommu.o
>  obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o
> +obj-$(CONFIG_IOMMU_DEBUG) += amd_iommu_debugfs.o

Compiling amd_iommu_debugfs.c seems to depend only
on CONFIG_IOMMU_DEBUG. Can we prevent the code within
amd_iommu_debugfs.c from getting compiled when either CONFIG_AMD_IOMMU
or CONFIG_IOMMU_DEBUG is disabled?

>  obj-$(CONFIG_AMD_IOMMU_V2) += amd_iommu_v2.o
>  obj-$(CONFIG_ARM_SMMU) += arm-smmu.o
>  obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o

  parent reply	other threads:[~2018-04-17  0:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 13:17 [PATCH v3 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-04-06 13:17 ` Gary R Hook
     [not found] ` <152302042701.47565.17954813724758433858.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-06 13:17   ` [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Gary R Hook
2018-04-06 13:17     ` Gary R Hook
     [not found]     ` <152302066417.47565.4017200105445420643.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-13 23:55       ` Mehta, Sohil
2018-04-13 23:55         ` Mehta, Sohil
     [not found]         ` <1523663790.2747.4.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-17 17:36           ` Hook, Gary
2018-04-17 17:36             ` Hook, Gary
     [not found]             ` <10e422dd-a3ca-8ecb-50fa-e7f131a55a12-5C7GfCeVMHo@public.gmane.org>
2018-04-17 17:55               ` Robin Murphy
2018-04-17 17:55                 ` Robin Murphy
2018-04-17 18:06                 ` Hook, Gary
2018-04-17 17:46       ` Hook, Gary
2018-04-17 17:46         ` Hook, Gary
     [not found]         ` <9123cd44-e01f-bff6-8441-792acbde10bc-5C7GfCeVMHo@public.gmane.org>
2018-04-17 18:13           ` Robin Murphy
2018-04-17 18:13             ` Robin Murphy
2018-04-06 13:17   ` [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-04-06 13:17     ` Gary R Hook
     [not found]     ` <152302067362.47565.628887796165116844.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-14  0:08       ` Mehta, Sohil
2018-04-14  0:08         ` Mehta, Sohil
2018-04-17 17:38         ` Hook, Gary
     [not found]           ` <efa2b7a3-04a7-20b1-3651-89ebafa85c27-5C7GfCeVMHo@public.gmane.org>
2018-04-18  5:58             ` Yang, Shunyong
2018-04-18  5:58               ` Yang, Shunyong
     [not found]               ` <1524031122.4031.5.camel-PT9Dzx9SjPiXmMXjJBpWqg@public.gmane.org>
2018-04-18  7:27                 ` Mehta, Sohil
2018-04-18  7:27                   ` Mehta, Sohil
2018-04-18  8:31                   ` Yang, Shunyong
2018-04-18 20:16                     ` Mehta, Sohil
     [not found]                       ` <1524082659.2747.37.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-18 20:51                         ` Hook, Gary
2018-04-18 20:51                           ` Hook, Gary
2018-04-19  1:52                           ` Yang, Shunyong
2018-04-30 19:57             ` Gary R Hook
2018-04-30 19:57               ` Gary R Hook
2018-04-17  0:52       ` Mehta, Sohil [this message]
2018-04-17  0:52         ` Mehta, Sohil
     [not found]         ` <1523926423.2747.19.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-17 17:42           ` Hook, Gary
2018-04-17 17:42             ` Hook, Gary
2018-04-17 18:05             ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523926423.2747.19.camel@intel.com \
    --to=sohil.mehta-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=gary.hook-5C7GfCeVMHo@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.