All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lindsay <alindsay@codeaurora.org>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair.francis@xilinx.com>,
	Wei Huang <wei@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Aaron Lindsay <alindsay@codeaurora.org>,
	Aaron Lindsay <aclindsa@gmail.com>,
	Michael Spradling <mspradli@codeaurora.org>,
	qemu-devel@nongnu.org, Digant Desai <digantd@codeaurora.org>
Subject: [Qemu-arm] [PATCH v5 03/13] target/arm: Allow AArch32 access for PMCCFILTR
Date: Fri, 22 Jun 2018 16:32:17 -0400	[thread overview]
Message-ID: <1529699547-17044-4-git-send-email-alindsay@codeaurora.org> (raw)
In-Reply-To: <1529699547-17044-1-git-send-email-alindsay@codeaurora.org>

Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
---
 target/arm/helper.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 7c66977..7d63bb2 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -949,6 +949,10 @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
 #define PMXEVTYPER_MT         0x02000000
 #define PMXEVTYPER_EVTCOUNT   0x000003ff
 
+#define PMCCFILTR             0xf8000000
+#define PMCCFILTR_M           PMXEVTYPER_M
+#define PMCCFILTR_EL0         (PMCCFILTR | PMCCFILTR_M)
+
 static inline uint32_t pmu_num_counters(CPUARMState *env)
 {
   return (env->cp15.c9_pmcr & PMCRN_MASK) >> PMCRN_SHIFT;
@@ -1252,10 +1256,26 @@ static void pmccfiltr_write(CPUARMState *env, const ARMCPRegInfo *ri,
                             uint64_t value)
 {
     pmccntr_op_start(env);
-    env->cp15.pmccfiltr_el0 = value & 0xfc000000;
+    env->cp15.pmccfiltr_el0 = value & PMCCFILTR_EL0;
     pmccntr_op_finish(env);
 }
 
+static void pmccfiltr_write_a32(CPUARMState *env, const ARMCPRegInfo *ri,
+                            uint64_t value)
+{
+    pmccntr_op_start(env);
+    /* M is not accessible from AArch32 */
+    env->cp15.pmccfiltr_el0 = (env->cp15.pmccfiltr_el0 & PMCCFILTR_M) |
+        (value & PMCCFILTR);
+    pmccntr_op_finish(env);
+}
+
+static uint64_t pmccfiltr_read_a32(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    /* M is not visible in AArch32 */
+    return env->cp15.pmccfiltr_el0 & PMCCFILTR;
+}
+
 static void pmcntenset_write(CPUARMState *env, const ARMCPRegInfo *ri,
                             uint64_t value)
 {
@@ -1474,6 +1494,11 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .type = ARM_CP_IO,
       .readfn = pmccntr_read, .writefn = pmccntr_write, },
 #endif
+    { .name = "PMCCFILTR", .cp = 15, .opc1 = 0, .crn = 14, .crm = 15, .opc2 = 7,
+      .writefn = pmccfiltr_write_a32, .readfn = pmccfiltr_read_a32,
+      .access = PL0_RW, .accessfn = pmreg_access,
+      .type = ARM_CP_ALIAS | ARM_CP_IO,
+      .resetvalue = 0, },
     { .name = "PMCCFILTR_EL0", .state = ARM_CP_STATE_AA64,
       .opc0 = 3, .opc1 = 3, .crn = 14, .crm = 15, .opc2 = 7,
       .writefn = pmccfiltr_write,
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.


WARNING: multiple messages have this Message-ID (diff)
From: Aaron Lindsay <alindsay@codeaurora.org>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair.francis@xilinx.com>,
	Wei Huang <wei@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: qemu-devel@nongnu.org,
	Michael Spradling <mspradli@codeaurora.org>,
	Digant Desai <digantd@codeaurora.org>,
	Aaron Lindsay <aclindsa@gmail.com>,
	Aaron Lindsay <alindsay@codeaurora.org>
Subject: [Qemu-devel] [PATCH v5 03/13] target/arm: Allow AArch32 access for PMCCFILTR
Date: Fri, 22 Jun 2018 16:32:17 -0400	[thread overview]
Message-ID: <1529699547-17044-4-git-send-email-alindsay@codeaurora.org> (raw)
In-Reply-To: <1529699547-17044-1-git-send-email-alindsay@codeaurora.org>

Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
---
 target/arm/helper.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 7c66977..7d63bb2 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -949,6 +949,10 @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
 #define PMXEVTYPER_MT         0x02000000
 #define PMXEVTYPER_EVTCOUNT   0x000003ff
 
+#define PMCCFILTR             0xf8000000
+#define PMCCFILTR_M           PMXEVTYPER_M
+#define PMCCFILTR_EL0         (PMCCFILTR | PMCCFILTR_M)
+
 static inline uint32_t pmu_num_counters(CPUARMState *env)
 {
   return (env->cp15.c9_pmcr & PMCRN_MASK) >> PMCRN_SHIFT;
@@ -1252,10 +1256,26 @@ static void pmccfiltr_write(CPUARMState *env, const ARMCPRegInfo *ri,
                             uint64_t value)
 {
     pmccntr_op_start(env);
-    env->cp15.pmccfiltr_el0 = value & 0xfc000000;
+    env->cp15.pmccfiltr_el0 = value & PMCCFILTR_EL0;
     pmccntr_op_finish(env);
 }
 
+static void pmccfiltr_write_a32(CPUARMState *env, const ARMCPRegInfo *ri,
+                            uint64_t value)
+{
+    pmccntr_op_start(env);
+    /* M is not accessible from AArch32 */
+    env->cp15.pmccfiltr_el0 = (env->cp15.pmccfiltr_el0 & PMCCFILTR_M) |
+        (value & PMCCFILTR);
+    pmccntr_op_finish(env);
+}
+
+static uint64_t pmccfiltr_read_a32(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    /* M is not visible in AArch32 */
+    return env->cp15.pmccfiltr_el0 & PMCCFILTR;
+}
+
 static void pmcntenset_write(CPUARMState *env, const ARMCPRegInfo *ri,
                             uint64_t value)
 {
@@ -1474,6 +1494,11 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .type = ARM_CP_IO,
       .readfn = pmccntr_read, .writefn = pmccntr_write, },
 #endif
+    { .name = "PMCCFILTR", .cp = 15, .opc1 = 0, .crn = 14, .crm = 15, .opc2 = 7,
+      .writefn = pmccfiltr_write_a32, .readfn = pmccfiltr_read_a32,
+      .access = PL0_RW, .accessfn = pmreg_access,
+      .type = ARM_CP_ALIAS | ARM_CP_IO,
+      .resetvalue = 0, },
     { .name = "PMCCFILTR_EL0", .state = ARM_CP_STATE_AA64,
       .opc0 = 3, .opc1 = 3, .crn = 14, .crm = 15, .opc2 = 7,
       .writefn = pmccfiltr_write,
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2018-06-22 20:32 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 20:32 [Qemu-arm] [PATCH v5 00/13] More fully implement ARM PMUv3 Aaron Lindsay
2018-06-22 20:32 ` [Qemu-devel] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 01/13] target/arm: Reorganize PMCCNTR accesses Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-28 16:40   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:40     ` [Qemu-devel] " Peter Maydell
2018-08-28 20:03     ` [Qemu-arm] " Aaron Lindsay
2018-08-28 20:03       ` [Qemu-devel] " Aaron Lindsay
2018-09-25 15:18       ` Peter Maydell
2018-09-26 15:22         ` [Qemu-arm] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 02/13] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-07-17 15:49   ` [Qemu-arm] " Peter Maydell
2018-07-17 15:49     ` [Qemu-devel] " Peter Maydell
2018-06-22 20:32 ` Aaron Lindsay [this message]
2018-06-22 20:32   ` [Qemu-devel] [PATCH v5 03/13] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-06-28 16:30   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:30     ` [Qemu-devel] " Peter Maydell
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 04/13] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-28 16:20   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:20     ` [Qemu-devel] " Peter Maydell
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 05/13] target/arm: Remove redundant DIV detection for KVM Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-28 16:21   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:21     ` [Qemu-devel] " Peter Maydell
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 06/13] target/arm: Implement PMOVSSET Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-28 16:23   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:23     ` [Qemu-devel] " Peter Maydell
2018-08-28 20:29     ` Aaron Lindsay
2018-08-28 20:29       ` Aaron Lindsay
2018-06-22 20:32 ` [Qemu-devel] [PATCH v5 07/13] target/arm: Add array for supported PMU events, generate PMCEID[01] Aaron Lindsay
2018-06-22 20:32   ` Aaron Lindsay
2018-07-17 16:06   ` [Qemu-arm] " Peter Maydell
2018-07-17 16:06     ` [Qemu-devel] " Peter Maydell
2018-08-29 15:18     ` [Qemu-arm] " Aaron Lindsay
2018-08-29 15:18       ` [Qemu-devel] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 08/13] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-07-17 16:17   ` [Qemu-arm] " Peter Maydell
2018-07-17 16:17     ` [Qemu-devel] " Peter Maydell
2018-08-29 15:31     ` [Qemu-arm] " Aaron Lindsay
2018-08-29 15:31       ` [Qemu-devel] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 09/13] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-07-17 16:11   ` [Qemu-arm] " Peter Maydell
2018-07-17 16:11     ` [Qemu-devel] " Peter Maydell
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 10/13] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 11/13] target/arm: Implement PMSWINC Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 12/13] target/arm: Mark PMINTENSET accesses as possibly doing IO Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-06-28 16:25   ` [Qemu-arm] " Peter Maydell
2018-06-28 16:25     ` [Qemu-devel] " Peter Maydell
2018-08-27 14:48     ` Aaron Lindsay
2018-08-27 14:48       ` Aaron Lindsay
2018-06-22 20:32 ` [Qemu-arm] [PATCH v5 13/13] target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2018-06-22 20:32   ` [Qemu-devel] " Aaron Lindsay
2018-07-17 16:28   ` [Qemu-arm] " Peter Maydell
2018-07-17 16:28     ` [Qemu-devel] " Peter Maydell
2018-06-28 16:42 ` [Qemu-arm] [PATCH v5 00/13] More fully implement ARM PMUv3 Peter Maydell
2018-06-28 16:42   ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529699547-17044-4-git-send-email-alindsay@codeaurora.org \
    --to=alindsay@codeaurora.org \
    --cc=aclindsa@gmail.com \
    --cc=alistair.francis@xilinx.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=digantd@codeaurora.org \
    --cc=mspradli@codeaurora.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.