From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Wed, 11 Jul 2018 15:45:52 +0200 [thread overview]
Message-ID: <1531316752.2708.113.camel@baylibre.com> (raw)
In-Reply-To: <454887b2-6d29-4fe9-ee34-400363671746@amlogic.com>
On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote:
> > > > > +static struct clk_regmap g12a_mpll0 = {
> > > > > + .data = &(struct clk_regmap_gate_data){
> > > > > + .offset = HHI_MPLL_CNTL1,
> > > > > + .bit_idx = 31,
> > > > > + },
> > > > > + .hw.init = &(struct clk_init_data){
> > > > > + .name = "mpll0",
> > > > > + .ops = &clk_regmap_gate_ops,
> > > > > + .parent_names = (const char *[]){ "mpll0_div" },
> > > > > + .num_parents = 1,
> > > > > + .flags = CLK_SET_RATE_PARENT,
> > > > > + },
> > > > > +};
> >
> > The previous had a predivider (1 or 2) in front of these mpll. Even if the
> > predivider is usually set to be a passthrough, it is better to model the tree
> > correctly.
> >
> > Is this SoC any different ?
> >
>
> I am not sure the difference, I will confirm with IC design guys.
I suggest that you have a look at the (upstream) axg and gxbb clock driver for
this
Same goes for the fdiv gates.
Last, please trim your replies a bit. It will make easier to see what you are
replying to.
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Jian Hu <jian.hu@amlogic.com>, Yixun Lan <yixun.lan@amlogic.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
qianggui.song@amlogic.com, sboyd@kernel.org,
khilman@baylibre.com, mturquette@baylibre.com,
linux-kernel@vger.kernel.org, bo.yang@amlogic.com,
qiufang.dai@amlogic.com, linux-arm-kernel@lists.infradead.org,
carlo@caione.org, linux-amlogic@lists.infradead.org,
sunny.luo@amlogic.com, linux-clk@vger.kernel.org,
xingyu.chen@amlogic.com, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Wed, 11 Jul 2018 15:45:52 +0200 [thread overview]
Message-ID: <1531316752.2708.113.camel@baylibre.com> (raw)
In-Reply-To: <454887b2-6d29-4fe9-ee34-400363671746@amlogic.com>
On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote:
> > > > > +static struct clk_regmap g12a_mpll0 = {
> > > > > + .data = &(struct clk_regmap_gate_data){
> > > > > + .offset = HHI_MPLL_CNTL1,
> > > > > + .bit_idx = 31,
> > > > > + },
> > > > > + .hw.init = &(struct clk_init_data){
> > > > > + .name = "mpll0",
> > > > > + .ops = &clk_regmap_gate_ops,
> > > > > + .parent_names = (const char *[]){ "mpll0_div" },
> > > > > + .num_parents = 1,
> > > > > + .flags = CLK_SET_RATE_PARENT,
> > > > > + },
> > > > > +};
> >
> > The previous had a predivider (1 or 2) in front of these mpll. Even if the
> > predivider is usually set to be a passthrough, it is better to model the tree
> > correctly.
> >
> > Is this SoC any different ?
> >
>
> I am not sure the difference, I will confirm with IC design guys.
I suggest that you have a look at the (upstream) axg and gxbb clock driver for
this
Same goes for the fdiv gates.
Last, please trim your replies a bit. It will make easier to see what you are
replying to.
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Wed, 11 Jul 2018 15:45:52 +0200 [thread overview]
Message-ID: <1531316752.2708.113.camel@baylibre.com> (raw)
In-Reply-To: <454887b2-6d29-4fe9-ee34-400363671746@amlogic.com>
On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote:
> > > > > +static struct clk_regmap g12a_mpll0 = {
> > > > > + .data = &(struct clk_regmap_gate_data){
> > > > > + .offset = HHI_MPLL_CNTL1,
> > > > > + .bit_idx = 31,
> > > > > + },
> > > > > + .hw.init = &(struct clk_init_data){
> > > > > + .name = "mpll0",
> > > > > + .ops = &clk_regmap_gate_ops,
> > > > > + .parent_names = (const char *[]){ "mpll0_div" },
> > > > > + .num_parents = 1,
> > > > > + .flags = CLK_SET_RATE_PARENT,
> > > > > + },
> > > > > +};
> >
> > The previous had a predivider (1 or 2) in front of these mpll. Even if the
> > predivider is usually set to be a passthrough, it is better to model the tree
> > correctly.
> >
> > Is this SoC any different ?
> >
>
> I am not sure the difference, I will confirm with IC design guys.
I suggest that you have a look at the (upstream) axg and gxbb clock driver for
this
Same goes for the fdiv gates.
Last, please trim your replies a bit. It will make easier to see what you are
replying to.
next prev parent reply other threads:[~2018-07-11 13:45 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 11:12 [PATCH 0/3] clk: meson-g12a: Add EE clock controller driver Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-10 9:29 ` Jerome Brunet
2018-07-10 9:29 ` Jerome Brunet
2018-07-10 9:29 ` Jerome Brunet
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-09 11:12 ` [PATCH 2/3] dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-10 9:26 ` Jerome Brunet
2018-07-10 9:26 ` Jerome Brunet
2018-07-10 9:26 ` Jerome Brunet
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-09 11:12 ` [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-11 6:33 ` Jian Hu
2018-07-11 6:33 ` Jian Hu
2018-07-11 6:33 ` Jian Hu
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-10 1:21 ` Yixun Lan
2018-07-10 1:21 ` Yixun Lan
2018-07-10 1:21 ` Yixun Lan
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 12:59 ` Yixun Lan
2018-07-10 12:59 ` Yixun Lan
2018-07-10 12:59 ` Yixun Lan
2018-07-10 15:51 ` Jerome Brunet
2018-07-10 15:51 ` Jerome Brunet
2018-07-10 15:51 ` Jerome Brunet
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:45 ` Jerome Brunet [this message]
2018-07-11 13:45 ` Jerome Brunet
2018-07-11 13:45 ` Jerome Brunet
2018-07-16 5:58 ` Jian Hu
2018-07-16 5:58 ` Jian Hu
2018-07-16 5:58 ` Jian Hu
2018-07-16 13:38 ` Kevin Hilman
2018-07-16 13:38 ` Kevin Hilman
2018-07-16 13:38 ` Kevin Hilman
2018-07-17 1:24 ` Yixun Lan
2018-07-17 1:24 ` Yixun Lan
2018-07-17 1:24 ` Yixun Lan
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:53 ` Kevin Hilman
2018-07-19 14:53 ` Kevin Hilman
2018-07-19 14:53 ` Kevin Hilman
2018-07-11 8:05 ` Jian Hu
2018-07-11 8:05 ` Jian Hu
2018-07-11 8:05 ` Jian Hu
2018-07-16 13:41 ` Kevin Hilman
2018-07-16 13:41 ` Kevin Hilman
2018-07-16 13:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531316752.2708.113.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.