From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Mon, 16 Jul 2018 08:41:35 -0500 [thread overview]
Message-ID: <7hbmb7mh68.fsf@baylibre.com> (raw)
In-Reply-To: <be3c7332-3a7d-f8b0-efe4-e2a319273c42@amlogic.com> (Jian Hu's message of "Wed, 11 Jul 2018 16:05:54 +0800")
Jian Hu <jian.hu@amlogic.com> writes:
> On 2018/7/10 5:53, Martin Blumenstingl wrote:
>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic.com> wrote:
[...]
>>> +static const struct of_device_id clkc_match_table[] = {
>>> + { .compatible = "amlogic,g12a-clkc" },
>> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> correct - I'll CC Rob Herring on the dt-bindings patch)
>>
> For clock drivers,they omit the "meson-" prefix, But for common
> amlogic drivers use "amlogic.meson-<chip>-<ip>".
> So which type should we choose? .compatible = "amlogic,g12a-clkc or
>
> .compatible = "amlogic,meson-g12a-clkc
Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Jian Hu <jian.hu@amlogic.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
<qianggui.song@amlogic.com>, <sboyd@kernel.org>,
<mturquette@baylibre.com>, <yixun.lan@amlogic.com>,
<linux-kernel@vger.kernel.org>, <bo.yang@amlogic.com>,
<qiufang.dai@amlogic.com>,
<linux-arm-kernel@lists.infradead.org>, <carlo@caione.org>,
<linux-amlogic@lists.infradead.org>, <sunny.luo@amlogic.com>,
<linux-clk@vger.kernel.org>, <xingyu.chen@amlogic.com>
Subject: Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Mon, 16 Jul 2018 08:41:35 -0500 [thread overview]
Message-ID: <7hbmb7mh68.fsf@baylibre.com> (raw)
In-Reply-To: <be3c7332-3a7d-f8b0-efe4-e2a319273c42@amlogic.com> (Jian Hu's message of "Wed, 11 Jul 2018 16:05:54 +0800")
Jian Hu <jian.hu@amlogic.com> writes:
> On 2018/7/10 5:53, Martin Blumenstingl wrote:
>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic.com> wrote:
[...]
>>> +static const struct of_device_id clkc_match_table[] = {
>>> + { .compatible = "amlogic,g12a-clkc" },
>> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> correct - I'll CC Rob Herring on the dt-bindings patch)
>>
> For clock drivers,they omit the "meson-" prefix, But for common
> amlogic drivers use "amlogic.meson-<chip>-<ip>".
> So which type should we choose? .compatible = "amlogic,g12a-clkc or
>
> .compatible = "amlogic,meson-g12a-clkc
Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Mon, 16 Jul 2018 08:41:35 -0500 [thread overview]
Message-ID: <7hbmb7mh68.fsf@baylibre.com> (raw)
In-Reply-To: <be3c7332-3a7d-f8b0-efe4-e2a319273c42@amlogic.com> (Jian Hu's message of "Wed, 11 Jul 2018 16:05:54 +0800")
Jian Hu <jian.hu@amlogic.com> writes:
> On 2018/7/10 5:53, Martin Blumenstingl wrote:
>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic.com> wrote:
[...]
>>> +static const struct of_device_id clkc_match_table[] = {
>>> + { .compatible = "amlogic,g12a-clkc" },
>> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> correct - I'll CC Rob Herring on the dt-bindings patch)
>>
> For clock drivers,they omit the "meson-" prefix, But for common
> amlogic drivers use "amlogic.meson-<chip>-<ip>".
> So which type should we choose? .compatible = "amlogic,g12a-clkc or
>
> .compatible = "amlogic,meson-g12a-clkc
Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.
Kevin
next prev parent reply other threads:[~2018-07-16 13:41 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 11:12 [PATCH 0/3] clk: meson-g12a: Add EE clock controller driver Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-11 8:10 ` Jian Hu
2018-07-10 9:29 ` Jerome Brunet
2018-07-10 9:29 ` Jerome Brunet
2018-07-10 9:29 ` Jerome Brunet
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-11 13:04 ` Jian Hu
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-09 11:12 ` [PATCH 2/3] dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-10 9:26 ` Jerome Brunet
2018-07-10 9:26 ` Jerome Brunet
2018-07-10 9:26 ` Jerome Brunet
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 12:53 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-09 11:12 ` [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 11:12 ` Jian Hu
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-09 14:58 ` Stephen Boyd
2018-07-11 6:33 ` Jian Hu
2018-07-11 6:33 ` Jian Hu
2018-07-11 6:33 ` Jian Hu
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-10 1:21 ` Yixun Lan
2018-07-10 1:21 ` Yixun Lan
2018-07-10 1:21 ` Yixun Lan
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 12:59 ` Yixun Lan
2018-07-10 12:59 ` Yixun Lan
2018-07-10 12:59 ` Yixun Lan
2018-07-10 15:51 ` Jerome Brunet
2018-07-10 15:51 ` Jerome Brunet
2018-07-10 15:51 ` Jerome Brunet
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:45 ` Jerome Brunet
2018-07-11 13:45 ` Jerome Brunet
2018-07-11 13:45 ` Jerome Brunet
2018-07-16 5:58 ` Jian Hu
2018-07-16 5:58 ` Jian Hu
2018-07-16 5:58 ` Jian Hu
2018-07-16 13:38 ` Kevin Hilman
2018-07-16 13:38 ` Kevin Hilman
2018-07-16 13:38 ` Kevin Hilman
2018-07-17 1:24 ` Yixun Lan
2018-07-17 1:24 ` Yixun Lan
2018-07-17 1:24 ` Yixun Lan
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:53 ` Kevin Hilman
2018-07-19 14:53 ` Kevin Hilman
2018-07-19 14:53 ` Kevin Hilman
2018-07-11 8:05 ` Jian Hu
2018-07-11 8:05 ` Jian Hu
2018-07-11 8:05 ` Jian Hu
2018-07-16 13:41 ` Kevin Hilman [this message]
2018-07-16 13:41 ` Kevin Hilman
2018-07-16 13:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hbmb7mh68.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.