From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Markus Armbruster" <armbru@redhat.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
qemu-arm@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-arm] [PATCH v3 02/17] hw/core/sysbus: Add a function for creating and attaching an object
Date: Mon, 16 Jul 2018 14:59:19 +0200 [thread overview]
Message-ID: <1531745974-17187-3-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1531745974-17187-1-git-send-email-thuth@redhat.com>
A lot of functions are initializing an object and attach it immediately
afterwards to the system bus. Provide a common function for this, which
also uses object_initialize_child() to make sure that the reference
counter is correctly initialized to 1 afterwards.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/core/sysbus.c | 8 ++++++++
include/hw/sysbus.h | 17 +++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index ecfb0cf..3c8e53b 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -376,6 +376,14 @@ BusState *sysbus_get_default(void)
return main_system_bus;
}
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype)
+{
+ object_initialize_child(parent, childname, child, childsize, childtype,
+ &error_abort, NULL);
+ qdev_set_parent_bus(DEVICE(child), sysbus_get_default());
+}
+
static void sysbus_register_types(void)
{
type_register_static(&system_bus_info);
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index e88bb6d..0b59a3b 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -96,6 +96,23 @@ void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
MemoryRegion *mem);
MemoryRegion *sysbus_address_space(SysBusDevice *dev);
+/**
+ * sysbus_init_child_obj:
+ * @parent: The parent object
+ * @childname: Used as name of the "child<>" property in the parent
+ * @child: A pointer to the memory to be used for the object.
+ * @childsize: The maximum size available at @child for the object.
+ * @childtype: The name of the type of the object to instantiate.
+ *
+ * This function will initialize an object and attach it to the main system
+ * bus. The memory for the object should have already been allocated. The
+ * object will then be added as child to the given parent. The returned object
+ * has a reference count of 1 (for the "child<...>" property from the parent),
+ * so the object will be finalized automatically when the parent gets removed.
+ */
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype);
+
/* Call func for every dynamically created sysbus device in the system */
void foreach_dynamic_sysbus_device(FindSysbusDeviceFunc *func, void *opaque);
--
1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v3 02/17] hw/core/sysbus: Add a function for creating and attaching an object
Date: Mon, 16 Jul 2018 14:59:19 +0200 [thread overview]
Message-ID: <1531745974-17187-3-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1531745974-17187-1-git-send-email-thuth@redhat.com>
A lot of functions are initializing an object and attach it immediately
afterwards to the system bus. Provide a common function for this, which
also uses object_initialize_child() to make sure that the reference
counter is correctly initialized to 1 afterwards.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/core/sysbus.c | 8 ++++++++
include/hw/sysbus.h | 17 +++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index ecfb0cf..3c8e53b 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -376,6 +376,14 @@ BusState *sysbus_get_default(void)
return main_system_bus;
}
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype)
+{
+ object_initialize_child(parent, childname, child, childsize, childtype,
+ &error_abort, NULL);
+ qdev_set_parent_bus(DEVICE(child), sysbus_get_default());
+}
+
static void sysbus_register_types(void)
{
type_register_static(&system_bus_info);
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index e88bb6d..0b59a3b 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -96,6 +96,23 @@ void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
MemoryRegion *mem);
MemoryRegion *sysbus_address_space(SysBusDevice *dev);
+/**
+ * sysbus_init_child_obj:
+ * @parent: The parent object
+ * @childname: Used as name of the "child<>" property in the parent
+ * @child: A pointer to the memory to be used for the object.
+ * @childsize: The maximum size available at @child for the object.
+ * @childtype: The name of the type of the object to instantiate.
+ *
+ * This function will initialize an object and attach it to the main system
+ * bus. The memory for the object should have already been allocated. The
+ * object will then be added as child to the given parent. The returned object
+ * has a reference count of 1 (for the "child<...>" property from the parent),
+ * so the object will be finalized automatically when the parent gets removed.
+ */
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype);
+
/* Call func for every dynamically created sysbus device in the system */
void foreach_dynamic_sysbus_device(FindSysbusDeviceFunc *func, void *opaque);
--
1.8.3.1
next prev parent reply other threads:[~2018-07-16 12:59 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:59 [Qemu-arm] [PATCH v3 00/17] Fix crashes with introspection of ARM devices Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 01/17] qom/object: Add a new function object_initialize_child() Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:06 ` [Qemu-arm] " Eduardo Habkost
2018-07-16 21:06 ` [Qemu-devel] " Eduardo Habkost
2018-07-16 12:59 ` Thomas Huth [this message]
2018-07-16 12:59 ` [Qemu-devel] [PATCH v3 02/17] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-16 21:53 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:53 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 03/17] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 04/17] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:57 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:57 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 05/17] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:55 ` Alistair Francis
2018-07-16 21:55 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 06/17] hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 07/17] hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:03 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:03 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 08/17] hw/arm/fsl-imx6: Fix introspection problems with the "fsl, imx6" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 09/17] hw/arm/fsl-imx7: Fix introspection problems with the "fsl, imx7" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 10/17] hw/arm/fsl-imx25: Fix introspection problem with the "fsl, imx25" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 11/17] hw/arm/fsl-imx31: Fix introspection problem with the "fsl, imx31" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 12/17] hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:06 ` Alistair Francis
2018-07-16 22:06 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-devel] [PATCH v3 13/17] hw/*/realview: Fix introspection problem with 'realview_mpcore' & 'realview_gic' Thomas Huth
2018-07-16 12:59 ` Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 14/17] hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 15/17] hw/arm/stm32f205_soc: Fix introspection problem with 'stm32f205-soc' device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 13:52 ` [Qemu-arm] " Peter Maydell
2018-07-16 13:52 ` [Qemu-devel] " Peter Maydell
2018-07-16 21:07 ` [Qemu-arm] " Eduardo Habkost
2018-07-16 21:07 ` [Qemu-devel] " Eduardo Habkost
2018-07-16 21:59 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:59 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 16/17] hw/display/xlnx_dp: Move problematic code from instance_init to realize Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 13:56 ` [Qemu-arm] " Peter Maydell
2018-07-16 13:56 ` [Qemu-devel] " Peter Maydell
2018-07-16 22:06 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:06 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 17/17] hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx, zynqmp" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:08 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:08 ` Alistair Francis
2018-07-17 12:14 ` [Qemu-arm] [PATCH v3 00/17] Fix crashes with introspection of ARM devices Peter Maydell
2018-07-17 12:14 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531745974-17187-3-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=afaerber@suse.de \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.