From: Eduardo Habkost <ehabkost@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-arm] [PATCH v3 15/17] hw/arm/stm32f205_soc: Fix introspection problem with 'stm32f205-soc' device
Date: Mon, 16 Jul 2018 18:07:15 -0300 [thread overview]
Message-ID: <20180716210715.GT31657@localhost.localdomain> (raw)
In-Reply-To: <1531745974-17187-16-git-send-email-thuth@redhat.com>
On Mon, Jul 16, 2018 at 02:59:32PM +0200, Thomas Huth wrote:
> Valgrind complains:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'stm32f205-soc'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments': {'command-line': 'info qtree'}}" | \
> valgrind -q aarch64-softmmu/qemu-system-aarch64 -M none,accel=qtest -qmp stdio
> [...]
> ==28531== Invalid read of size 8
> ==28531== at 0x6185BA: qdev_print (qdev-monitor.c:686)
> ==28531== by 0x6185BA: qbus_print (qdev-monitor.c:719)
> ==28531== by 0x452B38: handle_hmp_command (monitor.c:3446)
> [...]
>
> Fix it with the new sysbus_init_child_obj() function.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 15/17] hw/arm/stm32f205_soc: Fix introspection problem with 'stm32f205-soc' device
Date: Mon, 16 Jul 2018 18:07:15 -0300 [thread overview]
Message-ID: <20180716210715.GT31657@localhost.localdomain> (raw)
In-Reply-To: <1531745974-17187-16-git-send-email-thuth@redhat.com>
On Mon, Jul 16, 2018 at 02:59:32PM +0200, Thomas Huth wrote:
> Valgrind complains:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'stm32f205-soc'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments': {'command-line': 'info qtree'}}" | \
> valgrind -q aarch64-softmmu/qemu-system-aarch64 -M none,accel=qtest -qmp stdio
> [...]
> ==28531== Invalid read of size 8
> ==28531== at 0x6185BA: qdev_print (qdev-monitor.c:686)
> ==28531== by 0x6185BA: qbus_print (qdev-monitor.c:719)
> ==28531== by 0x452B38: handle_hmp_command (monitor.c:3446)
> [...]
>
> Fix it with the new sysbus_init_child_obj() function.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2018-07-16 21:07 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:59 [Qemu-arm] [PATCH v3 00/17] Fix crashes with introspection of ARM devices Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 01/17] qom/object: Add a new function object_initialize_child() Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:06 ` [Qemu-arm] " Eduardo Habkost
2018-07-16 21:06 ` [Qemu-devel] " Eduardo Habkost
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 02/17] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:53 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:53 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 03/17] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 04/17] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:57 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:57 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 05/17] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 21:55 ` Alistair Francis
2018-07-16 21:55 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 06/17] hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 07/17] hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:03 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:03 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 08/17] hw/arm/fsl-imx6: Fix introspection problems with the "fsl, imx6" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 09/17] hw/arm/fsl-imx7: Fix introspection problems with the "fsl, imx7" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 10/17] hw/arm/fsl-imx25: Fix introspection problem with the "fsl, imx25" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 11/17] hw/arm/fsl-imx31: Fix introspection problem with the "fsl, imx31" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 12/17] hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:06 ` Alistair Francis
2018-07-16 22:06 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-devel] [PATCH v3 13/17] hw/*/realview: Fix introspection problem with 'realview_mpcore' & 'realview_gic' Thomas Huth
2018-07-16 12:59 ` Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 14/17] hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 15/17] hw/arm/stm32f205_soc: Fix introspection problem with 'stm32f205-soc' device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 13:52 ` [Qemu-arm] " Peter Maydell
2018-07-16 13:52 ` [Qemu-devel] " Peter Maydell
2018-07-16 21:07 ` Eduardo Habkost [this message]
2018-07-16 21:07 ` Eduardo Habkost
2018-07-16 21:59 ` [Qemu-arm] " Alistair Francis
2018-07-16 21:59 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 16/17] hw/display/xlnx_dp: Move problematic code from instance_init to realize Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 13:56 ` [Qemu-arm] " Peter Maydell
2018-07-16 13:56 ` [Qemu-devel] " Peter Maydell
2018-07-16 22:06 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:06 ` Alistair Francis
2018-07-16 12:59 ` [Qemu-arm] [PATCH v3 17/17] hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx, zynqmp" device Thomas Huth
2018-07-16 12:59 ` [Qemu-devel] " Thomas Huth
2018-07-16 22:08 ` [Qemu-arm] " Alistair Francis
2018-07-16 22:08 ` Alistair Francis
2018-07-17 12:14 ` [Qemu-arm] [PATCH v3 00/17] Fix crashes with introspection of ARM devices Peter Maydell
2018-07-17 12:14 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716210715.GT31657@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.