All of lore.kernel.org
 help / color / mirror / Atom feed
From: zohar@linux.ibm.com (Mimi Zohar)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] security: export security_kernel_load_data to fix firmware_loader build
Date: Thu, 19 Jul 2018 18:39:17 -0400	[thread overview]
Message-ID: <1532039957.4196.2.camel@linux.ibm.com> (raw)
In-Reply-To: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org>

Thanks, Randy.

On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
> 
> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: linux-security-module at vger.kernel.org
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  security/security.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20180717.orig/security/security.c
> +++ linux-next-20180717/security/security.c
> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
>  		return ret;
>  	return ima_load_data(id);
>  }
> +EXPORT_SYMBOL_GPL(security_kernel_load_data);

Arnd Bergmann already posted a similar patch, which is now staged in
James' tree.

Mimi

> 
>  int security_task_fix_setuid(struct cred *new, const struct cred *old,
>  			     int flags)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-security-module <linux-security-module@vger.kernel.org>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] security: export security_kernel_load_data to fix firmware_loader build
Date: Thu, 19 Jul 2018 18:39:17 -0400	[thread overview]
Message-ID: <1532039957.4196.2.camel@linux.ibm.com> (raw)
In-Reply-To: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org>

Thanks, Randy.

On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
> 
> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: linux-security-module@vger.kernel.org
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  security/security.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20180717.orig/security/security.c
> +++ linux-next-20180717/security/security.c
> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
>  		return ret;
>  	return ima_load_data(id);
>  }
> +EXPORT_SYMBOL_GPL(security_kernel_load_data);

Arnd Bergmann already posted a similar patch, which is now staged in
James' tree.

Mimi

> 
>  int security_task_fix_setuid(struct cred *new, const struct cred *old,
>  			     int flags)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2018-07-19 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 20:15 [PATCH] security: export security_kernel_load_data to fix firmware_loader build Randy Dunlap
2018-07-19 20:15 ` Randy Dunlap
2018-07-19 22:39 ` Mimi Zohar [this message]
2018-07-19 22:39   ` Mimi Zohar
2018-07-19 22:40   ` Randy Dunlap
2018-07-19 22:40     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532039957.4196.2.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.