All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
	ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
	David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH v2 1/3] cfg80211: support FTM responder configuration/statistics
Date: Mon, 03 Sep 2018 11:29:48 +0200	[thread overview]
Message-ID: <1535966988.3437.24.camel@sipsolutions.net> (raw)
In-Reply-To: <1535745418-31336-2-git-send-email-pradeepc@codeaurora.org>


> +struct cfg80211_ftm_responder_params {
> +	u8 *lci;
> +	u8 *civic;

These should be const

> +	[NL80211_ATTR_FTM_RESPONDER] = { .type = NLA_FLAG},

missing a space, but didn't we also say it should be NLA_U8 or so
(allowing the values 0/1) in order to allow later updating this to be
changed on the fly to enable/disable while the AP is already operating,
through the "change beacon" command?

> @@ -4378,7 +4406,7 @@ static int nl80211_set_beacon(struct sk_buff *skb, struct genl_info *info)
>  	if (!wdev->beacon_interval)
>  		return -EINVAL;
>  
> -	err = nl80211_parse_beacon(info->attrs, &params);
> +	err = nl80211_parse_beacon(rdev, info->attrs, &params);

In fact you sort of parse it here, but it would get disabled when the
attribute isn't always included by userspace, which is a bit annoying.

So better make the API to the driver be s8 also, indicating -1 for no
change, and use u8 (0/1) for the userspace API to enable here having "no
changes"?

johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
	ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
	David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH v2 1/3] cfg80211: support FTM responder configuration/statistics
Date: Mon, 03 Sep 2018 11:29:48 +0200	[thread overview]
Message-ID: <1535966988.3437.24.camel@sipsolutions.net> (raw)
In-Reply-To: <1535745418-31336-2-git-send-email-pradeepc@codeaurora.org>


> +struct cfg80211_ftm_responder_params {
> +	u8 *lci;
> +	u8 *civic;

These should be const

> +	[NL80211_ATTR_FTM_RESPONDER] = { .type = NLA_FLAG},

missing a space, but didn't we also say it should be NLA_U8 or so
(allowing the values 0/1) in order to allow later updating this to be
changed on the fly to enable/disable while the AP is already operating,
through the "change beacon" command?

> @@ -4378,7 +4406,7 @@ static int nl80211_set_beacon(struct sk_buff *skb, struct genl_info *info)
>  	if (!wdev->beacon_interval)
>  		return -EINVAL;
>  
> -	err = nl80211_parse_beacon(info->attrs, &params);
> +	err = nl80211_parse_beacon(rdev, info->attrs, &params);

In fact you sort of parse it here, but it would get disabled when the
attribute isn't always included by userspace, which is a bit annoying.

So better make the API to the driver be s8 also, indicating -1 for no
change, and use u8 (0/1) for the userspace API to enable here having "no
changes"?

johannes

  reply	other threads:[~2018-09-03  9:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 19:56 [PATCH v2 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 19:56 ` Pradeep Kumar Chitrapu
2018-08-31 19:56 ` [PATCH v2 1/3] cfg80211: support FTM " Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu
2018-09-03  9:29   ` Johannes Berg [this message]
2018-09-03  9:29     ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 2/3] mac80211: " Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu
2018-09-03  9:33   ` Johannes Berg
2018-09-03  9:33     ` Johannes Berg
2018-09-06  1:06     ` Pradeep Kumar Chitrapu
2018-09-06  1:06       ` Pradeep Kumar Chitrapu
2018-09-06  6:39       ` Johannes Berg
2018-09-06  6:39         ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535966988.3437.24.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath10k@lists.infradead.org \
    --cc=david.spinadel@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.