All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	David Spinadel <david.spinadel@intel.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v2 2/3] mac80211: support FTM responder configuration/statistics
Date: Thu, 06 Sep 2018 08:39:19 +0200	[thread overview]
Message-ID: <1536215959.4015.1.camel@sipsolutions.net> (raw)
In-Reply-To: <f6cb4548de9c5ca228124df1301d2aa0@codeaurora.org>


> > Perhaps the *existence* of ftmr_params could indicate that it's 
> > enabled?
> 
> My understanding is these are only optional parameters. So, I have kept 
> ftm_responder separate from params.

Yes, they're only optional. I was just thinking that even an "empty" set
of parameters could indicate enablement, but I guess we can even avoid
the memory allocation, so perhaps it's better this way. Anyway it's only
an internal API so can change as needed.

johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH v2 2/3] mac80211: support FTM responder configuration/statistics
Date: Thu, 06 Sep 2018 08:39:19 +0200	[thread overview]
Message-ID: <1536215959.4015.1.camel@sipsolutions.net> (raw)
In-Reply-To: <f6cb4548de9c5ca228124df1301d2aa0@codeaurora.org>


> > Perhaps the *existence* of ftmr_params could indicate that it's 
> > enabled?
> 
> My understanding is these are only optional parameters. So, I have kept 
> ftm_responder separate from params.

Yes, they're only optional. I was just thinking that even an "empty" set
of parameters could indicate enablement, but I guess we can even avoid
the memory allocation, so perhaps it's better this way. Anyway it's only
an internal API so can change as needed.

johannes

  reply	other threads:[~2018-09-06  6:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 19:56 [PATCH v2 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 19:56 ` Pradeep Kumar Chitrapu
2018-08-31 19:56 ` [PATCH v2 1/3] cfg80211: support FTM " Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu
2018-09-03  9:29   ` Johannes Berg
2018-09-03  9:29     ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 2/3] mac80211: " Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu
2018-09-03  9:33   ` Johannes Berg
2018-09-03  9:33     ` Johannes Berg
2018-09-06  1:06     ` Pradeep Kumar Chitrapu
2018-09-06  1:06       ` Pradeep Kumar Chitrapu
2018-09-06  6:39       ` Johannes Berg [this message]
2018-09-06  6:39         ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-31 19:56   ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536215959.4015.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath10k@lists.infradead.org \
    --cc=david.spinadel@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.