* [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
@ 2012-09-23 21:45 Phil Blundell
2012-09-23 22:20 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Phil Blundell @ 2012-09-23 21:45 UTC (permalink / raw)
To: oe-core
The modules.tar.gz archive is sometimes of no value and it can take
a noticeable time to build if many modules were enabled in the kernel
configuration. The extraneous file also contributes to deploy/ clutter
and is a waste of disk space.
Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
Signed-off-by: Phil Blundell <pb@pbcl.net>
---
meta/classes/kernel.bbclass | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index fdef1be..2896d28 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -520,9 +520,11 @@ do_uboot_mkimage() {
addtask uboot_mkimage before do_install after do_compile
+KERNEL_DEPLOY_MODULE_TARBALL ?= "1"
+
kernel_do_deploy() {
install -m 0644 ${KERNEL_OUTPUT} ${DEPLOYDIR}/${KERNEL_IMAGE_BASE_NAME}.bin
- if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
+ if [ ${KERNEL_DEPLOY_MODULE_TARBALL} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
tar -cvzf ${DEPLOYDIR}/modules-${KERNEL_VERSION}-${PR}-${MACHINE}.tgz -C ${D} lib
fi
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
2012-09-23 21:45 [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited Phil Blundell
@ 2012-09-23 22:20 ` Paul Eggleton
2012-09-23 23:22 ` Philip Balister
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2012-09-23 22:20 UTC (permalink / raw)
To: openembedded-core; +Cc: Phil Blundell
On Sunday 23 September 2012 22:45:10 Phil Blundell wrote:
> The modules.tar.gz archive is sometimes of no value and it can take
> a noticeable time to build if many modules were enabled in the kernel
> configuration. The extraneous file also contributes to deploy/ clutter
> and is a waste of disk space.
>
> Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
I'm wondering, does anyone still find this file useful?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
2012-09-23 22:20 ` Paul Eggleton
@ 2012-09-23 23:22 ` Philip Balister
2012-09-24 8:36 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Philip Balister @ 2012-09-23 23:22 UTC (permalink / raw)
To: Paul Eggleton; +Cc: Phil Blundell, openembedded-core
On 09/23/2012 06:20 PM, Paul Eggleton wrote:
> On Sunday 23 September 2012 22:45:10 Phil Blundell wrote:
>> The modules.tar.gz archive is sometimes of no value and it can take
>> a noticeable time to build if many modules were enabled in the kernel
>> configuration. The extraneous file also contributes to deploy/ clutter
>> and is a waste of disk space.
>>
>> Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
>
> I'm wondering, does anyone still find this file useful?
I've used it to put modules in rootfs when there is a new kernel version
and I do not have easy access to packages feeds. This speeds testing.
Philip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
2012-09-23 23:22 ` Philip Balister
@ 2012-09-24 8:36 ` Burton, Ross
2012-09-24 9:56 ` Richard Purdie
2012-09-24 12:05 ` Philip Balister
0 siblings, 2 replies; 6+ messages in thread
From: Burton, Ross @ 2012-09-24 8:36 UTC (permalink / raw)
To: Philip Balister; +Cc: Paul Eggleton, Phil Blundell, openembedded-core
On 24 September 2012 00:22, Philip Balister <philip@balister.org> wrote:
>>> Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
>>
>> I'm wondering, does anyone still find this file useful?
>
> I've used it to put modules in rootfs when there is a new kernel version and
> I do not have easy access to packages feeds. This speeds testing.
Sounds like a less than common use-case. How about setting it to 0 by default?
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
2012-09-24 8:36 ` Burton, Ross
@ 2012-09-24 9:56 ` Richard Purdie
2012-09-24 12:05 ` Philip Balister
1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2012-09-24 9:56 UTC (permalink / raw)
To: Burton, Ross; +Cc: Phil Blundell, openembedded-core, Paul Eggleton
On Mon, 2012-09-24 at 09:36 +0100, Burton, Ross wrote:
> On 24 September 2012 00:22, Philip Balister <philip@balister.org> wrote:
> >>> Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
> >>
> >> I'm wondering, does anyone still find this file useful?
> >
> > I've used it to put modules in rootfs when there is a new kernel version and
> > I do not have easy access to packages feeds. This speeds testing.
>
> Sounds like a less than common use-case. How about setting it to 0 by default?
I know I used to use this file a lot when working on Zaurus kernels.
These days I don't get to play with hardware as much as I'd like so I've
not used it in a while.
It is extremely useful when you need it. I've always argued there are
much more problematic time sinks in the build than this tarball
creation...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited
2012-09-24 8:36 ` Burton, Ross
2012-09-24 9:56 ` Richard Purdie
@ 2012-09-24 12:05 ` Philip Balister
1 sibling, 0 replies; 6+ messages in thread
From: Philip Balister @ 2012-09-24 12:05 UTC (permalink / raw)
To: Burton, Ross; +Cc: Paul Eggleton, Phil Blundell, openembedded-core
On 09/24/2012 04:36 AM, Burton, Ross wrote:
> On 24 September 2012 00:22, Philip Balister <philip@balister.org> wrote:
>>>> Allow it to be suppressed by setting KERNEL_DEPLOY_MODULE_TARBALL=0.
>>>
>>> I'm wondering, does anyone still find this file useful?
>>
>> I've used it to put modules in rootfs when there is a new kernel version and
>> I do not have easy access to packages feeds. This speeds testing.
>
> Sounds like a less than common use-case. How about setting it to 0 by default?
Fine with me.Expect me to be annoying on irc when I forget how to turn
it back on :)
Philip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-24 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-23 21:45 [PATCH] kernel.bbclass: Allow modules.tar.gz generation to be inhibited Phil Blundell
2012-09-23 22:20 ` Paul Eggleton
2012-09-23 23:22 ` Philip Balister
2012-09-24 8:36 ` Burton, Ross
2012-09-24 9:56 ` Richard Purdie
2012-09-24 12:05 ` Philip Balister
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.