From: eugeniy.paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] DRM: UDL: get rid of useless vblank initialization
Date: Tue, 23 Oct 2018 11:01:14 +0000 [thread overview]
Message-ID: <1540292472.19916.13.camel@synopsys.com> (raw)
In-Reply-To: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com>
Hi David,
Maybe you have any comments or remarks about this patch?
And if you don't could you please apply it. Thanks!
On Fri, 2018-09-28@17:41 +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: stable at vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
--
Eugeniy Paltsev
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>
To: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@linux.ie" <airlied@linux.ie>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"marcheu@chromium.org" <marcheu@chromium.org>,
Alexey Brodkin <alexey.brodkin@synopsys.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"gustavo@padovan.org" <gustavo@padovan.org>,
"sean@poorly.run" <sean@poorly.run>
Subject: Re: [PATCH] DRM: UDL: get rid of useless vblank initialization
Date: Tue, 23 Oct 2018 11:01:14 +0000 [thread overview]
Message-ID: <1540292472.19916.13.camel@synopsys.com> (raw)
In-Reply-To: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com>
Hi David,
Maybe you have any comments or remarks about this patch?
And if you don't could you please apply it. Thanks!
On Fri, 2018-09-28 at 17:41 +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: stable@vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
--
Eugeniy Paltsev
next prev parent reply other threads:[~2018-10-23 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 14:41 [PATCH] DRM: UDL: get rid of useless vblank initialization Eugeniy Paltsev
2018-09-28 14:41 ` Eugeniy Paltsev
2018-10-01 8:14 ` Daniel Vetter
2018-10-01 8:14 ` Daniel Vetter
2018-10-23 11:01 ` Eugeniy Paltsev [this message]
2018-10-23 11:01 ` Eugeniy Paltsev
2018-10-23 13:42 ` Daniel Vetter
2018-10-23 13:42 ` Daniel Vetter
2018-10-23 13:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540292472.19916.13.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.