All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: [PATCH] kexec-tools: don't include every archs Makefile
Date: Wed, 05 May 2010 11:51:10 +1000	[thread overview]
Message-ID: <15472.1273024270@neuling.org> (raw)
In-Reply-To: 15110.1273024133@neuling.org

This patches changes the kexec/Makefile to only include the required
arch Makefile.  

Including all arch Makefiles causes unexpected results as changing one
archs Makefile effects all other archs.

ppc64 recently broke surprisingly because
6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
improvements" added "CFLAGS +=-Wall -Werror" to
kexec/arch/mips/Makefile.  This shouldn't happen.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
Horms: Tested by compiling on x86 and ppc64, but probably needs
testing on other archs before being committed.

 kexec/Makefile |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Index: kexec-tools/kexec/Makefile
===================================================================
--- kexec-tools.orig/kexec/Makefile
+++ kexec-tools/kexec/Makefile
@@ -48,17 +48,7 @@ KEXEC_SRCS += $($(ARCH)_ARCH_REUSE_INITR
 $(ARCH)_ARCH_INIT		= kexec/arch_init.c
 KEXEC_SRCS += $($(ARCH)_ARCH_INIT)
 
-include $(srcdir)/kexec/arch/alpha/Makefile
-include $(srcdir)/kexec/arch/arm/Makefile
-include $(srcdir)/kexec/arch/i386/Makefile
-include $(srcdir)/kexec/arch/ia64/Makefile
-include $(srcdir)/kexec/arch/mips/Makefile
-include $(srcdir)/kexec/arch/cris/Makefile
-include $(srcdir)/kexec/arch/ppc/Makefile
-include $(srcdir)/kexec/arch/ppc64/Makefile
-include $(srcdir)/kexec/arch/s390/Makefile
-include $(srcdir)/kexec/arch/sh/Makefile
-include $(srcdir)/kexec/arch/x86_64/Makefile
+include $(srcdir)/kexec/arch/$(ARCH)/Makefile
 
 KEXEC_SRCS += $($(ARCH)_KEXEC_SRCS)
 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2010-05-05  1:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  1:48 [PATCH] kexec-tools, ppc64: fix build error on ppc64 Michael Neuling
2010-05-05  1:48 ` Michael Neuling
2010-05-05  1:51 ` Michael Neuling [this message]
2010-05-05  3:31   ` [PATCH] kexec-tools: don't include every archs Makefile Simon Horman
2010-05-05  4:00     ` Michael Neuling
2010-05-05  6:44       ` Simon Horman
2010-05-05  1:56 ` [PATCH] kexec-tools, ppc64: fix build error on ppc64 Dale Farnsworth
2010-05-05  2:33 ` Simon Horman
2010-05-05  2:33   ` Simon Horman
2010-05-05  3:35   ` Michael Neuling
2010-05-05  3:35     ` Michael Neuling
2010-05-05  3:39     ` Simon Horman
2010-05-05  3:39       ` Simon Horman
2010-05-05  7:46       ` Maxim Uvarov
2010-05-05  7:46         ` Maxim Uvarov
2010-05-05  8:29         ` Simon Horman
2010-05-05  8:29           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15472.1273024270@neuling.org \
    --to=mikey@neuling.org \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.