From: Michael Neuling <mikey@neuling.org>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec-tools: don't include every archs Makefile
Date: Wed, 05 May 2010 14:00:58 +1000 [thread overview]
Message-ID: <16571.1273032058@neuling.org> (raw)
In-Reply-To: <20100505033123.GB2612@verge.net.au>
In message <20100505033123.GB2612@verge.net.au> you wrote:
> On Wed, May 05, 2010 at 11:51:10AM +1000, Michael Neuling wrote:
> > This patches changes the kexec/Makefile to only include the required
> > arch Makefile.
> >
> > Including all arch Makefiles causes unexpected results as changing one
> > archs Makefile effects all other archs.
> >
> > ppc64 recently broke surprisingly because
> > 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
> > improvements" added "CFLAGS +=-Wall -Werror" to
> > kexec/arch/mips/Makefile. This shouldn't happen.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > ---
> > Horms: Tested by compiling on x86 and ppc64, but probably needs
> > testing on other archs before being committed.
>
> Unfortunately this breaks make tarball - only kexec/arch/$ARCH is
> included in the tarball.
I figured it might break something :-)
BTW make tarball works here.
> Perhaps we could introduce $(ARCH)_FLAGS, which I think is
> consistent with the handling of other variables by the kexec build.
Seems like a bit of a band aid.
It still seems pretty broken that we use arch/mips/Makefile for ppc64.
Looking at 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 and trying to work
out how it broke ppc64 was pretty annoying.
Mikey
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-05-05 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 1:48 [PATCH] kexec-tools, ppc64: fix build error on ppc64 Michael Neuling
2010-05-05 1:48 ` Michael Neuling
2010-05-05 1:51 ` [PATCH] kexec-tools: don't include every archs Makefile Michael Neuling
2010-05-05 3:31 ` Simon Horman
2010-05-05 4:00 ` Michael Neuling [this message]
2010-05-05 6:44 ` Simon Horman
2010-05-05 1:56 ` [PATCH] kexec-tools, ppc64: fix build error on ppc64 Dale Farnsworth
2010-05-05 2:33 ` Simon Horman
2010-05-05 2:33 ` Simon Horman
2010-05-05 3:35 ` Michael Neuling
2010-05-05 3:35 ` Michael Neuling
2010-05-05 3:39 ` Simon Horman
2010-05-05 3:39 ` Simon Horman
2010-05-05 7:46 ` Maxim Uvarov
2010-05-05 7:46 ` Maxim Uvarov
2010-05-05 8:29 ` Simon Horman
2010-05-05 8:29 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16571.1273032058@neuling.org \
--to=mikey@neuling.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.