All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Cc: Maxim Uvarov <muvarov@gmail.com>, linuxppc-dev@ozlabs.org
Subject: [PATCH] kexec-tools, ppc64: fix build error on ppc64
Date: Wed, 05 May 2010 11:48:53 +1000	[thread overview]
Message-ID: <15110.1273024133@neuling.org> (raw)

6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
improvements" broke pp64 as it turned on -Werror for all archs.

This fixes the warning and hence ppc64 building.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
I've posted a second patch to fix the issue of changing one archs
Makefile, effecting all other archs.

 kexec/arch/ppc64/fs2dt.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: kexec-tools/kexec/arch/ppc64/fs2dt.c
===================================================================
--- kexec-tools.orig/kexec/arch/ppc64/fs2dt.c
+++ kexec-tools/kexec/arch/ppc64/fs2dt.c
@@ -357,7 +357,8 @@ static void putprops(char *fn, struct di
  * Compare function used to sort the device-tree directories
  * This function will be passed to scandir.
  */
-static int comparefunc(const void *dentry1, const void *dentry2)
+static int comparefunc(const struct dirent **dentry1,
+		       const struct dirent **dentry2)
 {
 	char *str1 = (*(struct dirent **)dentry1)->d_name;
 	char *str2 = (*(struct dirent **)dentry2)->d_name;

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Cc: Maxim Uvarov <muvarov@gmail.com>, linuxppc-dev@ozlabs.org
Subject: [PATCH] kexec-tools, ppc64: fix build error on ppc64
Date: Wed, 05 May 2010 11:48:53 +1000	[thread overview]
Message-ID: <15110.1273024133@neuling.org> (raw)

6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
improvements" broke pp64 as it turned on -Werror for all archs.

This fixes the warning and hence ppc64 building.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
I've posted a second patch to fix the issue of changing one archs
Makefile, effecting all other archs.

 kexec/arch/ppc64/fs2dt.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: kexec-tools/kexec/arch/ppc64/fs2dt.c
===================================================================
--- kexec-tools.orig/kexec/arch/ppc64/fs2dt.c
+++ kexec-tools/kexec/arch/ppc64/fs2dt.c
@@ -357,7 +357,8 @@ static void putprops(char *fn, struct di
  * Compare function used to sort the device-tree directories
  * This function will be passed to scandir.
  */
-static int comparefunc(const void *dentry1, const void *dentry2)
+static int comparefunc(const struct dirent **dentry1,
+		       const struct dirent **dentry2)
 {
 	char *str1 = (*(struct dirent **)dentry1)->d_name;
 	char *str2 = (*(struct dirent **)dentry2)->d_name;

             reply	other threads:[~2010-05-05  1:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  1:48 Michael Neuling [this message]
2010-05-05  1:48 ` [PATCH] kexec-tools, ppc64: fix build error on ppc64 Michael Neuling
2010-05-05  1:51 ` [PATCH] kexec-tools: don't include every archs Makefile Michael Neuling
2010-05-05  3:31   ` Simon Horman
2010-05-05  4:00     ` Michael Neuling
2010-05-05  6:44       ` Simon Horman
2010-05-05  1:56 ` [PATCH] kexec-tools, ppc64: fix build error on ppc64 Dale Farnsworth
2010-05-05  2:33 ` Simon Horman
2010-05-05  2:33   ` Simon Horman
2010-05-05  3:35   ` Michael Neuling
2010-05-05  3:35     ` Michael Neuling
2010-05-05  3:39     ` Simon Horman
2010-05-05  3:39       ` Simon Horman
2010-05-05  7:46       ` Maxim Uvarov
2010-05-05  7:46         ` Maxim Uvarov
2010-05-05  8:29         ` Simon Horman
2010-05-05  8:29           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15110.1273024133@neuling.org \
    --to=mikey@neuling.org \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=muvarov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.