From: Masami Hiramatsu <mhiramat@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: Pratyush Anand <panand@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Morse <james.morse@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"David A . Long" <dave.long@linaro.org>
Subject: [PATCH v2 0/4] arm64: kprobes: Update blacklist checking on arm64
Date: Tue, 15 Jan 2019 15:23:39 +0900 [thread overview]
Message-ID: <154753341900.31541.8135985235882849464.stgit@devbox> (raw)
Hello,
Here is the v2 series of update of the kprobe blacklist
checking on arm64.
I found that some blacklist checking code were mis-placed in
arch_prepare_kprobe() and arch_within_kprobe_blacklist().
Since the blacklist just filters by symbol, smaller than the
symbol, like extable must be checked in arch_prepare_kprobe().
Also, all function (symbol) level check must be done by blacklist.
For arm64, it checks the extable entry address in blacklist
and exception/irqentry function in arch_prepare_kprobe().
And, RODATA check is unneeded since kernel/kprobes.c
already ensures the probe address is in kernel-text area.
In v2, I updated [1/4]'s description and added James'
Reviewed-by. Also, in this version, I added a patch which
uses arch_populate_kprobe_blacklist() instead of
arch_within_kprobe_blacklist() so that user can see the full
list of blacklisted symbols under the debugfs.
Changes in v2:
- [1/4] change description so that it make clear and add
James' Reviewed-by.
- [4/4] new patch.
Thank you,
---
Masami Hiramatsu (4):
arm64: kprobes: Move extable address check into arch_prepare_kprobe()
arm64: kprobes: Remove unneeded RODATA check
arm64: kprobes: Move exception_text check in blacklist
arm64: kprobes: Use arch_populate_kprobe_blacklist()
arch/arm64/kernel/probes/kprobes.c | 49 ++++++++++++++++++------------------
1 file changed, 24 insertions(+), 25 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Pratyush Anand <panand@redhat.com>,
"David A . Long" <dave.long@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>,
James Morse <james.morse@arm.com>
Subject: [PATCH v2 0/4] arm64: kprobes: Update blacklist checking on arm64
Date: Tue, 15 Jan 2019 15:23:39 +0900 [thread overview]
Message-ID: <154753341900.31541.8135985235882849464.stgit@devbox> (raw)
Hello,
Here is the v2 series of update of the kprobe blacklist
checking on arm64.
I found that some blacklist checking code were mis-placed in
arch_prepare_kprobe() and arch_within_kprobe_blacklist().
Since the blacklist just filters by symbol, smaller than the
symbol, like extable must be checked in arch_prepare_kprobe().
Also, all function (symbol) level check must be done by blacklist.
For arm64, it checks the extable entry address in blacklist
and exception/irqentry function in arch_prepare_kprobe().
And, RODATA check is unneeded since kernel/kprobes.c
already ensures the probe address is in kernel-text area.
In v2, I updated [1/4]'s description and added James'
Reviewed-by. Also, in this version, I added a patch which
uses arch_populate_kprobe_blacklist() instead of
arch_within_kprobe_blacklist() so that user can see the full
list of blacklisted symbols under the debugfs.
Changes in v2:
- [1/4] change description so that it make clear and add
James' Reviewed-by.
- [4/4] new patch.
Thank you,
---
Masami Hiramatsu (4):
arm64: kprobes: Move extable address check into arch_prepare_kprobe()
arm64: kprobes: Remove unneeded RODATA check
arm64: kprobes: Move exception_text check in blacklist
arm64: kprobes: Use arch_populate_kprobe_blacklist()
arch/arm64/kernel/probes/kprobes.c | 49 ++++++++++++++++++------------------
1 file changed, 24 insertions(+), 25 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2019-01-15 6:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 6:23 Masami Hiramatsu [this message]
2019-01-15 6:23 ` [PATCH v2 0/4] arm64: kprobes: Update blacklist checking on arm64 Masami Hiramatsu
2019-01-15 6:24 ` [PATCH v2 1/4] arm64: kprobes: Move extable address check into arch_prepare_kprobe() Masami Hiramatsu
2019-01-15 6:24 ` Masami Hiramatsu
2019-01-15 6:24 ` [PATCH v2 2/4] arm64: kprobes: Remove unneeded RODATA check Masami Hiramatsu
2019-01-15 6:24 ` Masami Hiramatsu
2019-01-15 11:20 ` Mark Rutland
2019-01-15 11:20 ` Mark Rutland
2019-01-15 6:25 ` [PATCH v2 3/4] arm64: kprobes: Move exception_text check in blacklist Masami Hiramatsu
2019-01-15 6:25 ` Masami Hiramatsu
2019-01-21 12:08 ` James Morse
2019-01-21 12:08 ` James Morse
2019-01-15 6:25 ` [PATCH v2 4/4] arm64: kprobes: Use arch_populate_kprobe_blacklist() Masami Hiramatsu
2019-01-15 6:25 ` Masami Hiramatsu
2019-01-21 12:20 ` James Morse
2019-01-21 12:20 ` James Morse
2019-01-21 13:25 ` Masami Hiramatsu
2019-01-21 13:25 ` Masami Hiramatsu
2019-02-08 9:15 ` Will Deacon
2019-02-08 9:15 ` Will Deacon
2019-02-11 13:10 ` Masami Hiramatsu
2019-02-11 13:10 ` Masami Hiramatsu
2019-02-11 15:58 ` Will Deacon
2019-02-11 15:58 ` Will Deacon
2019-02-11 16:05 ` Marc Zyngier
2019-02-11 16:05 ` Marc Zyngier
2019-02-12 15:28 ` Masami Hiramatsu
2019-02-12 15:28 ` Masami Hiramatsu
2019-01-16 13:40 ` [PATCH v2 0/4] arm64: kprobes: Update blacklist checking on arm64 Will Deacon
2019-01-16 13:40 ` Will Deacon
2019-01-19 13:31 ` Masami Hiramatsu
2019-01-19 13:31 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154753341900.31541.8135985235882849464.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.long@linaro.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=panand@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.