From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Yu Chen <chenyu56@huawei.com>, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, Yao Chen <chenyao11@huawei.com>,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei <songxiaowei@hisilicon.com>,
xu yiping <xuyiping@hisilicon.com>,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: [v3,10/12] hikey960: Support usb functionality of Hikey960
Date: Mon, 4 Mar 2019 14:58:04 +0800 [thread overview]
Message-ID: <1551682684.2210.67.camel@mhfsdcap03> (raw)
hi,
On Mon, 2019-03-04 at 08:50 +0200, Andy Shevchenko wrote:
> On Mon, Mar 4, 2019 at 3:47 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote:
>
> > > + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
> > > + if (!hisi_hikey_usb->role_sw)
> > > + return -EPROBE_DEFER;
> > Here return EPROBE_DEFFER means the related device_connection is
> > registered after this probe is called, right?
> > if not, use IS_ERR_OR_NULL then return PTR_ERR is enough
>
> How enough? If return value is NULL it would be transformered to 0,
> which is success return code from the ->probe() which means we will
> have ->probed() and not functional device.
>
You are right:)
> Am I missing something?
>
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Yu Chen <chenyu56@huawei.com>, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, Yao Chen <chenyao11@huawei.com>,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei <songxiaowei@hisilicon.com>,
xu yiping <xuyiping@hisilicon.com>,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960
Date: Mon, 4 Mar 2019 14:58:04 +0800 [thread overview]
Message-ID: <1551682684.2210.67.camel@mhfsdcap03> (raw)
In-Reply-To: <CAHp75Vdkp40e5-Bv+LnLBxgPkTDJ0FA1ooq+C4-do=4k5prTiQ@mail.gmail.com>
hi,
On Mon, 2019-03-04 at 08:50 +0200, Andy Shevchenko wrote:
> On Mon, Mar 4, 2019 at 3:47 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote:
>
> > > + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
> > > + if (!hisi_hikey_usb->role_sw)
> > > + return -EPROBE_DEFER;
> > Here return EPROBE_DEFFER means the related device_connection is
> > registered after this probe is called, right?
> > if not, use IS_ERR_OR_NULL then return PTR_ERR is enough
>
> How enough? If return value is NULL it would be transformered to 0,
> which is success return code from the ->probe() which means we will
> have ->probed() and not functional device.
>
You are right:)
> Am I missing something?
>
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Yu Chen <chenyu56@huawei.com>, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, <liuyu712@hisilicon.com>,
<wanghu17@hisilicon.com>, <butao@hisilicon.com>,
"Yao Chen" <chenyao11@huawei.com>, <fangshengzhou@hisilicon.com>,
<lipengcheng8@huawei.com>,
songxiaowei <songxiaowei@hisilicon.com>,
xu yiping <xuyiping@hisilicon.com>, <xuyoujun4@huawei.com>,
<yudongbin@hisilicon.com>, <zangleigang@hisilicon.com>,
Arnd Bergmann <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960
Date: Mon, 4 Mar 2019 14:58:04 +0800 [thread overview]
Message-ID: <1551682684.2210.67.camel@mhfsdcap03> (raw)
In-Reply-To: <CAHp75Vdkp40e5-Bv+LnLBxgPkTDJ0FA1ooq+C4-do=4k5prTiQ@mail.gmail.com>
hi,
On Mon, 2019-03-04 at 08:50 +0200, Andy Shevchenko wrote:
> On Mon, Mar 4, 2019 at 3:47 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > On Sat, 2019-03-02 at 17:05 +0800, Yu Chen wrote:
>
> > > + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
> > > + if (!hisi_hikey_usb->role_sw)
> > > + return -EPROBE_DEFER;
> > Here return EPROBE_DEFFER means the related device_connection is
> > registered after this probe is called, right?
> > if not, use IS_ERR_OR_NULL then return PTR_ERR is enough
>
> How enough? If return value is NULL it would be transformered to 0,
> which is success return code from the ->probe() which means we will
> have ->probed() and not functional device.
>
You are right:)
> Am I missing something?
>
next reply other threads:[~2019-03-04 6:58 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 6:58 Chunfeng Yun [this message]
2019-03-04 6:58 ` [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960 Chunfeng Yun
2019-03-04 6:58 ` Chunfeng Yun
-- strict thread matches above, loose matches on Subject: below --
2019-03-13 19:38 [v3,01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Rob Herring
2019-03-13 19:38 ` [PATCH v3 01/12] " Rob Herring
2019-03-13 1:40 [v3,01/12] " Yu Chen
2019-03-13 1:40 ` [PATCH v3 01/12] " Chen Yu
2019-03-13 1:40 ` Chen Yu
2019-03-12 13:45 [v3,01/12] " Rob Herring
2019-03-12 13:45 ` [PATCH v3 01/12] " Rob Herring
2019-03-05 13:22 [v3,09/12] usb: dwc3: Registering a role switch in the DRD code kbuild test robot
2019-03-05 13:22 ` [PATCH v3 09/12] " kbuild test robot
2019-03-05 13:22 ` kbuild test robot
2019-03-05 3:11 [v3,04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc kbuild test robot
2019-03-05 3:11 ` [PATCH v3 04/12] " kbuild test robot
2019-03-05 3:11 ` kbuild test robot
2019-03-04 23:53 [v3,04/12] " kbuild test robot
2019-03-04 23:53 ` [PATCH v3 04/12] " kbuild test robot
2019-03-04 23:53 ` kbuild test robot
2019-03-04 7:31 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-04 7:31 ` [PATCH v3 10/12] " Chen Yu
2019-03-04 7:31 ` Chen Yu
2019-03-04 6:55 [v3,10/12] " Andy Shevchenko
2019-03-04 6:55 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-04 6:50 [v3,10/12] " Andy Shevchenko
2019-03-04 6:50 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-04 2:53 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-03-04 2:53 ` //Re: [PATCH v3 06/12] " Chen Yu
2019-03-04 2:53 ` Chen Yu
2019-03-04 2:37 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-03-04 2:37 ` [PATCH v3 07/12] " Chen Yu
2019-03-04 2:37 ` Chen Yu
2019-03-04 2:35 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-04 2:35 ` [PATCH v3 10/12] " Chen Yu
2019-03-04 2:35 ` Chen Yu
2019-03-04 1:55 [v3,10/12] " Yu Chen
2019-03-04 1:55 ` [PATCH v3 10/12] " Chen Yu
2019-03-04 1:55 ` Chen Yu
2019-03-04 1:47 [v3,10/12] " Chunfeng Yun
2019-03-04 1:47 ` [PATCH v3 10/12] " Chunfeng Yun
2019-03-04 1:47 ` Chunfeng Yun
2019-03-04 1:27 [v3,10/12] " Yu Chen
2019-03-04 1:27 ` [PATCH v3 10/12] " Chen Yu
2019-03-04 1:27 ` Chen Yu
2019-03-03 20:17 [v3,10/12] " John Stultz
2019-03-03 20:17 ` [PATCH v3 10/12] " John Stultz
2019-03-03 20:17 ` John Stultz
2019-03-02 16:01 [v3,10/12] " Andy Shevchenko
2019-03-02 16:01 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-02 15:56 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Andy Shevchenko
2019-03-02 15:56 ` [PATCH v3 07/12] " Andy Shevchenko
2019-03-02 15:56 ` Andy Shevchenko
2019-03-02 15:47 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Andy Shevchenko
2019-03-02 15:47 ` [PATCH v3 06/12] " Andy Shevchenko
2019-03-02 9:05 [v3,12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-03-02 9:05 ` [PATCH v3 12/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 [v3,11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-03-02 9:05 ` [PATCH v3 11/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-02 9:05 ` [PATCH v3 10/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 [v3,09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-03-02 9:05 ` [PATCH v3 09/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 [v3,08/12] usb: roles: Add usb role switch notifier Yu Chen
2019-03-02 9:05 ` [PATCH v3 08/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:05 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-03-02 9:05 ` [PATCH v3 07/12] " Yu Chen
2019-03-02 9:05 ` Yu Chen
2019-03-02 9:04 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-03-02 9:04 ` [PATCH v3 06/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [v3,05/12] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for Hisilicon Kirin Soc Yu Chen
2019-03-02 9:04 ` [PATCH v3 05/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [v3,04/12] usb: dwc3: Add splitdisable quirk " Yu Chen
2019-03-02 9:04 ` [PATCH v3 04/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [v3,03/12] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-03-02 9:04 ` [PATCH v3 03/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [v3,02/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-03-02 9:04 ` [PATCH v3 02/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [v3,01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-03-02 9:04 ` [PATCH v3 01/12] " Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-02 9:04 [PATCH v3 00/12] Add support for usb on Hikey960 Yu Chen
2019-03-02 9:04 ` Yu Chen
2019-03-04 12:15 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551682684.2210.67.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=butao@hisilicon.com \
--cc=chenyao11@huawei.com \
--cc=chenyu56@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=fangshengzhou@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liuyu712@hisilicon.com \
--cc=songxiaowei@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
--cc=wanghu17@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyoujun4@huawei.com \
--cc=yudongbin@hisilicon.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.