All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, john.stultz@linaro.org,
	suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
	liuyu712@hisilicon.com, wanghu17@hisilicon.com,
	butao@hisilicon.com, chenyao11@huawei.com,
	fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
	songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
	xuyoujun4@huawei.com, yudongbin@hisilicon.com,
	zangleigang@hisilicon.com, Mark Rutland <mark.rutland@arm.com>,
	Binghui Wang <wangbinghui@hisilicon.com>
Subject: [v3,01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY
Date: Tue, 12 Mar 2019 08:45:25 -0500	[thread overview]
Message-ID: <20190312134525.GA9706@bogus> (raw)

On Sat, Mar 02, 2019 at 05:04:54PM +0800, Yu Chen wrote:
> This patch adds binding documentation for supporting the hi3660 usb
> phy on boards like the HiKey960.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Binghui Wang <wangbinghui@hisilicon.com>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> v1:
> * Fix some format error as suggested by Rob.
> v2:
> * Change hi3660 usb PHY to hi3660 USB PHY
> v3:
> * Make device node a subnode of usb3_otg_bc register.
> ---
> ---
>  .../devicetree/bindings/phy/phy-hi3660-usb3.txt    | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> new file mode 100644
> index 000000000000..6096214a2bc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> @@ -0,0 +1,28 @@
> +Hisilicon hi3660 USB PHY
> +-----------------------
> +
> +Required properties:
> +- compatible: should be "hisilicon,hi3660-usb-phy"
> +- #phy-cells: must be 0
> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy.

You can drop this as it is now just the parent node.

> +- hisilicon,eye-diagram-param: parameter set for phy
> +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> +
> +This is a subnode of usb3_otg_bc register node.
> +
> +Example:
> +	usb3_otg_bc: usb3_otg_bc@ff200000 {
> +		compatible = "syscon", "simple-mfd";

This node should have a specific compatible.

> +		reg = <0x0 0xff200000 0x0 0x1000>;
> +
> +		usb-phy {
> +			compatible = "hisilicon,hi3660-usb-phy";
> +			#phy-cells = <0>;
> +			hisilicon,pericrg-syscon = <&crg_ctrl>;
> +			hisilicon,pctrl-syscon = <&pctrl>;
> +			hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
> +			hisilicon,eye-diagram-param = <0x22466e4>;
> +		};
> +	};
> -- 
> 2.15.0-rc2
>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, john.stultz@linaro.org,
	suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
	liuyu712@hisilicon.com, wanghu17@hisilicon.com,
	butao@hisilicon.com, chenyao11@huawei.com,
	fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
	songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
	xuyoujun4@huawei.com, yudongbin@hisilicon.com,
	zangleigang@hisilicon.com, Mark Rutland <mark.rutland@arm.com>,
	Binghui Wang <wangbinghui@hisilicon.com>
Subject: Re: [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY
Date: Tue, 12 Mar 2019 08:45:25 -0500	[thread overview]
Message-ID: <20190312134525.GA9706@bogus> (raw)
In-Reply-To: <20190302090505.65542-2-chenyu56@huawei.com>

On Sat, Mar 02, 2019 at 05:04:54PM +0800, Yu Chen wrote:
> This patch adds binding documentation for supporting the hi3660 usb
> phy on boards like the HiKey960.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Binghui Wang <wangbinghui@hisilicon.com>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> v1:
> * Fix some format error as suggested by Rob.
> v2:
> * Change hi3660 usb PHY to hi3660 USB PHY
> v3:
> * Make device node a subnode of usb3_otg_bc register.
> ---
> ---
>  .../devicetree/bindings/phy/phy-hi3660-usb3.txt    | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> new file mode 100644
> index 000000000000..6096214a2bc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> @@ -0,0 +1,28 @@
> +Hisilicon hi3660 USB PHY
> +-----------------------
> +
> +Required properties:
> +- compatible: should be "hisilicon,hi3660-usb-phy"
> +- #phy-cells: must be 0
> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy.

You can drop this as it is now just the parent node.

> +- hisilicon,eye-diagram-param: parameter set for phy
> +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> +
> +This is a subnode of usb3_otg_bc register node.
> +
> +Example:
> +	usb3_otg_bc: usb3_otg_bc@ff200000 {
> +		compatible = "syscon", "simple-mfd";

This node should have a specific compatible.

> +		reg = <0x0 0xff200000 0x0 0x1000>;
> +
> +		usb-phy {
> +			compatible = "hisilicon,hi3660-usb-phy";
> +			#phy-cells = <0>;
> +			hisilicon,pericrg-syscon = <&crg_ctrl>;
> +			hisilicon,pctrl-syscon = <&pctrl>;
> +			hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
> +			hisilicon,eye-diagram-param = <0x22466e4>;
> +		};
> +	};
> -- 
> 2.15.0-rc2
> 

             reply	other threads:[~2019-03-12 13:45 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 13:45 Rob Herring [this message]
2019-03-12 13:45 ` [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2019-03-13 19:38 [v3,01/12] " Rob Herring
2019-03-13 19:38 ` [PATCH v3 01/12] " Rob Herring
2019-03-13  1:40 [v3,01/12] " Yu Chen
2019-03-13  1:40 ` [PATCH v3 01/12] " Chen Yu
2019-03-13  1:40 ` Chen Yu
2019-03-05 13:22 [v3,09/12] usb: dwc3: Registering a role switch in the DRD code kbuild test robot
2019-03-05 13:22 ` [PATCH v3 09/12] " kbuild test robot
2019-03-05 13:22 ` kbuild test robot
2019-03-05  3:11 [v3,04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc kbuild test robot
2019-03-05  3:11 ` [PATCH v3 04/12] " kbuild test robot
2019-03-05  3:11 ` kbuild test robot
2019-03-04 23:53 [v3,04/12] " kbuild test robot
2019-03-04 23:53 ` [PATCH v3 04/12] " kbuild test robot
2019-03-04 23:53 ` kbuild test robot
2019-03-04  7:31 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-04  7:31 ` [PATCH v3 10/12] " Chen Yu
2019-03-04  7:31 ` Chen Yu
2019-03-04  6:58 [v3,10/12] " Chunfeng Yun
2019-03-04  6:58 ` [PATCH v3 10/12] " Chunfeng Yun
2019-03-04  6:58 ` Chunfeng Yun
2019-03-04  6:55 [v3,10/12] " Andy Shevchenko
2019-03-04  6:55 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-04  6:50 [v3,10/12] " Andy Shevchenko
2019-03-04  6:50 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-04  2:53 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-03-04  2:53 ` //Re: [PATCH v3 06/12] " Chen Yu
2019-03-04  2:53 ` Chen Yu
2019-03-04  2:37 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-03-04  2:37 ` [PATCH v3 07/12] " Chen Yu
2019-03-04  2:37 ` Chen Yu
2019-03-04  2:35 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-04  2:35 ` [PATCH v3 10/12] " Chen Yu
2019-03-04  2:35 ` Chen Yu
2019-03-04  1:55 [v3,10/12] " Yu Chen
2019-03-04  1:55 ` [PATCH v3 10/12] " Chen Yu
2019-03-04  1:55 ` Chen Yu
2019-03-04  1:47 [v3,10/12] " Chunfeng Yun
2019-03-04  1:47 ` [PATCH v3 10/12] " Chunfeng Yun
2019-03-04  1:47 ` Chunfeng Yun
2019-03-04  1:27 [v3,10/12] " Yu Chen
2019-03-04  1:27 ` [PATCH v3 10/12] " Chen Yu
2019-03-04  1:27 ` Chen Yu
2019-03-03 20:17 [v3,10/12] " John Stultz
2019-03-03 20:17 ` [PATCH v3 10/12] " John Stultz
2019-03-03 20:17 ` John Stultz
2019-03-02 16:01 [v3,10/12] " Andy Shevchenko
2019-03-02 16:01 ` [PATCH v3 10/12] " Andy Shevchenko
2019-03-02 15:56 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Andy Shevchenko
2019-03-02 15:56 ` [PATCH v3 07/12] " Andy Shevchenko
2019-03-02 15:56 ` Andy Shevchenko
2019-03-02 15:47 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Andy Shevchenko
2019-03-02 15:47 ` [PATCH v3 06/12] " Andy Shevchenko
2019-03-02  9:05 [v3,12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-03-02  9:05 ` [PATCH v3 12/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 [v3,11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-03-02  9:05 ` [PATCH v3 11/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 [v3,10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-02  9:05 ` [PATCH v3 10/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 [v3,09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-03-02  9:05 ` [PATCH v3 09/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 [v3,08/12] usb: roles: Add usb role switch notifier Yu Chen
2019-03-02  9:05 ` [PATCH v3 08/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:05 [v3,07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-03-02  9:05 ` [PATCH v3 07/12] " Yu Chen
2019-03-02  9:05 ` Yu Chen
2019-03-02  9:04 [v3,06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-03-02  9:04 ` [PATCH v3 06/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [v3,05/12] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for Hisilicon Kirin Soc Yu Chen
2019-03-02  9:04 ` [PATCH v3 05/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [v3,04/12] usb: dwc3: Add splitdisable quirk " Yu Chen
2019-03-02  9:04 ` [PATCH v3 04/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [v3,03/12] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-03-02  9:04 ` [PATCH v3 03/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [v3,02/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-03-02  9:04 ` [PATCH v3 02/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [v3,01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-03-02  9:04 ` [PATCH v3 01/12] " Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-02  9:04 [PATCH v3 00/12] Add support for usb on Hikey960 Yu Chen
2019-03-02  9:04 ` Yu Chen
2019-03-04 12:15 ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312134525.GA9706@bogus \
    --to=robh@kernel.org \
    --cc=butao@hisilicon.com \
    --cc=chenyao11@huawei.com \
    --cc=chenyu56@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fangshengzhou@hisilicon.com \
    --cc=john.stultz@linaro.org \
    --cc=kongfei@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lipengcheng8@huawei.com \
    --cc=liuyu712@hisilicon.com \
    --cc=mark.rutland@arm.com \
    --cc=songxiaowei@hisilicon.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=wangbinghui@hisilicon.com \
    --cc=wanghu17@hisilicon.com \
    --cc=xuyiping@hisilicon.com \
    --cc=xuyoujun4@huawei.com \
    --cc=yudongbin@hisilicon.com \
    --cc=zangleigang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.