From: "Heiko Stübner" <heiko@sntech.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Kevin Hilman <khilman@linaro.org>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
linux-rockchip@lists.infradead.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property
Date: Tue, 13 Oct 2015 19:52:11 +0200 [thread overview]
Message-ID: <1561585.uublXABoq2@diego> (raw)
In-Reply-To: <1444747133-22671-1-git-send-email-sudeep.holla@arm.com>
Am Dienstag, 13. Oktober 2015, 15:38:53 schrieb Sudeep Holla:
> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
> source.
>
> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
> value "0" is assigned probably assuming it won't be enabled as a wakeup
> source. Since the presence of the boolean property indicates it is
> enabled, value of "0" have no value.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property which inturn fixes the above mentioned issue.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/rk3066a-bqcurie2.dts | 3 +--
> arch/arm/boot/dts/rk3066a-rayeager.dts | 2 +-
> arch/arm/boot/dts/rk3188-radxarock.dts | 2 +-
> arch/arm/boot/dts/rk3288-evb.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-firefly.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-popmetal.dts | 2 +-
> arch/arm/boot/dts/rk3288-r89.dts | 2 +-
[...]
> arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +-
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup with wakeup-source property
Date: Tue, 13 Oct 2015 19:52:11 +0200 [thread overview]
Message-ID: <1561585.uublXABoq2@diego> (raw)
In-Reply-To: <1444747133-22671-1-git-send-email-sudeep.holla@arm.com>
Am Dienstag, 13. Oktober 2015, 15:38:53 schrieb Sudeep Holla:
> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
> source.
>
> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
> value "0" is assigned probably assuming it won't be enabled as a wakeup
> source. Since the presence of the boolean property indicates it is
> enabled, value of "0" have no value.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property which inturn fixes the above mentioned issue.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip at lists.infradead.org
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/rk3066a-bqcurie2.dts | 3 +--
> arch/arm/boot/dts/rk3066a-rayeager.dts | 2 +-
> arch/arm/boot/dts/rk3188-radxarock.dts | 2 +-
> arch/arm/boot/dts/rk3288-evb.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-firefly.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-popmetal.dts | 2 +-
> arch/arm/boot/dts/rk3288-r89.dts | 2 +-
[...]
> arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +-
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2015-10-13 17:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 13:32 [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla
2015-10-13 13:32 ` Sudeep Holla
2015-10-13 13:32 ` [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla
2015-10-13 13:32 ` Sudeep Holla
2015-10-13 14:07 ` Rob Herring
2015-10-13 14:07 ` Rob Herring
2015-10-13 14:26 ` Sudeep Holla
2015-10-13 14:26 ` Sudeep Holla
2015-10-13 14:38 ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Sudeep Holla
2015-10-13 14:38 ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup " Sudeep Holla
[not found] ` <1444747133-22671-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2015-10-13 15:08 ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup " Viresh Kumar
2015-10-13 15:08 ` Viresh Kumar
2015-10-13 15:08 ` Viresh Kumar
2015-10-13 17:52 ` Heiko Stübner [this message]
2015-10-13 17:52 ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup " Heiko Stübner
2015-10-14 0:13 ` [PATCH 1/2] ARM: dts: fix gpio-keys " Simon Horman
2015-10-14 0:13 ` Simon Horman
2015-10-14 0:13 ` Simon Horman
2015-10-14 9:01 ` Sudeep Holla
2015-10-14 9:01 ` Sudeep Holla
2015-10-14 9:01 ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-15 14:57 ` Linus Walleij
2015-10-15 14:57 ` Linus Walleij
2015-10-15 15:21 ` Sudeep Holla
2015-10-15 15:21 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561585.uublXABoq2@diego \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=olof@lixom.net \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.