All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property
Date: Wed, 14 Oct 2015 09:01:15 +0000	[thread overview]
Message-ID: <561E19DB.8040701@arm.com> (raw)
In-Reply-To: <20151014001351.GB24693@verge.net.au>



On 14/10/15 01:13, Simon Horman wrote:
> [cc linux-sh]
>
> On Tue, Oct 13, 2015 at 02:32:43PM +0100, Sudeep Holla wrote:
>> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the
>> two boolean properties to enable gpio buttons as wakeup source:
>> 1. "wakeup-source" or
>> 2. the legacy "gpio-key,wakeup"
>>
>> However juno, ste-snowball and emev2-kzm9d dts file have a undetected
>> "wakeup" property to indictate the wakeup source.
>>
>> This patch fixes it by making use of "wakeup-source" property.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>   arch/arm/boot/dts/emev2-kzm9d.dts             |  8 ++++----
>>   arch/arm/boot/dts/ste-snowball.dts            | 10 +++++-----
>>   arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 12 ++++++------
>>   3 files changed, 15 insertions(+), 15 deletions(-)
>
> emev2-kzm9d portion:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> My preferred course of action would be to take that portion through the
> renesas tree if it was broken out into a separate patch. But I won't
> object if someone wants to take the whole patch/series.

I can split this patch, but it is more like a bug fix IMO, I can't use
these GPIO as wakeup on Juno. So I hope arm-soc guys take it directly.
If not, I can split and sent it separately.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property
Date: Wed, 14 Oct 2015 10:01:15 +0100	[thread overview]
Message-ID: <561E19DB.8040701@arm.com> (raw)
In-Reply-To: <20151014001351.GB24693@verge.net.au>



On 14/10/15 01:13, Simon Horman wrote:
> [cc linux-sh]
>
> On Tue, Oct 13, 2015 at 02:32:43PM +0100, Sudeep Holla wrote:
>> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the
>> two boolean properties to enable gpio buttons as wakeup source:
>> 1. "wakeup-source" or
>> 2. the legacy "gpio-key,wakeup"
>>
>> However juno, ste-snowball and emev2-kzm9d dts file have a undetected
>> "wakeup" property to indictate the wakeup source.
>>
>> This patch fixes it by making use of "wakeup-source" property.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>   arch/arm/boot/dts/emev2-kzm9d.dts             |  8 ++++----
>>   arch/arm/boot/dts/ste-snowball.dts            | 10 +++++-----
>>   arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 12 ++++++------
>>   3 files changed, 15 insertions(+), 15 deletions(-)
>
> emev2-kzm9d portion:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> My preferred course of action would be to take that portion through the
> renesas tree if it was broken out into a separate patch. But I won't
> object if someone wants to take the whole patch/series.

I can split this patch, but it is more like a bug fix IMO, I can't use
these GPIO as wakeup on Juno. So I hope arm-soc guys take it directly.
If not, I can split and sent it separately.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Simon Horman <horms@verge.net.au>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Kevin Hilman <khilman@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Olof Johansson <olof@lixom.net>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property
Date: Wed, 14 Oct 2015 10:01:15 +0100	[thread overview]
Message-ID: <561E19DB.8040701@arm.com> (raw)
In-Reply-To: <20151014001351.GB24693@verge.net.au>



On 14/10/15 01:13, Simon Horman wrote:
> [cc linux-sh]
>
> On Tue, Oct 13, 2015 at 02:32:43PM +0100, Sudeep Holla wrote:
>> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the
>> two boolean properties to enable gpio buttons as wakeup source:
>> 1. "wakeup-source" or
>> 2. the legacy "gpio-key,wakeup"
>>
>> However juno, ste-snowball and emev2-kzm9d dts file have a undetected
>> "wakeup" property to indictate the wakeup source.
>>
>> This patch fixes it by making use of "wakeup-source" property.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>   arch/arm/boot/dts/emev2-kzm9d.dts             |  8 ++++----
>>   arch/arm/boot/dts/ste-snowball.dts            | 10 +++++-----
>>   arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 12 ++++++------
>>   3 files changed, 15 insertions(+), 15 deletions(-)
>
> emev2-kzm9d portion:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> My preferred course of action would be to take that portion through the
> renesas tree if it was broken out into a separate patch. But I won't
> object if someone wants to take the whole patch/series.

I can split this patch, but it is more like a bug fix IMO, I can't use
these GPIO as wakeup on Juno. So I hope arm-soc guys take it directly.
If not, I can split and sent it separately.

-- 
Regards,
Sudeep

  reply	other threads:[~2015-10-14  9:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 13:32 [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla
2015-10-13 13:32 ` Sudeep Holla
2015-10-13 13:32 ` [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla
2015-10-13 13:32   ` Sudeep Holla
2015-10-13 14:07   ` Rob Herring
2015-10-13 14:07     ` Rob Herring
2015-10-13 14:26     ` Sudeep Holla
2015-10-13 14:26       ` Sudeep Holla
2015-10-13 14:38   ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Sudeep Holla
2015-10-13 14:38     ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup " Sudeep Holla
     [not found]     ` <1444747133-22671-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2015-10-13 15:08       ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup " Viresh Kumar
2015-10-13 15:08         ` Viresh Kumar
2015-10-13 15:08         ` Viresh Kumar
2015-10-13 17:52     ` Heiko Stübner
2015-10-13 17:52       ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup " Heiko Stübner
2015-10-14  0:13 ` [PATCH 1/2] ARM: dts: fix gpio-keys " Simon Horman
2015-10-14  0:13   ` Simon Horman
2015-10-14  0:13   ` Simon Horman
2015-10-14  9:01   ` Sudeep Holla [this message]
2015-10-14  9:01     ` Sudeep Holla
2015-10-14  9:01     ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-14 15:27   ` Sudeep Holla
2015-10-14 15:27   ` Sudeep Holla
2015-10-15 14:57 ` Linus Walleij
2015-10-15 14:57   ` Linus Walleij
2015-10-15 15:21   ` Sudeep Holla
2015-10-15 15:21     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561E19DB.8040701@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.