All of lore.kernel.org
 help / color / mirror / Atom feed
From: <tony.nguyen@bt.com>
To: <qemu-devel@nongnu.org>
Cc: <peter.maydell@linaro.org>, <walling@linux.ibm.com>,
	<sagark@eecs.berkeley.edu>, <david@redhat.com>,
	<palmer@sifive.com>, <mark.cave-ayland@ilande.co.uk>,
	<Alistair.Francis@wdc.com>, <edgar.iglesias@gmail.com>,
	<arikalo@wavecomp.com>, <mst@redhat.com>, <pasic@linux.ibm.com>,
	<borntraeger@de.ibm.com>, <rth@twiddle.net>,
	<atar4qemu@gmail.com>, <ehabkost@redhat.com>,
	<alex.williamson@redhat.com>, <qemu-arm@nongnu.org>,
	<stefanha@redhat.com>, <shorne@gmail.com>,
	<david@gibson.dropbear.id.au>, <qemu-riscv@nongnu.org>,
	<qemu-s390x@nongnu.org>, <kbastian@mail.uni-paderborn.de>,
	<cohuck@redhat.com>, <laurent@vivier.eu>, <qemu-ppc@nongnu.org>,
	<amarkovic@wavecomp.com>, <pbonzini@redhat.com>,
	<aurelien@aurel32.net>
Subject: [Qemu-riscv] [Qemu-devel] [PATCH v5 06/15] hw/virtio: Access MemoryRegion with MemOp
Date: Fri, 26 Jul 2019 06:45:45 +0000	[thread overview]
Message-ID: <1564123545422.59810@bt.com> (raw)
In-Reply-To: <3106a3c959c4498fad13a5799c89ba7b@tpw09926dag18e.domain1.systemhost.net>

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".

Being a no-op macro, this patch does not introduce any logical change.

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
---
 hw/virtio/virtio-pci.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ce928f2..265f066 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -17,6 +17,7 @@

 #include "qemu/osdep.h"

+#include "exec/memop.h"
 #include "standard-headers/linux/virtio_pci.h"
 #include "hw/virtio/virtio.h"
 #include "hw/pci/pci.h"
@@ -550,7 +551,8 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, hwaddr addr,
         /* As length is under guest control, handle illegal values. */
         return;
     }
-    memory_region_dispatch_write(mr, addr, val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_write(mr, addr, val, SIZE_MEMOP(len),
+                                 MEMTXATTRS_UNSPECIFIED);
 }

 static void
@@ -573,7 +575,8 @@ virtio_address_space_read(VirtIOPCIProxy *proxy, hwaddr addr,
     /* Make sure caller aligned buf properly */
     assert(!(((uintptr_t)buf) & (len - 1)));

-    memory_region_dispatch_read(mr, addr, &val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_read(mr, addr, &val, SIZE_MEMOP(len),
+                                MEMTXATTRS_UNSPECIFIED);
     switch (len) {
     case 1:
         pci_set_byte(buf, val);
--
1.8.3.1




[-- Attachment #2: Type: text/html, Size: 3285 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: <tony.nguyen@bt.com>
To: <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, walling@linux.ibm.com,
	sagark@eecs.berkeley.edu, mst@redhat.com, palmer@sifive.com,
	mark.cave-ayland@ilande.co.uk, laurent@vivier.eu,
	Alistair.Francis@wdc.com, arikalo@wavecomp.com, david@redhat.com,
	pasic@linux.ibm.com, borntraeger@de.ibm.com, rth@twiddle.net,
	atar4qemu@gmail.com, ehabkost@redhat.com, qemu-s390x@nongnu.org,
	qemu-arm@nongnu.org, stefanha@redhat.com, shorne@gmail.com,
	david@gibson.dropbear.id.au, qemu-riscv@nongnu.org,
	kbastian@mail.uni-paderborn.de, cohuck@redhat.com,
	alex.williamson@redhat.com, qemu-ppc@nongnu.org,
	amarkovic@wavecomp.com, pbonzini@redhat.com,
	aurelien@aurel32.net
Subject: [Qemu-arm] [Qemu-devel] [PATCH v5 06/15] hw/virtio: Access MemoryRegion with MemOp
Date: Fri, 26 Jul 2019 06:45:45 +0000	[thread overview]
Message-ID: <1564123545422.59810@bt.com> (raw)
In-Reply-To: <3106a3c959c4498fad13a5799c89ba7b@tpw09926dag18e.domain1.systemhost.net>

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".

Being a no-op macro, this patch does not introduce any logical change.

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
---
 hw/virtio/virtio-pci.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ce928f2..265f066 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -17,6 +17,7 @@

 #include "qemu/osdep.h"

+#include "exec/memop.h"
 #include "standard-headers/linux/virtio_pci.h"
 #include "hw/virtio/virtio.h"
 #include "hw/pci/pci.h"
@@ -550,7 +551,8 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, hwaddr addr,
         /* As length is under guest control, handle illegal values. */
         return;
     }
-    memory_region_dispatch_write(mr, addr, val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_write(mr, addr, val, SIZE_MEMOP(len),
+                                 MEMTXATTRS_UNSPECIFIED);
 }

 static void
@@ -573,7 +575,8 @@ virtio_address_space_read(VirtIOPCIProxy *proxy, hwaddr addr,
     /* Make sure caller aligned buf properly */
     assert(!(((uintptr_t)buf) & (len - 1)));

-    memory_region_dispatch_read(mr, addr, &val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_read(mr, addr, &val, SIZE_MEMOP(len),
+                                MEMTXATTRS_UNSPECIFIED);
     switch (len) {
     case 1:
         pci_set_byte(buf, val);
--
1.8.3.1




[-- Attachment #2: Type: text/html, Size: 3285 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: <tony.nguyen@bt.com>
To: <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, walling@linux.ibm.com,
	sagark@eecs.berkeley.edu, mst@redhat.com, palmer@sifive.com,
	mark.cave-ayland@ilande.co.uk, laurent@vivier.eu,
	Alistair.Francis@wdc.com, edgar.iglesias@gmail.com,
	arikalo@wavecomp.com, david@redhat.com, pasic@linux.ibm.com,
	borntraeger@de.ibm.com, rth@twiddle.net, atar4qemu@gmail.com,
	ehabkost@redhat.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	stefanha@redhat.com, shorne@gmail.com,
	david@gibson.dropbear.id.au, qemu-riscv@nongnu.org,
	kbastian@mail.uni-paderborn.de, cohuck@redhat.com,
	alex.williamson@redhat.com, qemu-ppc@nongnu.org,
	amarkovic@wavecomp.com, pbonzini@redhat.com,
	aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH v5 06/15] hw/virtio: Access MemoryRegion with MemOp
Date: Fri, 26 Jul 2019 06:45:45 +0000	[thread overview]
Message-ID: <1564123545422.59810@bt.com> (raw)
In-Reply-To: <3106a3c959c4498fad13a5799c89ba7b@tpw09926dag18e.domain1.systemhost.net>

No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".

Being a no-op macro, this patch does not introduce any logical change.

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
---
 hw/virtio/virtio-pci.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ce928f2..265f066 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -17,6 +17,7 @@

 #include "qemu/osdep.h"

+#include "exec/memop.h"
 #include "standard-headers/linux/virtio_pci.h"
 #include "hw/virtio/virtio.h"
 #include "hw/pci/pci.h"
@@ -550,7 +551,8 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, hwaddr addr,
         /* As length is under guest control, handle illegal values. */
         return;
     }
-    memory_region_dispatch_write(mr, addr, val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_write(mr, addr, val, SIZE_MEMOP(len),
+                                 MEMTXATTRS_UNSPECIFIED);
 }

 static void
@@ -573,7 +575,8 @@ virtio_address_space_read(VirtIOPCIProxy *proxy, hwaddr addr,
     /* Make sure caller aligned buf properly */
     assert(!(((uintptr_t)buf) & (len - 1)));

-    memory_region_dispatch_read(mr, addr, &val, len, MEMTXATTRS_UNSPECIFIED);
+    memory_region_dispatch_read(mr, addr, &val, SIZE_MEMOP(len),
+                                MEMTXATTRS_UNSPECIFIED);
     switch (len) {
     case 1:
         pci_set_byte(buf, val);
--
1.8.3.1




  parent reply	other threads:[~2019-07-26  6:46 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26  6:42 [Qemu-riscv] [Qemu-devel] [PATCH v5 00/15] Invert Endian bit in SPARCv9 MMU TTE tony.nguyen
2019-07-26  6:42 ` tony.nguyen
2019-07-26  6:43 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 01/15] tcg: TCGMemOp is now accelerator independent MemOp tony.nguyen
2019-07-26  6:43   ` tony.nguyen
2019-07-26  6:43   ` [Qemu-arm] " tony.nguyen
2019-07-26  7:43   ` [Qemu-riscv] " David Gibson
2019-07-26  7:43     ` David Gibson
2019-07-26  7:43     ` [Qemu-arm] " David Gibson
2019-07-26 13:27   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:27     ` Richard Henderson
2019-07-26 13:27     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:43 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 02/15] memory: Access MemoryRegion with MemOp tony.nguyen
2019-07-26  6:43   ` tony.nguyen
2019-07-26  6:43   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:36   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:36     ` Richard Henderson
2019-07-26 13:36     ` [Qemu-arm] " Richard Henderson
2019-07-26 14:04     ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:04       ` Richard Henderson
2019-07-26 14:04       ` [Qemu-arm] " Richard Henderson
2019-07-26  6:44 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 03/15] target/mips: " tony.nguyen
2019-07-26  6:44   ` tony.nguyen
2019-07-26  6:44   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:40   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:40     ` Richard Henderson
2019-07-26 13:40     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:44 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 04/15] hw/s390x: " tony.nguyen
2019-07-26  6:44   ` tony.nguyen
2019-07-26  6:44   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:42   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:42     ` Richard Henderson
2019-07-26  6:45 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 05/15] hw/intc/armv7m_nic: " tony.nguyen
2019-07-26  6:45   ` tony.nguyen
2019-07-26  6:45   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:43   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:43     ` Richard Henderson
2019-07-26 13:43     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:45 ` tony.nguyen [this message]
2019-07-26  6:45   ` [Qemu-devel] [PATCH v5 06/15] hw/virtio: " tony.nguyen
2019-07-26  6:45   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:43   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:43     ` Richard Henderson
2019-07-26 13:43     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:46 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 07/15] hw/vfio: " tony.nguyen
2019-07-26  6:46   ` tony.nguyen
2019-07-26  6:46   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:43   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:43     ` Richard Henderson
2019-07-26 13:43     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:46 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 08/15] exec: " tony.nguyen
2019-07-26  6:46   ` tony.nguyen
2019-07-26  6:46   ` [Qemu-arm] " tony.nguyen
2019-07-26 13:46   ` [Qemu-riscv] " Richard Henderson
2019-07-26 13:46     ` Richard Henderson
2019-07-26 13:46     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:46 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 09/15] cputlb: " tony.nguyen
2019-07-26  6:46   ` tony.nguyen
2019-07-26 11:03   ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-26 11:03     ` Philippe Mathieu-Daudé
2019-07-26 11:03     ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-26 11:16     ` [Qemu-riscv] [EXTERNAL]Re: " Aleksandar Markovic
2019-07-26 11:16       ` [Qemu-devel] [EXTERNAL]Re: " Aleksandar Markovic
2019-07-26 11:16       ` [Qemu-arm] [EXTERNAL]Re: [Qemu-devel] " Aleksandar Markovic
2019-07-26 11:23     ` [Qemu-riscv] " Aleksandar Markovic
2019-07-26 11:23       ` [Qemu-devel] [EXTERNAL]Re: " Aleksandar Markovic
2019-07-26 11:23       ` [Qemu-arm] [EXTERNAL]Re: [Qemu-devel] " Aleksandar Markovic
2019-07-26 14:14   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:14     ` Richard Henderson
2019-07-26 14:14     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:47 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 10/15] memory: Access MemoryRegion with MemOp semantics tony.nguyen
2019-07-26  6:47   ` tony.nguyen
2019-07-26  6:47   ` [Qemu-arm] " tony.nguyen
2019-07-26 14:24   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:24     ` Richard Henderson
2019-07-26  6:47 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap along the I/O path tony.nguyen
2019-07-26  6:47   ` tony.nguyen
2019-07-26  6:47   ` [Qemu-arm] " tony.nguyen
2019-07-26  9:26   ` [Qemu-riscv] " Paolo Bonzini
2019-07-26  9:26     ` Paolo Bonzini
2019-07-26  9:26     ` [Qemu-arm] " Paolo Bonzini
2019-07-26 14:29     ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:29       ` Richard Henderson
2019-07-26 14:29       ` [Qemu-arm] " Richard Henderson
2019-07-26  9:39   ` [Qemu-riscv] " Paolo Bonzini
2019-07-26  9:39     ` Paolo Bonzini
2019-07-26  9:39     ` [Qemu-arm] " Paolo Bonzini
2019-07-26 14:45     ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:45       ` Richard Henderson
2019-07-26 14:45       ` [Qemu-arm] " Richard Henderson
2019-07-26  6:48 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 12/15] cpu: TLB_FLAGS_MASK bit to force memory slow path tony.nguyen
2019-07-26  6:48   ` tony.nguyen
2019-07-26  6:48   ` [Qemu-arm] " tony.nguyen
2019-07-26 14:48   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:48     ` Richard Henderson
2019-07-26 14:48     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:48 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 13/15] cputlb: Byte swap memory transaction attribute tony.nguyen
2019-07-26  6:48   ` tony.nguyen
2019-07-26  6:48   ` [Qemu-arm] " tony.nguyen
2019-07-26 14:52   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:52     ` Richard Henderson
2019-07-26 14:52     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:48 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 14/15] target/sparc: Add TLB entry with attributes tony.nguyen
2019-07-26  6:48   ` tony.nguyen
2019-07-26  6:48   ` [Qemu-arm] " tony.nguyen
2019-07-26 14:55   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:55     ` Richard Henderson
2019-07-26 14:55     ` [Qemu-arm] " Richard Henderson
2019-07-26  6:49 ` [Qemu-riscv] [Qemu-devel] [PATCH v5 15/15] target/sparc: sun4u Invert Endian TTE bit tony.nguyen
2019-07-26  6:49   ` tony.nguyen
2019-07-26  6:49   ` [Qemu-arm] " tony.nguyen
2019-07-26 14:56   ` [Qemu-riscv] " Richard Henderson
2019-07-26 14:56     ` Richard Henderson
2019-07-26 14:56     ` [Qemu-arm] " Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564123545422.59810@bt.com \
    --to=tony.nguyen@bt.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=alex.williamson@redhat.com \
    --cc=amarkovic@wavecomp.com \
    --cc=arikalo@wavecomp.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=palmer@sifive.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    --cc=shorne@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.