From: Fabien Dessenne <fabien.dessenne@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/6] remoteproc: stm32: track the coprocessor state in a backup register
Date: Wed, 30 Oct 2019 14:38:31 +0100 [thread overview]
Message-ID: <1572442713-26353-5-git-send-email-fabien.dessenne@st.com> (raw)
In-Reply-To: <1572442713-26353-1-git-send-email-fabien.dessenne@st.com>
Update the dedicated backup register to track the coprocessor state and
rely on that register to compute the .is_running() value (which expects
a return value of 0 -not 1- if the processor is running).
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/remoteproc/stm32_copro.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/remoteproc/stm32_copro.c b/drivers/remoteproc/stm32_copro.c
index 40bba37..dcafa54 100644
--- a/drivers/remoteproc/stm32_copro.c
+++ b/drivers/remoteproc/stm32_copro.c
@@ -22,14 +22,12 @@
* @hold_boot_regmap: regmap for remote processor reset hold boot
* @hold_boot_offset: offset of the register controlling the hold boot setting
* @hold_boot_mask: bitmask of the register for the hold boot field
- * @is_running: is the remote processor running
*/
struct stm32_copro_privdata {
struct reset_ctl reset_ctl;
struct regmap *hold_boot_regmap;
uint hold_boot_offset;
uint hold_boot_mask;
- bool is_running;
};
/**
@@ -165,11 +163,8 @@ static int stm32_copro_load(struct udevice *dev, ulong addr, ulong size)
*/
static int stm32_copro_start(struct udevice *dev)
{
- struct stm32_copro_privdata *priv;
int ret;
- priv = dev_get_priv(dev);
-
/* move hold boot from true to false start the copro */
ret = stm32_copro_set_hold_boot(dev, false);
if (ret)
@@ -180,7 +175,8 @@ static int stm32_copro_start(struct udevice *dev)
* rebooting autonomously
*/
ret = stm32_copro_set_hold_boot(dev, true);
- priv->is_running = !ret;
+ writel(ret ? TAMP_COPRO_STATE_OFF : TAMP_COPRO_STATE_CRUN,
+ TAMP_COPRO_STATE);
return ret;
}
@@ -206,7 +202,7 @@ static int stm32_copro_reset(struct udevice *dev)
return ret;
}
- priv->is_running = false;
+ writel(TAMP_COPRO_STATE_OFF, TAMP_COPRO_STATE);
return 0;
}
@@ -224,14 +220,11 @@ static int stm32_copro_stop(struct udevice *dev)
/**
* stm32_copro_is_running() - Is the STM32 remote processor running
* @dev: corresponding STM32 remote processor device
- * @return 1 if the remote processor is running, 0 otherwise
+ * @return 0 if the remote processor is running, 1 otherwise
*/
static int stm32_copro_is_running(struct udevice *dev)
{
- struct stm32_copro_privdata *priv;
-
- priv = dev_get_priv(dev);
- return priv->is_running;
+ return (readl(TAMP_COPRO_STATE) == TAMP_COPRO_STATE_OFF);
}
static const struct dm_rproc_ops stm32_copro_ops = {
--
2.7.4
next prev parent reply other threads:[~2019-10-30 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 13:38 [U-Boot] [PATCH v2 0/6] remoteproc: add elf resource table loader Fabien Dessenne
2019-10-30 13:38 ` [U-Boot] [PATCH v2 1/6] remoteproc: elf_loader: Add elf resource table load support Fabien Dessenne
2019-11-25 17:04 ` Patrick DELAUNAY
2019-11-26 3:14 ` Lokesh Vutla
2020-01-08 20:11 ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 2/6] stm32mp1: declare backup registers for coprocessor Fabien Dessenne
2019-11-25 16:54 ` Patrick DELAUNAY
2020-01-08 20:11 ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 3/6] stm32mp1: reset coprocessor status at cold boot Fabien Dessenne
2019-11-25 16:55 ` Patrick DELAUNAY
2020-01-08 20:11 ` Tom Rini
2019-10-30 13:38 ` Fabien Dessenne [this message]
2019-11-25 16:56 ` [U-Boot] [PATCH v2 4/6] remoteproc: stm32: track the coprocessor state in a backup register Patrick DELAUNAY
2020-01-08 20:12 ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 5/6] stm32mp1: remove copro_state environment variable Fabien Dessenne
2019-11-25 16:56 ` Patrick DELAUNAY
2020-01-08 20:12 ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 6/6] remoteproc: stm32: load resource table from firmware Fabien Dessenne
2019-11-25 16:56 ` Patrick DELAUNAY
2020-01-08 20:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572442713-26353-5-git-send-email-fabien.dessenne@st.com \
--to=fabien.dessenne@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.