All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabien Dessenne <fabien.dessenne@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/6] stm32mp1: remove copro_state environment variable
Date: Wed, 30 Oct 2019 14:38:32 +0100	[thread overview]
Message-ID: <1572442713-26353-6-git-send-email-fabien.dessenne@st.com> (raw)
In-Reply-To: <1572442713-26353-1-git-send-email-fabien.dessenne@st.com>

Since the coprocessor state is tracked in a backup register, there is
no more need for tracking it in an environment variable : remove it.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
 board/st/stm32mp1/stm32mp1.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index 126af30..ea9afb6 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -935,10 +935,8 @@ static void board_copro_image_process(ulong fw_image, size_t fw_size)
 	printf("Load Remote Processor %d with data at addr=0x%08lx %u bytes:%s\n",
 	       id, fw_image, fw_size, ret ? " Failed!" : " Success!");
 
-	if (!ret) {
+	if (!ret)
 		rproc_start(id);
-		env_set("copro_state", "booted");
-	}
 }
 
 U_BOOT_FIT_LOADABLE_HANDLER(IH_TYPE_COPRO, board_copro_image_process);
-- 
2.7.4

  parent reply	other threads:[~2019-10-30 13:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 13:38 [U-Boot] [PATCH v2 0/6] remoteproc: add elf resource table loader Fabien Dessenne
2019-10-30 13:38 ` [U-Boot] [PATCH v2 1/6] remoteproc: elf_loader: Add elf resource table load support Fabien Dessenne
2019-11-25 17:04   ` Patrick DELAUNAY
2019-11-26  3:14   ` Lokesh Vutla
2020-01-08 20:11   ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 2/6] stm32mp1: declare backup registers for coprocessor Fabien Dessenne
2019-11-25 16:54   ` Patrick DELAUNAY
2020-01-08 20:11   ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 3/6] stm32mp1: reset coprocessor status at cold boot Fabien Dessenne
2019-11-25 16:55   ` Patrick DELAUNAY
2020-01-08 20:11   ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 4/6] remoteproc: stm32: track the coprocessor state in a backup register Fabien Dessenne
2019-11-25 16:56   ` Patrick DELAUNAY
2020-01-08 20:12   ` Tom Rini
2019-10-30 13:38 ` Fabien Dessenne [this message]
2019-11-25 16:56   ` [U-Boot] [PATCH v2 5/6] stm32mp1: remove copro_state environment variable Patrick DELAUNAY
2020-01-08 20:12   ` Tom Rini
2019-10-30 13:38 ` [U-Boot] [PATCH v2 6/6] remoteproc: stm32: load resource table from firmware Fabien Dessenne
2019-11-25 16:56   ` Patrick DELAUNAY
2020-01-08 20:12   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1572442713-26353-6-git-send-email-fabien.dessenne@st.com \
    --to=fabien.dessenne@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.