Re: [PATCH v3 1/6] MIPS: DTS: jz4780: add #includes for irq.h and gpio.h

[Paul Cercueil <paul@crapouillou.net>]

Hi Nikolaus,


Le dim., févr. 16, 2020 at 21:20, H. Nikolaus Schaller 
<hns@goldelico.com> a écrit :
> The constants from irq.h and gpio.h can and should be
> used in the jz4780.dtsi and derived DTS like ci20.dts.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index f928329b034b..112a24deff71 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include <dt-bindings/clock/jz4780-cgu.h>
>  #include <dt-bindings/dma/jz4780-dma.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>

I don't think you need an extra patch for that - just add each include 
in the patch that first use them.

-Paul

> 
>  / {
>  	#address-cells = <1>;
> --
> 2.23.0
>