From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Boddie <paul@boddie.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Andi Kleen <ak@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com, stable@vger.kernel.org
Subject: Re: [PATCH v3 3/6] MIPS: DTS: CI20: fix PMU definitions for ACT8600
Date: Fri, 28 Feb 2020 11:34:04 -0300 [thread overview]
Message-ID: <1582900444.3.1@crapouillou.net> (raw)
In-Reply-To: <36aa1e80153fbb29eeb56f65cac9e3672165f7b7.1581884459.git.hns@goldelico.com>
Hi Nikolaus,
Le dim., févr. 16, 2020 at 21:20, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> There is a ACT8600 on the CI20 board and the bindings of the
> ACT8865 driver have changed without updating the CI20 device
> tree. Therefore the PMU can not be probed successfully and
> is running in power-on reset state.
>
> Fix DT to match the latest act8865-regulator bindings.
>
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 48
> ++++++++++++++++++++---------
> 1 file changed, 33 insertions(+), 15 deletions(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 59c104289ece..4f48bc16fb52 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -153,6 +153,8 @@
> pinctrl-0 = <&pins_uart4>;
> };
>
> +#include <dt-bindings/regulator/active-semi,8865-regulator.h>
Includes at the beginning of the file please. Keeps it tidy.
> +
> &i2c0 {
> status = "okay";
>
> @@ -166,65 +168,81 @@
> reg = <0x5a>;
> status = "okay";
>
> +/*
> +Optional input supply properties:
> +- for act8600:
> + - vp1-supply: The input supply for DCDC_REG1
> + - vp2-supply: The input supply for DCDC_REG2
> + - vp3-supply: The input supply for DCDC_REG3
> + - inl-supply: The input supply for LDO_REG5, LDO_REG6, LDO_REG7
> and LDO_REG8
> + SUDCDC_REG4, LDO_REG9 and LDO_REG10 do not have separate supplies.
> +*/
> +
> regulators {
> vddcore: SUDCDC1 {
> - regulator-name = "VDDCORE";
> + regulator-name = "DCDC_REG1";
> regulator-min-microvolt = <1100000>;
> regulator-max-microvolt = <1100000>;
> regulator-always-on;
> };
> vddmem: SUDCDC2 {
> - regulator-name = "VDDMEM";
> + regulator-name = "DCDC_REG2";
> regulator-min-microvolt = <1500000>;
> regulator-max-microvolt = <1500000>;
> regulator-always-on;
> };
> vcc_33: SUDCDC3 {
> - regulator-name = "VCC33";
> + regulator-name = "DCDC_REG3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
> vcc_50: SUDCDC4 {
> - regulator-name = "VCC50";
> + regulator-name = "SUDCDC_REG4";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> regulator-always-on;
> };
> vcc_25: LDO_REG5 {
> - regulator-name = "VCC25";
> + regulator-name = "LDO_REG5";
> regulator-min-microvolt = <2500000>;
> regulator-max-microvolt = <2500000>;
> regulator-always-on;
> };
> wifi_io: LDO_REG6 {
> - regulator-name = "WIFIIO";
> + regulator-name = "LDO_REG6";
> regulator-min-microvolt = <2500000>;
> regulator-max-microvolt = <2500000>;
> regulator-always-on;
> };
> vcc_28: LDO_REG7 {
> - regulator-name = "VCC28";
> + regulator-name = "LDO_REG7";
> regulator-min-microvolt = <2800000>;
> regulator-max-microvolt = <2800000>;
> regulator-always-on;
> };
> vcc_15: LDO_REG8 {
> - regulator-name = "VCC15";
> + regulator-name = "LDO_REG8";
> regulator-min-microvolt = <1500000>;
> regulator-max-microvolt = <1500000>;
> regulator-always-on;
> };
> - vcc_18: LDO_REG9 {
> - regulator-name = "VCC18";
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> + vrtc_18: LDO_REG9 {
> + regulator-name = "LDO_REG9";
> + /* Despite the datasheet stating 3.3V for REG9 and
> + driver expecting that, REG9 outputs 1.8V.
> + Likely the CI20 uses a chip variant.
> + Since it is a simple on/off LDO the exact values
> + do not matter.
> + */
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
> vcc_11: LDO_REG10 {
> - regulator-name = "VCC11";
> - regulator-min-microvolt = <1100000>;
> - regulator-max-microvolt = <1100000>;
> + regulator-name = "LDO_REG10";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> regulator-always-on;
> };
> };
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-02-28 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 20:20 [PATCH v3 0/6] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 1/6] MIPS: DTS: jz4780: add #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-28 14:33 ` Paul Cercueil
2020-02-16 20:20 ` [PATCH v3 2/6] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 3/6] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-28 14:34 ` Paul Cercueil [this message]
2020-02-28 14:40 ` H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 4/6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
2020-02-16 20:20 ` [PATCH v3 5/6] MIPS: DTS: CI20: multiple DTS improvements H. Nikolaus Schaller
2020-02-28 14:36 ` Paul Cercueil
2020-02-28 14:42 ` H. Nikolaus Schaller
2020-02-28 14:50 ` Paul Cercueil
2020-02-16 20:21 ` [PATCH v3 6/6] MIPS: CI20: defconfig: multiple improvements H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582900444.3.1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=ak@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@boddie.org.uk \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.