From: CK Hu <ck.hu@mediatek.com>
To: Matthias Brugger <mbrugger@suse.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<p.zabel@pengutronix.de>, <airlied@linux.ie>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<ulrich.hecht+renesas@gmail.com>,
<laurent.pinchart@ideasonboard.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-media@vger.kernel.org>,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-mediatek@lists.infradead.org>,
"Collabora Kernel ML" <kernel@collabora.com>,
<dri-devel@lists.freedesktop.org>,
"Seiya Wang" <seiya.wang@mediatek.com>,
<linux-kernel@vger.kernel.org>, <wens@csie.org>,
Daniel Vetter <daniel@ffwll.ch>, <linux-clk@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
<devicetree@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, <frank-w@public-files.de>,
<linux-arm-kernel@lists.infradead.org>, <hsinyi@chromium.org>,
Richard Fontana <rfontana@redhat.com>,
mtk01761 <wendell.lin@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>, <sean.wang@mediatek.com>,
<rdunlap@infradead.org>, <matthias.bgg@kernel.org>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>
Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing
Date: Wed, 11 Mar 2020 21:35:26 +0800 [thread overview]
Message-ID: <1583933726.1550.1.camel@mtksdaap41> (raw)
In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com>
On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote:
>
> On 11/03/2020 12:56, Enric Balletbo i Serra wrote:
> > In the actual implementation the same compatible string
> > "mediatek,<chip>-mmsys" is used to bind the clock drivers
> > (drivers/soc/mediatek) as well as to the gpu driver
> > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem
> > that the only probed driver is the clock driver and there is no display
> > at all.
> >
> > In any case having the same compatible string for two drivers is not
> > correct and should be fixed. To fix this, and maintain backward
> > compatibility, we can consider that the mmsys driver is the top-level
> > entry point for the multimedia subsystem, so is not a pure clock
> > controller but a system controller, and the drm driver is instantiated
> > by that MMSYS driver.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Same here.
Acked-by: CK Hu <ck.hu@mediatek.com>
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Matthias Brugger <mbrugger@suse.com>
Cc: mark.rutland@arm.com, Kate Stewart <kstewart@linuxfoundation.org>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
airlied@linux.ie, mturquette@baylibre.com,
dri-devel@lists.freedesktop.org,
Richard Fontana <rfontana@redhat.com>,
laurent.pinchart@ideasonboard.com,
ulrich.hecht+renesas@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-clk@vger.kernel.org, Weiyi Lu <weiyi.lu@mediatek.com>,
wens@csie.org, linux-arm-kernel@lists.infradead.org,
mtk01761 <wendell.lin@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, frank-w@public-files.de,
Seiya Wang <seiya.wang@mediatek.com>,
sean.wang@mediatek.com, Houlong Wei <houlong.wei@mediatek.com>,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
hsinyi@chromium.org, Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Allison Randal <allison@lohutok.net>,
sboyd@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>,
matthias.bgg@kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing
Date: Wed, 11 Mar 2020 21:35:26 +0800 [thread overview]
Message-ID: <1583933726.1550.1.camel@mtksdaap41> (raw)
In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com>
On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote:
>
> On 11/03/2020 12:56, Enric Balletbo i Serra wrote:
> > In the actual implementation the same compatible string
> > "mediatek,<chip>-mmsys" is used to bind the clock drivers
> > (drivers/soc/mediatek) as well as to the gpu driver
> > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem
> > that the only probed driver is the clock driver and there is no display
> > at all.
> >
> > In any case having the same compatible string for two drivers is not
> > correct and should be fixed. To fix this, and maintain backward
> > compatibility, we can consider that the mmsys driver is the top-level
> > entry point for the multimedia subsystem, so is not a pure clock
> > controller but a system controller, and the drm driver is instantiated
> > by that MMSYS driver.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Same here.
Acked-by: CK Hu <ck.hu@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Matthias Brugger <mbrugger@suse.com>
Cc: mark.rutland@arm.com, Kate Stewart <kstewart@linuxfoundation.org>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
airlied@linux.ie, mturquette@baylibre.com,
dri-devel@lists.freedesktop.org,
Richard Fontana <rfontana@redhat.com>,
laurent.pinchart@ideasonboard.com,
ulrich.hecht+renesas@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-clk@vger.kernel.org, Weiyi Lu <weiyi.lu@mediatek.com>,
wens@csie.org, linux-arm-kernel@lists.infradead.org,
mtk01761 <wendell.lin@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, frank-w@public-files.de,
Seiya Wang <seiya.wang@mediatek.com>,
sean.wang@mediatek.com, Houlong Wei <houlong.wei@mediatek.com>,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
hsinyi@chromium.org, Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Allison Randal <allison@lohutok.net>,
sboyd@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>,
matthias.bgg@kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing
Date: Wed, 11 Mar 2020 21:35:26 +0800 [thread overview]
Message-ID: <1583933726.1550.1.camel@mtksdaap41> (raw)
In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com>
On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote:
>
> On 11/03/2020 12:56, Enric Balletbo i Serra wrote:
> > In the actual implementation the same compatible string
> > "mediatek,<chip>-mmsys" is used to bind the clock drivers
> > (drivers/soc/mediatek) as well as to the gpu driver
> > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem
> > that the only probed driver is the clock driver and there is no display
> > at all.
> >
> > In any case having the same compatible string for two drivers is not
> > correct and should be fixed. To fix this, and maintain backward
> > compatibility, we can consider that the mmsys driver is the top-level
> > entry point for the multimedia subsystem, so is not a pure clock
> > controller but a system controller, and the drm driver is instantiated
> > by that MMSYS driver.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Same here.
Acked-by: CK Hu <ck.hu@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Matthias Brugger <mbrugger@suse.com>
Cc: mark.rutland@arm.com, Kate Stewart <kstewart@linuxfoundation.org>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
airlied@linux.ie, mturquette@baylibre.com,
dri-devel@lists.freedesktop.org,
Richard Fontana <rfontana@redhat.com>,
laurent.pinchart@ideasonboard.com,
ulrich.hecht+renesas@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-clk@vger.kernel.org, Weiyi Lu <weiyi.lu@mediatek.com>,
wens@csie.org, linux-arm-kernel@lists.infradead.org,
mtk01761 <wendell.lin@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
frank-w@public-files.de, Seiya Wang <seiya.wang@mediatek.com>,
sean.wang@mediatek.com, Houlong Wei <houlong.wei@mediatek.com>,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
hsinyi@chromium.org, Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Allison Randal <allison@lohutok.net>,
sboyd@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
matthias.bgg@kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing
Date: Wed, 11 Mar 2020 21:35:26 +0800 [thread overview]
Message-ID: <1583933726.1550.1.camel@mtksdaap41> (raw)
In-Reply-To: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com>
On Wed, 2020-03-11 at 14:26 +0100, Matthias Brugger wrote:
>
> On 11/03/2020 12:56, Enric Balletbo i Serra wrote:
> > In the actual implementation the same compatible string
> > "mediatek,<chip>-mmsys" is used to bind the clock drivers
> > (drivers/soc/mediatek) as well as to the gpu driver
> > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem
> > that the only probed driver is the clock driver and there is no display
> > at all.
> >
> > In any case having the same compatible string for two drivers is not
> > correct and should be fixed. To fix this, and maintain backward
> > compatibility, we can consider that the mmsys driver is the top-level
> > entry point for the multimedia subsystem, so is not a pure clock
> > controller but a system controller, and the drm driver is instantiated
> > by that MMSYS driver.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Same here.
Acked-by: CK Hu <ck.hu@mediatek.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-11 13:35 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 11:56 [PATCH v11 0/5] arm/arm64: mediatek: Fix mt8173 mmsys device probing Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` [PATCH v11 1/5] drm/mediatek: Omit warning on probe defers Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` [PATCH v11 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` [PATCH v11 3/5] clk / soc: mediatek: Move mt8173 MMSYS to platform driver Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 13:05 ` CK Hu
2020-03-11 13:05 ` CK Hu
2020-03-11 13:05 ` CK Hu
2020-03-11 13:05 ` CK Hu
2020-03-11 13:23 ` Matthias Brugger
2020-03-11 13:23 ` Matthias Brugger
2020-03-11 13:23 ` Matthias Brugger
2020-03-11 13:23 ` Matthias Brugger
2020-03-11 11:56 ` [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 13:07 ` CK Hu
2020-03-11 13:07 ` CK Hu
2020-03-11 13:07 ` CK Hu
2020-03-11 13:07 ` CK Hu
2020-03-11 13:25 ` Matthias Brugger
2020-03-11 13:25 ` Matthias Brugger
2020-03-11 13:25 ` Matthias Brugger
2020-03-11 13:25 ` Matthias Brugger
2020-03-11 13:34 ` CK Hu
2020-03-11 13:34 ` CK Hu
2020-03-11 13:34 ` CK Hu
2020-03-11 13:34 ` CK Hu
2020-03-11 11:56 ` [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 11:56 ` Enric Balletbo i Serra
2020-03-11 13:26 ` Matthias Brugger
2020-03-11 13:26 ` Matthias Brugger
2020-03-11 13:26 ` Matthias Brugger
2020-03-11 13:26 ` Matthias Brugger
2020-03-11 13:35 ` CK Hu [this message]
2020-03-11 13:35 ` CK Hu
2020-03-11 13:35 ` CK Hu
2020-03-11 13:35 ` CK Hu
2020-03-11 13:01 ` [PATCH v11 0/5] arm/arm64: mediatek: Fix mt8173 mmsys " CK Hu
2020-03-11 13:01 ` CK Hu
2020-03-11 13:01 ` CK Hu
2020-03-11 13:01 ` CK Hu
2020-03-11 15:53 ` Enric Balletbo i Serra
2020-03-11 15:53 ` Enric Balletbo i Serra
2020-03-11 15:53 ` Enric Balletbo i Serra
-- strict thread matches above, loose matches on Subject: below --
2020-03-02 11:01 Enric Balletbo i Serra
2020-03-02 11:01 ` [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm " Enric Balletbo i Serra
2020-03-02 11:01 ` Enric Balletbo i Serra
2020-03-02 11:01 ` Enric Balletbo i Serra
2020-03-02 11:01 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583933726.1550.1.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=allison@lohutok.net \
--cc=andrew-ct.chen@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=houlong.wei@mediatek.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=kstewart@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=tglx@linutronix.de \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=weiyi.lu@mediatek.com \
--cc=wendell.lin@mediatek.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.