From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Michel Dänzer" <michel@daenzer.net>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations
Date: Fri, 12 May 2017 14:38:38 +0300 [thread overview]
Message-ID: <1587529.CdsjPgZMHu@avalon> (raw)
In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com>
Hi Christian,
On Wednesday 10 May 2017 13:30:37 Christian König wrote:
> Am 10.05.2017 um 02:23 schrieb Michel Dänzer:
> > On 03/05/17 09:46 PM, Christian König wrote:
> >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring:
> >>> From: Markus Elfring <elfring@users.sourceforge.net>
> >>> Date: Tue, 2 May 2017 22:00:02 +0200
> >>>
> >>> Three update suggestions were taken into account
> >>> from static source code analysis.
> >>>
> >>> Markus Elfring (3):
> >>> Use seq_putc() in radeon_sa_bo_dump_debug_info()
> >>> Use seq_puts() in radeon_debugfs_pm_info()
> >>> Use seq_puts() in r100_debugfs_cp_csq_fifo()
> >>
> >> Reviewed-by: Christian König <christian.koenig@amd.com>
> >
> > Based on
> > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html
> > and followups, I'm afraid we'll have to make sure Markus' patches have
> > been tested adequately before applying them.
>
> I can't judge the background of that decision, but at least those tree
> patches for radeon looked trivial to me.
>
> I don't see much what could go wrong when merging them.
For what it's worth, I've once applied a patch from Markus for the uvcvideo
driver that seemed trivial but ended up introducing a breakage that I hadn't
caught during review. I recommend rejecting Markus' patches that are not clear
improvements, and carefully testing the others.
> On the other hand you are right that trying to find hardware to test that
> stuff could be challenging.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Michel Dänzer" <michel@daenzer.net>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations
Date: Fri, 12 May 2017 11:38:38 +0000 [thread overview]
Message-ID: <1587529.CdsjPgZMHu@avalon> (raw)
In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com>
Hi Christian,
On Wednesday 10 May 2017 13:30:37 Christian König wrote:
> Am 10.05.2017 um 02:23 schrieb Michel Dänzer:
> > On 03/05/17 09:46 PM, Christian König wrote:
> >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring:
> >>> From: Markus Elfring <elfring@users.sourceforge.net>
> >>> Date: Tue, 2 May 2017 22:00:02 +0200
> >>>
> >>> Three update suggestions were taken into account
> >>> from static source code analysis.
> >>>
> >>> Markus Elfring (3):
> >>> Use seq_putc() in radeon_sa_bo_dump_debug_info()
> >>> Use seq_puts() in radeon_debugfs_pm_info()
> >>> Use seq_puts() in r100_debugfs_cp_csq_fifo()
> >>
> >> Reviewed-by: Christian König <christian.koenig@amd.com>
> >
> > Based on
> > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html
> > and followups, I'm afraid we'll have to make sure Markus' patches have
> > been tested adequately before applying them.
>
> I can't judge the background of that decision, but at least those tree
> patches for radeon looked trivial to me.
>
> I don't see much what could go wrong when merging them.
For what it's worth, I've once applied a patch from Markus for the uvcvideo
driver that seemed trivial but ended up introducing a breakage that I hadn't
caught during review. I recommend rejecting Markus' patches that are not clear
improvements, and carefully testing the others.
> On the other hand you are right that trying to find hardware to test that
> stuff could be challenging.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>,
"Michel Dänzer" <michel@daenzer.net>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations
Date: Fri, 12 May 2017 14:38:38 +0300 [thread overview]
Message-ID: <1587529.CdsjPgZMHu@avalon> (raw)
In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com>
Hi Christian,
On Wednesday 10 May 2017 13:30:37 Christian König wrote:
> Am 10.05.2017 um 02:23 schrieb Michel Dänzer:
> > On 03/05/17 09:46 PM, Christian König wrote:
> >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring:
> >>> From: Markus Elfring <elfring@users.sourceforge.net>
> >>> Date: Tue, 2 May 2017 22:00:02 +0200
> >>>
> >>> Three update suggestions were taken into account
> >>> from static source code analysis.
> >>>
> >>> Markus Elfring (3):
> >>> Use seq_putc() in radeon_sa_bo_dump_debug_info()
> >>> Use seq_puts() in radeon_debugfs_pm_info()
> >>> Use seq_puts() in r100_debugfs_cp_csq_fifo()
> >>
> >> Reviewed-by: Christian König <christian.koenig@amd.com>
> >
> > Based on
> > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html
> > and followups, I'm afraid we'll have to make sure Markus' patches have
> > been tested adequately before applying them.
>
> I can't judge the background of that decision, but at least those tree
> patches for radeon looked trivial to me.
>
> I don't see much what could go wrong when merging them.
For what it's worth, I've once applied a patch from Markus for the uvcvideo
driver that seemed trivial but ended up introducing a breakage that I hadn't
caught during review. I recommend rejecting Markus' patches that are not clear
improvements, and carefully testing the others.
> On the other hand you are right that trying to find hardware to test that
> stuff could be challenging.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-05-12 11:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 20:04 [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations SF Markus Elfring
2017-05-02 20:04 ` SF Markus Elfring
2017-05-02 20:06 ` [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info() SF Markus Elfring
2017-05-02 20:06 ` SF Markus Elfring
2017-05-02 20:08 ` [PATCH 2/3] GPU-DRM-Radeon: Use seq_puts() in radeon_debugfs_pm_info() SF Markus Elfring
2017-05-02 20:08 ` SF Markus Elfring
2017-05-02 20:10 ` [PATCH 3/3] GPU-DRM-Radeon: Use seq_puts() in r100_debugfs_cp_csq_fifo() SF Markus Elfring
2017-05-02 20:10 ` SF Markus Elfring
2017-05-02 20:10 ` SF Markus Elfring
2017-05-03 12:46 ` [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations Christian König
2017-05-03 12:46 ` Christian König
2017-05-03 12:46 ` Christian König
2017-05-10 0:23 ` Michel Dänzer
2017-05-10 0:23 ` Michel Dänzer
2017-05-10 0:23 ` Michel Dänzer
[not found] ` <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-05-10 11:30 ` Christian König
2017-05-10 11:30 ` Christian König
2017-05-10 11:30 ` Christian König
2017-05-11 2:40 ` Michel Dänzer
2017-05-11 2:40 ` Michel Dänzer
2017-05-11 2:40 ` Michel Dänzer
2017-05-12 11:38 ` Laurent Pinchart [this message]
2017-05-12 11:38 ` Laurent Pinchart
2017-05-12 11:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587529.CdsjPgZMHu@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.