All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Jeevan B <jeevan.b@intel.com>,
	uma.shankar@intel.com, Oleg Vasilev <oleg.vasilev@intel.com>
Subject: [PATCH 2/5] drm/i915: utilize subconnector property for DP
Date: Fri, 24 Apr 2020 18:20:52 +0530	[thread overview]
Message-ID: <1587732655-17544-2-git-send-email-jeevan.b@intel.com> (raw)
In-Reply-To: <1587732655-17544-1-git-send-email-jeevan.b@intel.com>

From: Oleg Vasilev <oleg.vasilev@intel.com>

Since DP-specific information is stored in driver's structures, every
driver needs to implement subconnector property by itself.

v2: updates to match previous commit changes

v3: rebase

v4: renamed a function call

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Oleg Vasilev <oleg.vasilev@intel.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Tested-by: Oleg Vasilev <oleg.vasilev@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 66f8a9d..6e9db91 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6448,6 +6448,11 @@ intel_dp_detect(struct drm_connector *connector,
 	 */
 	intel_display_power_flush_work(dev_priv);
 
+	if (!intel_dp_is_edp(intel_dp))
+		drm_dp_set_subconnector_property(connector,
+						 status,
+						 intel_dp->dpcd,
+						 intel_dp->downstream_ports);
 	return status;
 }
 
@@ -7542,6 +7547,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect
 	struct drm_i915_private *dev_priv = to_i915(connector->dev);
 	enum port port = dp_to_dig_port(intel_dp)->base.port;
 
+	if (!intel_dp_is_edp(intel_dp))
+		drm_connector_attach_dp_subconnector_property(connector);
+
 	if (!IS_G4X(dev_priv) && port != PORT_A)
 		intel_attach_force_audio_property(connector);
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jeevan B <jeevan.b@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Jeevan B <jeevan.b@intel.com>,
	Oleg Vasilev <oleg.vasilev@intel.com>
Subject: [Intel-gfx] [PATCH 2/5] drm/i915: utilize subconnector property for DP
Date: Fri, 24 Apr 2020 18:20:52 +0530	[thread overview]
Message-ID: <1587732655-17544-2-git-send-email-jeevan.b@intel.com> (raw)
In-Reply-To: <1587732655-17544-1-git-send-email-jeevan.b@intel.com>

From: Oleg Vasilev <oleg.vasilev@intel.com>

Since DP-specific information is stored in driver's structures, every
driver needs to implement subconnector property by itself.

v2: updates to match previous commit changes

v3: rebase

v4: renamed a function call

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Oleg Vasilev <oleg.vasilev@intel.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Tested-by: Oleg Vasilev <oleg.vasilev@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 66f8a9d..6e9db91 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6448,6 +6448,11 @@ intel_dp_detect(struct drm_connector *connector,
 	 */
 	intel_display_power_flush_work(dev_priv);
 
+	if (!intel_dp_is_edp(intel_dp))
+		drm_dp_set_subconnector_property(connector,
+						 status,
+						 intel_dp->dpcd,
+						 intel_dp->downstream_ports);
 	return status;
 }
 
@@ -7542,6 +7547,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect
 	struct drm_i915_private *dev_priv = to_i915(connector->dev);
 	enum port port = dp_to_dig_port(intel_dp)->base.port;
 
+	if (!intel_dp_is_edp(intel_dp))
+		drm_connector_attach_dp_subconnector_property(connector);
+
 	if (!IS_G4X(dev_priv) && port != PORT_A)
 		intel_attach_force_audio_property(connector);
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-24 12:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 12:50 [PATCH 1/5] drm: report dp downstream port type as a subconnector property Jeevan B
2020-04-24 12:50 ` [Intel-gfx] " Jeevan B
2020-04-24 12:50 ` Jeevan B [this message]
2020-04-24 12:50   ` [Intel-gfx] [PATCH 2/5] drm/i915: utilize subconnector property for DP Jeevan B
2020-04-24 12:50 ` [PATCH 3/5] drm/nouveau: " Jeevan B
2020-04-24 12:50   ` [Intel-gfx] " Jeevan B
2020-04-24 12:50   ` Jeevan B
2020-08-16  6:51   ` [Intel-gfx] [v3] " Jeevan B
2020-08-16  6:51     ` Jeevan B
2020-08-16  6:51     ` Jeevan B
2020-09-01  7:23     ` [Intel-gfx] " B, Jeevan
2020-09-01  7:23       ` B, Jeevan
2020-09-01  7:23       ` B, Jeevan
2020-04-24 12:50 ` [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios Jeevan B
2020-04-24 12:50   ` [Intel-gfx] " Jeevan B
2020-04-24 12:50   ` Jeevan B
2020-04-24 12:50 ` [PATCH 5/5] drm/amdgpu: utilize subconnector property for DP through DisplayManager Jeevan B
2020-04-24 12:50   ` [Intel-gfx] " Jeevan B
2020-04-24 12:50   ` Jeevan B
2020-04-24 13:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property Patchwork
2020-04-24 13:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-04-24 13:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-24 14:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-08-26  7:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property (rev2) Patchwork
2020-08-26  7:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-04-07  6:50 [PATCH 1/5] drm: report dp downstream port type as a subconnector property Jeevan B
2020-04-07  6:50 ` [PATCH 2/5] drm/i915: utilize subconnector property for DP Jeevan B
2020-04-15 10:01   ` Jani Nikula
2020-04-21  9:37     ` Jeevan B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587732655-17544-2-git-send-email-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=oleg.vasilev@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.