All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, uma.shankar@intel.com,
	Oleg Vasilev <oleg.vasilev@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: utilize subconnector property for DP
Date: Tue, 21 Apr 2020 15:07:21 +0530	[thread overview]
Message-ID: <20200421093720.GB13664@intel.com> (raw)
In-Reply-To: <874ktl5ap4.fsf@intel.com>

On 2020-04-15 at 13:01:59 +0300, Jani Nikula wrote:
> On Tue, 07 Apr 2020, Jeevan B <jeevan.b@intel.com> wrote:
> > From: Oleg Vasilev <oleg.vasilev@intel.com>
> >
> > Since DP-specific information is stored in driver's structures, every
> > driver needs to implement subconnector property by itself.
> >
> > v2: updates to match previous commit changes
> >
> > v3: rebase
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > Signed-off-by: Oleg Vasilev <oleg.vasilev@intel.com>
> > Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
> > Tested-by: Oleg Vasilev <oleg.vasilev@intel.com>
> > Link: https://patchwork.freedesktop.org/patch/msgid/20190829114854.1539-4-oleg.vasilev@intel.com
> 
> You're not supposed to add the Link: tag yourself.
I will do the necessary change. 
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks
Jeevan B
> 
>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index db6ae8e..ba443e1 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -6155,6 +6155,11 @@ intel_dp_detect(struct drm_connector *connector,
> >  	 */
> >  	intel_display_power_flush_work(dev_priv);
> >  
> > +	if (!intel_dp_is_edp(intel_dp))
> > +		drm_dp_set_subconnector_property(connector,
> > +						 status,
> > +						 intel_dp->dpcd,
> > +						 intel_dp->downstream_ports);
> >  	return status;
> >  }
> >  
> > @@ -7211,6 +7216,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect
> >  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
> >  	enum port port = dp_to_dig_port(intel_dp)->base.port;
> >  
> > +	if (!intel_dp_is_edp(intel_dp))
> > +		drm_mode_add_dp_subconnector_property(connector);
> > +
> >  	if (!IS_G4X(dev_priv) && port != PORT_A)
> >  		intel_attach_force_audio_property(connector);
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jeevan B <jeevan.b@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Oleg Vasilev <oleg.vasilev@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: utilize subconnector property for DP
Date: Tue, 21 Apr 2020 15:07:21 +0530	[thread overview]
Message-ID: <20200421093720.GB13664@intel.com> (raw)
In-Reply-To: <874ktl5ap4.fsf@intel.com>

On 2020-04-15 at 13:01:59 +0300, Jani Nikula wrote:
> On Tue, 07 Apr 2020, Jeevan B <jeevan.b@intel.com> wrote:
> > From: Oleg Vasilev <oleg.vasilev@intel.com>
> >
> > Since DP-specific information is stored in driver's structures, every
> > driver needs to implement subconnector property by itself.
> >
> > v2: updates to match previous commit changes
> >
> > v3: rebase
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > Signed-off-by: Oleg Vasilev <oleg.vasilev@intel.com>
> > Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
> > Tested-by: Oleg Vasilev <oleg.vasilev@intel.com>
> > Link: https://patchwork.freedesktop.org/patch/msgid/20190829114854.1539-4-oleg.vasilev@intel.com
> 
> You're not supposed to add the Link: tag yourself.
I will do the necessary change. 
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks
Jeevan B
> 
>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index db6ae8e..ba443e1 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -6155,6 +6155,11 @@ intel_dp_detect(struct drm_connector *connector,
> >  	 */
> >  	intel_display_power_flush_work(dev_priv);
> >  
> > +	if (!intel_dp_is_edp(intel_dp))
> > +		drm_dp_set_subconnector_property(connector,
> > +						 status,
> > +						 intel_dp->dpcd,
> > +						 intel_dp->downstream_ports);
> >  	return status;
> >  }
> >  
> > @@ -7211,6 +7216,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect
> >  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
> >  	enum port port = dp_to_dig_port(intel_dp)->base.port;
> >  
> > +	if (!intel_dp_is_edp(intel_dp))
> > +		drm_mode_add_dp_subconnector_property(connector);
> > +
> >  	if (!IS_G4X(dev_priv) && port != PORT_A)
> >  		intel_attach_force_audio_property(connector);
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-21  9:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  6:50 [PATCH 1/5] drm: report dp downstream port type as a subconnector property Jeevan B
2020-04-07  6:50 ` [Intel-gfx] " Jeevan B
2020-04-07  6:50 ` [PATCH 2/5] drm/i915: utilize subconnector property for DP Jeevan B
2020-04-07  6:50   ` [Intel-gfx] " Jeevan B
2020-04-15 10:01   ` Jani Nikula
2020-04-15 10:01     ` [Intel-gfx] " Jani Nikula
2020-04-21  9:37     ` Jeevan B [this message]
2020-04-21  9:37       ` Jeevan B
2020-04-07  6:50 ` [PATCH 3/5] drm/nouveau: " Jeevan B
2020-04-07  6:50   ` [Intel-gfx] " Jeevan B
2020-04-07  6:50   ` Jeevan B
2020-04-07  6:50 ` [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios Jeevan B
2020-04-07  6:50   ` [Intel-gfx] " Jeevan B
2020-04-07  6:50   ` Jeevan B
2020-04-15 10:04   ` [Intel-gfx] " Jani Nikula
2020-04-15 10:04     ` Jani Nikula
2020-04-15 10:04     ` Jani Nikula
2020-04-16 13:53     ` Alex Deucher
2020-04-16 13:53       ` Alex Deucher
2020-04-16 13:53       ` Alex Deucher
2020-04-16 18:39       ` Jani Nikula
2020-04-16 18:39         ` Jani Nikula
2020-04-16 18:39         ` Jani Nikula
2020-04-07  6:50 ` [PATCH 5/5] drm/amdgpu: utilize subconnector property for DP through DisplayManager Jeevan B
2020-04-07  6:50   ` [Intel-gfx] " Jeevan B
2020-04-07  6:50   ` Jeevan B
2020-04-07  7:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm: report dp downstream port type as a subconnector property Patchwork
2020-04-07  7:45 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-04-07  8:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-07 15:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-15 10:01 ` [PATCH 1/5] " Jani Nikula
2020-04-15 10:01   ` [Intel-gfx] " Jani Nikula
2020-04-21  9:33   ` Jeevan B
2020-04-21  9:33     ` [Intel-gfx] " Jeevan B
  -- strict thread matches above, loose matches on Subject: below --
2020-04-24 12:50 Jeevan B
2020-04-24 12:50 ` [PATCH 2/5] drm/i915: utilize subconnector property for DP Jeevan B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421093720.GB13664@intel.com \
    --to=jeevan.b@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=oleg.vasilev@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.