All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Furlong <jeff.furlong@wdc.com>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio max blocksize
Date: Thu, 12 Jul 2018 11:15:54 -0600	[thread overview]
Message-ID: <15f67a56-7f53-cfca-f4e6-289e1d6c2b14@kernel.dk> (raw)
In-Reply-To: <MWHPR04MB032082F03EB254879C04F26B8F470@MWHPR04MB0320.namprd04.prod.outlook.com>

On 7/6/18 3:15 PM, Jeff Furlong wrote:
> Hi All,
> Currently it looks like fio has a max blocksize of uint32_t.  So commands such as 
> 
> # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bs=4g --filename=/dev/nvme1n1 --number_ios=1 max value out of range: 4294967296 (4294967295 max)
> fio: failed parsing bs=4g
> 
> will fail.  While I wouldn't normally do 4GB reads/writes, I would like to issue 4GB trims.  Otherwise I need to invoke a tool such as blkdiscard, but then summarizing all job IO is very difficult.  I went through the process of unsuccessfully changing the blocksize variables to uint64_t (failed getting buflen), but not sure if I missed a minor detail or a major roadblock that would prevent it.  How could >4GB blocksizes be supported?  Thanks.

You'd just need to change the type of the bs related options, and all
of the structs that hold it. Not impossible at all, an pretty
straight forward. So I'd say that what you did would likely work,
though it's hard to ensure that you didn't miss a conversion
somewhere. Post the patch and we can take a look at it.

-- 
Jens Axboe



  parent reply	other threads:[~2018-07-12 17:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 21:15 fio max blocksize Jeff Furlong
2018-07-07  4:43 ` Sitsofe Wheeler
2018-07-12 17:15 ` Jens Axboe [this message]
2018-07-12 18:08   ` Jeff Furlong
2018-07-12 18:20     ` Jens Axboe
2018-07-12 19:11       ` Jeff Furlong
2018-07-12 19:38         ` Jens Axboe
2018-07-12 22:13           ` Jeff Furlong
2018-07-12 22:33             ` Jens Axboe
2018-07-12 22:47               ` Jeff Furlong
2018-07-12 22:49                 ` Jens Axboe
2018-07-13  0:07             ` Elliott, Robert (Persistent Memory)
2018-07-13 17:46               ` Jeff Furlong
2018-07-13 23:59                 ` Jeff Furlong
2018-07-14  3:05                   ` Jens Axboe
2018-07-17 21:38                     ` Jeff Furlong
2018-07-23 15:17                       ` Jens Axboe
2018-07-23 16:33                         ` Jeff Furlong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15f67a56-7f53-cfca-f4e6-289e1d6c2b14@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=jeff.furlong@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.