From: Jens Axboe <axboe@kernel.dk>
To: Jeff Furlong <jeff.furlong@wdc.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio max blocksize
Date: Thu, 12 Jul 2018 16:49:01 -0600 [thread overview]
Message-ID: <8c29ce9b-372d-d9f8-c836-b2e467d97a97@kernel.dk> (raw)
In-Reply-To: <MWHPR04MB03209A6E1D7B2CB3319CFE028F590@MWHPR04MB0320.namprd04.prod.outlook.com>
On 7/12/18 4:47 PM, Jeff Furlong wrote:
>> The above will overwrite nearby members.
> Was thinking the member was allocated as 64 bits but may only use 32
> bits, but agreed that's not true for other options that use
> FIO_OPT_INT (e.g. nr_files). How about just breaking the ULL if/else
> out separately:
That is much better, that'll work fine.
BTW, not on when you do a more final version, be wary of tabs and
spaces. You seem to mix and match a bit. It's always tabs.
--
Jens Axboe
next prev parent reply other threads:[~2018-07-12 22:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 21:15 fio max blocksize Jeff Furlong
2018-07-07 4:43 ` Sitsofe Wheeler
2018-07-12 17:15 ` Jens Axboe
2018-07-12 18:08 ` Jeff Furlong
2018-07-12 18:20 ` Jens Axboe
2018-07-12 19:11 ` Jeff Furlong
2018-07-12 19:38 ` Jens Axboe
2018-07-12 22:13 ` Jeff Furlong
2018-07-12 22:33 ` Jens Axboe
2018-07-12 22:47 ` Jeff Furlong
2018-07-12 22:49 ` Jens Axboe [this message]
2018-07-13 0:07 ` Elliott, Robert (Persistent Memory)
2018-07-13 17:46 ` Jeff Furlong
2018-07-13 23:59 ` Jeff Furlong
2018-07-14 3:05 ` Jens Axboe
2018-07-17 21:38 ` Jeff Furlong
2018-07-23 15:17 ` Jens Axboe
2018-07-23 16:33 ` Jeff Furlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c29ce9b-372d-d9f8-c836-b2e467d97a97@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jeff.furlong@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.