From: Jens Axboe <axboe@kernel.dk>
To: Jeff Furlong <jeff.furlong@wdc.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio max blocksize
Date: Mon, 23 Jul 2018 09:17:52 -0600 [thread overview]
Message-ID: <6fae3201-41af-e59e-1f4b-72e17a39f6c2@kernel.dk> (raw)
In-Reply-To: <MWHPR04MB03200193A7DE2F49107615288F5C0@MWHPR04MB0320.namprd04.prod.outlook.com>
On 7/17/18 3:38 PM, Jeff Furlong wrote:
>> I'd just convert those helpers to deal with unsigned long long always, that should work fine for the uint case.
> Done. I tested with:
>
> # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bssplit=4g/100 --filename=/dev/nvme1n1 --number_ios=2
>
> Here's the final patch unless someone finds an issue. I also updated
> it so it applies nicely to the latest on git. Tested with bs, ba,
> bsrange, bssplit options that have a >32 bit value.
Looks pretty good to me, I applied it with various little fixups in
terms of style. Please test current -git and ensure that it works
properly for you. Ran some basic testing here, and it still seems good.
--
Jens Axboe
next prev parent reply other threads:[~2018-07-23 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 21:15 fio max blocksize Jeff Furlong
2018-07-07 4:43 ` Sitsofe Wheeler
2018-07-12 17:15 ` Jens Axboe
2018-07-12 18:08 ` Jeff Furlong
2018-07-12 18:20 ` Jens Axboe
2018-07-12 19:11 ` Jeff Furlong
2018-07-12 19:38 ` Jens Axboe
2018-07-12 22:13 ` Jeff Furlong
2018-07-12 22:33 ` Jens Axboe
2018-07-12 22:47 ` Jeff Furlong
2018-07-12 22:49 ` Jens Axboe
2018-07-13 0:07 ` Elliott, Robert (Persistent Memory)
2018-07-13 17:46 ` Jeff Furlong
2018-07-13 23:59 ` Jeff Furlong
2018-07-14 3:05 ` Jens Axboe
2018-07-17 21:38 ` Jeff Furlong
2018-07-23 15:17 ` Jens Axboe [this message]
2018-07-23 16:33 ` Jeff Furlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fae3201-41af-e59e-1f4b-72e17a39f6c2@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jeff.furlong@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.