All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Yinghai Lu <yinghai@kernel.org>
Cc: horms@verge.net.au, Takao Indoh <indou.takao@jp.fujitsu.com>,
	MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>,
	tokunaga.keiich@jp.fujitsu.com, linux-pci@vger.kernel.org,
	x86@kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, hbabu@us.ibm.com,
	andi@firstfloor.org, ddutile@redhat.com,
	ishii.hironobu@jp.fujitsu.com, hpa@zytor.com,
	bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com,
	vgoyal@redhat.com, khalid@gonehiking.org
Subject: Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case
Date: Fri, 11 Jan 2013 19:24:41 +0100	[thread overview]
Message-ID: <1603289.LXteBtkifD@hammer82.arch.suse.de> (raw)
In-Reply-To: <CAE9FiQWPJdER++ZrkKx7cQpF0QvwBeghNjpFqK18pMNC0w20tw@mail.gmail.com>

On Friday, January 11, 2013 08:16:52 AM Yinghai Lu wrote:
> On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger <trenn@suse.de> wrote:
...
> > -               e820.nr_map = 0;
> > +               /*
> > +                * Remove all usable memory (this is for kdump), usable
> > +                * memory will be passed via memmap=X@Y parameter
> > +                */
> > +               e820_remove_range_type(E820_RAM);
> 
> We may need to keep exactmap intact.
Why?
Kexec/kdump should have been the only user?
If older/current kexec calls still add ACPI maps via memmap=X#Y,
they should already exist in the original e820 map and fall off or
get glued to one region if (wrongly) overlapping via sanitize_map.
 
> but could add another one like exact_ram_map
> or extend to have memmap=exactmap=ram or etc.

I would avoid that if anyhow possible because then you run into
kexec vs kernel version problems.

Maybe I should explicitly post (out of this thread) the patch to the
kexec list.
If nobody can come up with a strong reason, it should be ok?

   Thomas

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Renninger <trenn@suse.de>
To: Yinghai Lu <yinghai@kernel.org>
Cc: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>,
	Takao Indoh <indou.takao@jp.fujitsu.com>,
	linux-pci@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, andi@firstfloor.org,
	tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org,
	hbabu@us.ibm.com, mingo@redhat.com, ddutile@redhat.com,
	vgoyal@redhat.com, ishii.hironobu@jp.fujitsu.com, hpa@zytor.com,
	bhelgaas@google.com, tglx@linutronix.de, khalid@gonehiking.org,
	horms@verge.net.au
Subject: Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case
Date: Fri, 11 Jan 2013 19:24:41 +0100	[thread overview]
Message-ID: <1603289.LXteBtkifD@hammer82.arch.suse.de> (raw)
In-Reply-To: <CAE9FiQWPJdER++ZrkKx7cQpF0QvwBeghNjpFqK18pMNC0w20tw@mail.gmail.com>

On Friday, January 11, 2013 08:16:52 AM Yinghai Lu wrote:
> On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger <trenn@suse.de> wrote:
...
> > -               e820.nr_map = 0;
> > +               /*
> > +                * Remove all usable memory (this is for kdump), usable
> > +                * memory will be passed via memmap=X@Y parameter
> > +                */
> > +               e820_remove_range_type(E820_RAM);
> 
> We may need to keep exactmap intact.
Why?
Kexec/kdump should have been the only user?
If older/current kexec calls still add ACPI maps via memmap=X#Y,
they should already exist in the original e820 map and fall off or
get glued to one region if (wrongly) overlapping via sanitize_map.
 
> but could add another one like exact_ram_map
> or extend to have memmap=exactmap=ram or etc.

I would avoid that if anyhow possible because then you run into
kexec vs kernel version problems.

Maybe I should explicitly post (out of this thread) the patch to the
kexec list.
If nobody can come up with a strong reason, it should be ok?

   Thomas

  reply	other threads:[~2013-01-11 18:24 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  0:42 [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh
2012-11-27  0:42 ` Takao Indoh
2012-11-27  0:42 ` [PATCH v7 1/5] x86, pci: add dummy pci device for early stage Takao Indoh
2012-11-27  0:42   ` Takao Indoh
2012-11-27  0:42 ` [PATCH v7 2/5] PCI: Define the maximum number of PCI function Takao Indoh
2012-11-27  0:42   ` Takao Indoh
2012-11-27  0:42 ` [PATCH v7 3/5] Make reset_devices available at early stage Takao Indoh
2012-11-27  0:42   ` Takao Indoh
2012-11-27  0:43 ` [PATCH v7 4/5] x86, pci: Reset PCIe devices at boot time Takao Indoh
2012-11-27  0:43   ` Takao Indoh
2012-11-27  0:43 ` [PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled Takao Indoh
2012-11-27  0:43   ` Takao Indoh
2012-11-30 15:49 ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu MUNEDA Takahiro
2012-11-30 15:49   ` MUNEDA Takahiro
2012-12-21 16:19   ` Yinghai Lu
2012-12-21 16:19     ` Yinghai Lu
2013-01-07 19:09     ` Thomas Renninger
2013-01-07 19:09       ` Thomas Renninger
2013-01-07 20:16       ` Yinghai Lu
2013-01-07 20:16         ` Yinghai Lu
2013-01-08  0:42         ` Thomas Renninger
2013-01-08  0:42           ` Thomas Renninger
2013-01-08  3:04           ` Yinghai Lu
2013-01-08  3:04             ` Yinghai Lu
2013-01-08 16:47             ` [PATCH] Only reset e820 once, even with multiple memmap=exactmap params Thomas Renninger
2013-01-08 16:47               ` Thomas Renninger
2013-01-08 17:19               ` Yinghai Lu
2013-01-08 17:19                 ` Yinghai Lu
2013-01-10  3:21                 ` Thomas Renninger
2013-01-10  3:21                   ` Thomas Renninger
2013-01-10 14:26                   ` Vivek Goyal
2013-01-10 14:26                     ` Vivek Goyal
2013-01-10 16:53                     ` Yinghai Lu
2013-01-10 16:53                       ` Yinghai Lu
2013-01-10 17:01                       ` Vivek Goyal
2013-01-10 17:01                         ` Vivek Goyal
2013-01-10 17:11                         ` Yinghai Lu
2013-01-10 17:11                           ` Yinghai Lu
2013-01-10 23:34                   ` Yinghai Lu
2013-01-11 12:33                     ` [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case Thomas Renninger
2013-01-11 12:33                       ` Thomas Renninger
2013-01-11 16:16                       ` Yinghai Lu
2013-01-11 16:16                         ` Yinghai Lu
2013-01-11 18:24                         ` Thomas Renninger [this message]
2013-01-11 18:24                           ` Thomas Renninger
2013-01-11 19:59                           ` Yinghai Lu
2013-01-11 19:59                             ` Yinghai Lu
2013-01-11 20:06                             ` H. Peter Anvin
2013-01-11 20:06                               ` H. Peter Anvin
2013-01-11 21:09                               ` Yinghai Lu
2013-01-11 21:09                                 ` Yinghai Lu
2013-01-11 22:16                                 ` H. Peter Anvin
2013-01-11 22:16                                   ` H. Peter Anvin
2013-01-12 11:31                                   ` Thomas Renninger
2013-01-12 11:31                                     ` Thomas Renninger
2013-01-12 17:07                                     ` Yinghai Lu
2013-01-12 17:07                                       ` Yinghai Lu
2013-01-14  2:08                                       ` Thomas Renninger
2013-01-14  2:08                                         ` Thomas Renninger
2013-01-14  2:43                                         ` Yinghai Lu
2013-01-14  2:43                                           ` Yinghai Lu
2013-01-14 15:05                                           ` Thomas Renninger
2013-01-14 15:05                                             ` Thomas Renninger
2013-01-14 19:04                                             ` Yinghai Lu
2013-01-14 19:04                                               ` Yinghai Lu
2013-01-15  0:54                                               ` Thomas Renninger
2013-01-15  0:54                                                 ` Thomas Renninger
2013-01-15  4:45                                                 ` Yinghai Lu
2013-01-15  4:45                                                   ` Yinghai Lu
2013-01-22 15:21                                                   ` Thomas Renninger
2013-01-22 15:21                                                     ` Thomas Renninger
2013-01-08 16:50         ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Thomas Renninger
2013-01-08 16:50           ` Thomas Renninger
2013-01-08 17:27           ` Yinghai Lu
2013-01-08 17:27             ` Yinghai Lu
2013-01-09  2:32             ` Thomas Renninger
2013-01-09  2:32               ` Thomas Renninger
2013-01-09  4:39               ` Takao Indoh
2013-01-09  4:39                 ` Takao Indoh
2013-01-21  1:11       ` Takao Indoh
2013-01-21  1:11         ` Takao Indoh
2013-01-23  0:47         ` Thomas Renninger
2013-01-23  0:47           ` Thomas Renninger
2013-01-24  0:23           ` Takao Indoh
2013-01-24  0:23             ` Takao Indoh
2013-01-29  1:14             ` Thomas Renninger
2013-01-29  1:14               ` Thomas Renninger
2013-01-30  5:01               ` Takao Indoh
2013-01-30  5:01                 ` Takao Indoh
2013-03-04  0:56           ` Takao Indoh
2013-03-04  0:56             ` Takao Indoh
2013-03-04 22:00             ` Don Dutile
2013-03-04 22:00               ` Don Dutile
2013-03-05  0:56               ` Takao Indoh
2013-03-05  0:56                 ` Takao Indoh
2012-12-21  9:59 ` oliver yang
2012-12-21 10:37   ` Takao Indoh
2012-12-21 10:37     ` Takao Indoh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603289.LXteBtkifD@hammer82.arch.suse.de \
    --to=trenn@suse.de \
    --cc=andi@firstfloor.org \
    --cc=bhelgaas@google.com \
    --cc=ddutile@redhat.com \
    --cc=hbabu@us.ibm.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=ishii.hironobu@jp.fujitsu.com \
    --cc=kexec@lists.infradead.org \
    --cc=khalid@gonehiking.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=muneda.takahiro@jp.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=tokunaga.keiich@jp.fujitsu.com \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.