From: Ryder Lee <ryder.lee@mediatek.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <kbuild@lists.01.org>, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, <lkp@intel.com>,
<kbuild-all@lists.01.org>, Shayne Chen <shayne.chen@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC
Date: Wed, 10 Mar 2021 16:54:50 +0800 [thread overview]
Message-ID: <1615366490.10387.0.camel@mtkswgap22> (raw)
In-Reply-To: <20210310083018.GH21246@kadam>
On Wed, 2021-03-10 at 11:30 +0300, Dan Carpenter wrote:
> Hi Ryder,
>
> url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-add-missing-capabilities-for-DBDC/20210225-230323
> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> config: x86_64-randconfig-m001-20210309 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/mediatek/mt76/mt7915/init.c:353 mt7915_set_stream_vht_txbf_caps() error: potentially dereferencing uninitialized 'cap'.
>
> vim +/cap +353 drivers/net/wireless/mediatek/mt76/mt7915/init.c
>
> 00b2e16e006390 Ryder Lee 2020-05-12 344 void mt7915_set_stream_vht_txbf_caps(struct mt7915_phy *phy)
> 00b2e16e006390 Ryder Lee 2020-05-12 345 {
> 50a6fe79623e22 Ryder Lee 2021-02-25 346 int nss;
> 50a6fe79623e22 Ryder Lee 2021-02-25 347 u32 *cap;
> 50a6fe79623e22 Ryder Lee 2021-02-25 348
> 50a6fe79623e22 Ryder Lee 2021-02-25 349 if (!phy->mt76->cap.has_5ghz)
> 50a6fe79623e22 Ryder Lee 2021-02-25 350 return;
> 50a6fe79623e22 Ryder Lee 2021-02-25 351
> 50a6fe79623e22 Ryder Lee 2021-02-25 352 nss = hweight8(phy->mt76->chainmask);
> 50a6fe79623e22 Ryder Lee 2021-02-25 @353 *cap = &phy->mt76->sband_5g.sband.vht_cap.cap;
> ^^^^
> "cap" isn't initialized.
This has been fixed in v3
https://patchwork.kernel.org/project/linux-mediatek/patch/427ab5a2a79b8bbfa05225cfe4cfb55b3f143c8c.1614357346.git.ryder.lee@mediatek.com/
Ryder
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee@mediatek.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <kbuild@lists.01.org>, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, <lkp@intel.com>,
<kbuild-all@lists.01.org>, Shayne Chen <shayne.chen@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC
Date: Wed, 10 Mar 2021 16:54:50 +0800 [thread overview]
Message-ID: <1615366490.10387.0.camel@mtkswgap22> (raw)
In-Reply-To: <20210310083018.GH21246@kadam>
On Wed, 2021-03-10 at 11:30 +0300, Dan Carpenter wrote:
> Hi Ryder,
>
> url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-add-missing-capabilities-for-DBDC/20210225-230323
> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> config: x86_64-randconfig-m001-20210309 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/mediatek/mt76/mt7915/init.c:353 mt7915_set_stream_vht_txbf_caps() error: potentially dereferencing uninitialized 'cap'.
>
> vim +/cap +353 drivers/net/wireless/mediatek/mt76/mt7915/init.c
>
> 00b2e16e006390 Ryder Lee 2020-05-12 344 void mt7915_set_stream_vht_txbf_caps(struct mt7915_phy *phy)
> 00b2e16e006390 Ryder Lee 2020-05-12 345 {
> 50a6fe79623e22 Ryder Lee 2021-02-25 346 int nss;
> 50a6fe79623e22 Ryder Lee 2021-02-25 347 u32 *cap;
> 50a6fe79623e22 Ryder Lee 2021-02-25 348
> 50a6fe79623e22 Ryder Lee 2021-02-25 349 if (!phy->mt76->cap.has_5ghz)
> 50a6fe79623e22 Ryder Lee 2021-02-25 350 return;
> 50a6fe79623e22 Ryder Lee 2021-02-25 351
> 50a6fe79623e22 Ryder Lee 2021-02-25 352 nss = hweight8(phy->mt76->chainmask);
> 50a6fe79623e22 Ryder Lee 2021-02-25 @353 *cap = &phy->mt76->sband_5g.sband.vht_cap.cap;
> ^^^^
> "cap" isn't initialized.
This has been fixed in v3
https://patchwork.kernel.org/project/linux-mediatek/patch/427ab5a2a79b8bbfa05225cfe4cfb55b3f143c8c.1614357346.git.ryder.lee@mediatek.com/
Ryder
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee@mediatek.com>
To: kbuild-all@lists.01.org
Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC
Date: Wed, 10 Mar 2021 16:54:50 +0800 [thread overview]
Message-ID: <1615366490.10387.0.camel@mtkswgap22> (raw)
In-Reply-To: <20210310083018.GH21246@kadam>
[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]
On Wed, 2021-03-10 at 11:30 +0300, Dan Carpenter wrote:
> Hi Ryder,
>
> url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-add-missing-capabilities-for-DBDC/20210225-230323
> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> config: x86_64-randconfig-m001-20210309 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/mediatek/mt76/mt7915/init.c:353 mt7915_set_stream_vht_txbf_caps() error: potentially dereferencing uninitialized 'cap'.
>
> vim +/cap +353 drivers/net/wireless/mediatek/mt76/mt7915/init.c
>
> 00b2e16e006390 Ryder Lee 2020-05-12 344 void mt7915_set_stream_vht_txbf_caps(struct mt7915_phy *phy)
> 00b2e16e006390 Ryder Lee 2020-05-12 345 {
> 50a6fe79623e22 Ryder Lee 2021-02-25 346 int nss;
> 50a6fe79623e22 Ryder Lee 2021-02-25 347 u32 *cap;
> 50a6fe79623e22 Ryder Lee 2021-02-25 348
> 50a6fe79623e22 Ryder Lee 2021-02-25 349 if (!phy->mt76->cap.has_5ghz)
> 50a6fe79623e22 Ryder Lee 2021-02-25 350 return;
> 50a6fe79623e22 Ryder Lee 2021-02-25 351
> 50a6fe79623e22 Ryder Lee 2021-02-25 352 nss = hweight8(phy->mt76->chainmask);
> 50a6fe79623e22 Ryder Lee 2021-02-25 @353 *cap = &phy->mt76->sband_5g.sband.vht_cap.cap;
> ^^^^
> "cap" isn't initialized.
This has been fixed in v3
https://patchwork.kernel.org/project/linux-mediatek/patch/427ab5a2a79b8bbfa05225cfe4cfb55b3f143c8c.1614357346.git.ryder.lee(a)mediatek.com/
Ryder
next prev parent reply other threads:[~2021-03-10 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 14:58 [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC Ryder Lee
2021-02-25 14:58 ` Ryder Lee
2021-02-25 14:58 ` [PATCH v2 2/2] mt76: mt7615: " Ryder Lee
2021-02-25 14:58 ` Ryder Lee
2021-03-10 8:30 ` [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: " Dan Carpenter
2021-03-10 8:30 ` Dan Carpenter
2021-03-10 8:30 ` Dan Carpenter
2021-03-10 8:30 ` Dan Carpenter
2021-03-10 8:54 ` Ryder Lee [this message]
2021-03-10 8:54 ` [kbuild] " Ryder Lee
2021-03-10 8:54 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615366490.10387.0.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.