Re: [PATCH v4 03/11] media: vsp1: Rename dl_child to dl_next

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Kieran,

Thank you for the patch.

On Thursday, 3 May 2018 16:36:14 EEST Kieran Bingham wrote:
> Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display
> list chain referencing the nodes as children, when in reality they are
> siblings.
> 
> Update the terminology to 'dl_next' to be consistent with the
> vsp1_video_pipeline_run() usage.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/vsp1/vsp1_dl.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
> b/drivers/media/platform/vsp1/vsp1_dl.c index f4cede9b9b43..ec6fc21fabe0
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -398,7 +398,7 @@ struct vsp1_dl_list *vsp1_dl_list_get(struct
> vsp1_dl_manager *dlm) /* This function must be called with the display list
> manager lock held.*/ static void __vsp1_dl_list_put(struct vsp1_dl_list
> *dl)
>  {
> -	struct vsp1_dl_list *dl_child;
> +	struct vsp1_dl_list *dl_next;
> 
>  	if (!dl)
>  		return;
> @@ -408,8 +408,8 @@ static void __vsp1_dl_list_put(struct vsp1_dl_list *dl)
>  	 * hardware operation.
>  	 */
>  	if (dl->has_chain) {
> -		list_for_each_entry(dl_child, &dl->chain, chain)
> -			__vsp1_dl_list_put(dl_child);
> +		list_for_each_entry(dl_next, &dl->chain, chain)
> +			__vsp1_dl_list_put(dl_next);
>  	}
> 
>  	dl->has_chain = false;
> @@ -673,17 +673,17 @@ static void vsp1_dl_list_commit_singleshot(struct
> vsp1_dl_list *dl) void vsp1_dl_list_commit(struct vsp1_dl_list *dl, bool
> internal)
>  {
>  	struct vsp1_dl_manager *dlm = dl->dlm;
> -	struct vsp1_dl_list *dl_child;
> +	struct vsp1_dl_list *dl_next;
>  	unsigned long flags;
> 
>  	if (dlm->mode == VSP1_DL_MODE_HEADER) {
>  		/* Fill the header for the head and chained display lists. */
>  		vsp1_dl_list_fill_header(dl, list_empty(&dl->chain));
> 
> -		list_for_each_entry(dl_child, &dl->chain, chain) {
> -			bool last = list_is_last(&dl_child->chain, &dl->chain);
> +		list_for_each_entry(dl_next, &dl->chain, chain) {
> +			bool last = list_is_last(&dl_next->chain, &dl->chain);
> 
> -			vsp1_dl_list_fill_header(dl_child, last);
> +			vsp1_dl_list_fill_header(dl_next, last);
>  		}
>  	}


-- 
Regards,

Laurent Pinchart