All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mark.rutland@arm.com, Jose.Abreu@synopsys.com,
	algea.cao@rock-chips.com, devicetree@vger.kernel.org,
	airlied@linux.ie, dri-devel@lists.freedesktop.org, kishon@ti.com,
	robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, zhengyang@rock-chips.com
Subject: Re: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching
Date: Mon, 19 Feb 2018 12:49:17 +0100	[thread overview]
Message-ID: <1630677.YWXALm60yB@phil> (raw)
In-Reply-To: <f1104948-5b95-968c-edc4-7a4d5212bae0@arm.com>

Hi Robin,

Am Montag, 19. Februar 2018, 12:43:11 CET schrieb Robin Murphy:
> Hi Heiko,
> 
> On 16/02/18 20:41, Heiko Stuebner wrote:
> > So far we always encountered socs with 2 output crtcs needing the driver
> > to tell the hdmi block which output to connect to. But there also exist
> > socs with only one crtc like the rk3228, rk3328 and rk3368.
> > 
> > So adapt the register field to simply carry a negative value to signal
> > that now output-switching is necessary.
> 
> Nit: s/now/no/ ? (Hooray for grammatically-correct typos which invert 
> the entire meaning of the sentence!)

:-D

> What are the necessary dependencies for these patches? I tried applying 
> the series on 4.16-rc1 to test, but it failed at patch #6 with some 
> missing context (I tried checking drm-next for where rockchip_hdmi::hdmi 
> might have come from, but didn't see anything obvious)

You'll need the most recent drm-misc changes [0], especially the dw-hdmi
changes from Jernej Skrabec that touch similar areas and even included a
similar patch to export some general phy functions, which I could drop
from my series.


Heiko

[0] https://cgit.freedesktop.org/drm/drm-misc/log/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching
Date: Mon, 19 Feb 2018 12:49:17 +0100	[thread overview]
Message-ID: <1630677.YWXALm60yB@phil> (raw)
In-Reply-To: <f1104948-5b95-968c-edc4-7a4d5212bae0@arm.com>

Hi Robin,

Am Montag, 19. Februar 2018, 12:43:11 CET schrieb Robin Murphy:
> Hi Heiko,
> 
> On 16/02/18 20:41, Heiko Stuebner wrote:
> > So far we always encountered socs with 2 output crtcs needing the driver
> > to tell the hdmi block which output to connect to. But there also exist
> > socs with only one crtc like the rk3228, rk3328 and rk3368.
> > 
> > So adapt the register field to simply carry a negative value to signal
> > that now output-switching is necessary.
> 
> Nit: s/now/no/ ? (Hooray for grammatically-correct typos which invert 
> the entire meaning of the sentence!)

:-D

> What are the necessary dependencies for these patches? I tried applying 
> the series on 4.16-rc1 to test, but it failed at patch #6 with some 
> missing context (I tried checking drm-next for where rockchip_hdmi::hdmi 
> might have come from, but didn't see anything obvious)

You'll need the most recent drm-misc changes [0], especially the dw-hdmi
changes from Jernej Skrabec that touch similar areas and even included a
similar patch to export some general phy functions, which I could drop
from my series.


Heiko

[0] https://cgit.freedesktop.org/drm/drm-misc/log/

  reply	other threads:[~2018-02-19 11:49 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 20:41 [PATCH v2 0/8] drm/rockchip: hdmi support for rk3328 Heiko Stuebner
2018-02-16 20:41 ` Heiko Stuebner
2018-02-16 20:41 ` [PATCH v2 1/8] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP Heiko Stuebner
2018-02-16 20:41   ` Heiko Stuebner
2018-02-16 20:43   ` Heiko Stuebner
2018-02-16 20:43     ` Heiko Stuebner
     [not found] ` <20180216204158.29839-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-02-16 20:41   ` [PATCH v2 2/8] phy: add Rockchip Innosilicon hdmi phy Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-16 20:41   ` [PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-19 16:59     ` Laurent Pinchart
2018-02-19 16:59       ` Laurent Pinchart
2018-02-19 18:46       ` Heiko Stuebner
2018-02-19 18:46         ` Heiko Stuebner
2018-02-19 19:06         ` Laurent Pinchart
2018-02-19 19:06           ` Laurent Pinchart
2018-02-21 18:55           ` Heiko Stuebner
2018-02-21 18:55             ` Heiko Stuebner
2018-02-21 19:15             ` Laurent Pinchart
2018-02-21 19:15               ` Laurent Pinchart
2018-02-16 20:41   ` [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-19 11:43     ` Robin Murphy
2018-02-19 11:43       ` Robin Murphy
2018-02-19 11:49       ` Heiko Stuebner [this message]
2018-02-19 11:49         ` Heiko Stuebner
2018-02-16 20:41   ` [PATCH v2 5/8] dt-bindings: allow optional phys in Rockchip dw_hdmi binding Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-19 20:26     ` Rob Herring
2018-02-19 20:26       ` Rob Herring
2018-02-16 20:41   ` [PATCH v2 6/8] drm/rockchip: dw_hdmi: allow including external phys Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-16 20:41   ` [PATCH v2 7/8] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-19 11:46     ` Robin Murphy
2018-02-19 11:46       ` Robin Murphy
2018-02-16 20:41   ` [PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328 Heiko Stuebner
2018-02-16 20:41     ` Heiko Stuebner
2018-02-19 20:28     ` Rob Herring
2018-02-19 20:28       ` Rob Herring
2018-02-19 20:46       ` Heiko Stuebner
2018-02-19 20:46         ` Heiko Stuebner
2018-02-20 14:32         ` Rob Herring
2018-02-20 14:32           ` Rob Herring
2018-02-21 12:07 ` [PATCH v2 0/8] drm/rockchip: hdmi support for rk3328 Robin Murphy
2018-02-21 12:07   ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1630677.YWXALm60yB@phil \
    --to=heiko@sntech.de \
    --cc=Jose.Abreu@synopsys.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=algea.cao@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=zhengyang@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.