From: Alistair Popple <apopple@nvidia.com>
To: dri-devel@lists.freedesktop.org
Cc: Jason Gunthorpe <jgg@nvidia.com>,
rcampbell@nvidia.com, willy@infradead.org,
linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
hch@infradead.org, linux-mm@kvack.org, jglisse@redhat.com,
bskeggs@redhat.com, jhubbard@nvidia.com,
akpm@linux-foundation.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Tue, 30 Mar 2021 22:16:41 +0000 [thread overview]
Message-ID: <1636116.HIPWbOE89B@nvdebian> (raw)
In-Reply-To: <12442194.rtmf8Ope3M@nvdebian>
On Wednesday, 31 March 2021 9:09:30 AM AEDT Alistair Popple wrote:
> On Wednesday, 31 March 2021 5:49:03 AM AEDT Jason Gunthorpe wrote:
> > On Fri, Mar 26, 2021 at 11:08:00AM +1100, Alistair Popple wrote:
<snip>
> > So what clears PG_mlocked on this call path?
>
> See munlock_vma_page(). munlock works by clearing PG_mlocked, then calling
> try_to_munlock to check if any VMAs still need it locked in which case
> PG_mlocked gets set again. There are no other callers of try_to_munlock().
>
> > Something needs attention here..
>
> I think the code is correct, but perhaps the naming could be better. Would be
> interested hearing any thoughts on renaming try_to_munlock() to try_to_mlock()
> as the current name appears based on the context it is called from (munlock)
> rather than what it does (mlock).
Actually Documentation/vm/unevictable-lru.rst contains a better suggestion:
try_to_munlock() Reverse Map Scan
---------------------------------
.. warning::
[!] TODO/FIXME: a better name might be page_mlocked() - analogous to the
page_referenced() reverse map walker.
Thoughts on renaming try_to_unlock() -> page_mlocked() and try_to_munlock_one() -> page_mlock_one()?
> - Alistair
>
> > Jason
> >
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: <dri-devel@lists.freedesktop.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>, <rcampbell@nvidia.com>,
<willy@infradead.org>, <linux-doc@vger.kernel.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<kvm-ppc@vger.kernel.org>, <hch@infradead.org>,
<linux-mm@kvack.org>, <jglisse@redhat.com>, <bskeggs@redhat.com>,
<jhubbard@nvidia.com>, <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Wed, 31 Mar 2021 09:16:41 +1100 [thread overview]
Message-ID: <1636116.HIPWbOE89B@nvdebian> (raw)
In-Reply-To: <12442194.rtmf8Ope3M@nvdebian>
On Wednesday, 31 March 2021 9:09:30 AM AEDT Alistair Popple wrote:
> On Wednesday, 31 March 2021 5:49:03 AM AEDT Jason Gunthorpe wrote:
> > On Fri, Mar 26, 2021 at 11:08:00AM +1100, Alistair Popple wrote:
<snip>
> > So what clears PG_mlocked on this call path?
>
> See munlock_vma_page(). munlock works by clearing PG_mlocked, then calling
> try_to_munlock to check if any VMAs still need it locked in which case
> PG_mlocked gets set again. There are no other callers of try_to_munlock().
>
> > Something needs attention here..
>
> I think the code is correct, but perhaps the naming could be better. Would be
> interested hearing any thoughts on renaming try_to_munlock() to try_to_mlock()
> as the current name appears based on the context it is called from (munlock)
> rather than what it does (mlock).
Actually Documentation/vm/unevictable-lru.rst contains a better suggestion:
try_to_munlock() Reverse Map Scan
---------------------------------
.. warning::
[!] TODO/FIXME: a better name might be page_mlocked() - analogous to the
page_referenced() reverse map walker.
Thoughts on renaming try_to_unlock() -> page_mlocked() and try_to_munlock_one() -> page_mlock_one()?
> - Alistair
>
> > Jason
> >
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: <dri-devel@lists.freedesktop.org>
Cc: rcampbell@nvidia.com, linux-doc@vger.kernel.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
willy@infradead.org, hch@infradead.org, linux-mm@kvack.org,
kvm-ppc@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
akpm@linux-foundation.org, Christoph Hellwig <hch@lst.de>,
bskeggs@redhat.com
Subject: Re: [Nouveau] [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Wed, 31 Mar 2021 09:16:41 +1100 [thread overview]
Message-ID: <1636116.HIPWbOE89B@nvdebian> (raw)
In-Reply-To: <12442194.rtmf8Ope3M@nvdebian>
On Wednesday, 31 March 2021 9:09:30 AM AEDT Alistair Popple wrote:
> On Wednesday, 31 March 2021 5:49:03 AM AEDT Jason Gunthorpe wrote:
> > On Fri, Mar 26, 2021 at 11:08:00AM +1100, Alistair Popple wrote:
<snip>
> > So what clears PG_mlocked on this call path?
>
> See munlock_vma_page(). munlock works by clearing PG_mlocked, then calling
> try_to_munlock to check if any VMAs still need it locked in which case
> PG_mlocked gets set again. There are no other callers of try_to_munlock().
>
> > Something needs attention here..
>
> I think the code is correct, but perhaps the naming could be better. Would be
> interested hearing any thoughts on renaming try_to_munlock() to try_to_mlock()
> as the current name appears based on the context it is called from (munlock)
> rather than what it does (mlock).
Actually Documentation/vm/unevictable-lru.rst contains a better suggestion:
try_to_munlock() Reverse Map Scan
---------------------------------
.. warning::
[!] TODO/FIXME: a better name might be page_mlocked() - analogous to the
page_referenced() reverse map walker.
Thoughts on renaming try_to_unlock() -> page_mlocked() and try_to_munlock_one() -> page_mlock_one()?
> - Alistair
>
> > Jason
> >
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: <dri-devel@lists.freedesktop.org>
Cc: rcampbell@nvidia.com, linux-doc@vger.kernel.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
willy@infradead.org, hch@infradead.org, linux-mm@kvack.org,
jglisse@redhat.com, kvm-ppc@vger.kernel.org,
Jason Gunthorpe <jgg@nvidia.com>,
jhubbard@nvidia.com, akpm@linux-foundation.org,
Christoph Hellwig <hch@lst.de>,
bskeggs@redhat.com
Subject: Re: [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Wed, 31 Mar 2021 09:16:41 +1100 [thread overview]
Message-ID: <1636116.HIPWbOE89B@nvdebian> (raw)
In-Reply-To: <12442194.rtmf8Ope3M@nvdebian>
On Wednesday, 31 March 2021 9:09:30 AM AEDT Alistair Popple wrote:
> On Wednesday, 31 March 2021 5:49:03 AM AEDT Jason Gunthorpe wrote:
> > On Fri, Mar 26, 2021 at 11:08:00AM +1100, Alistair Popple wrote:
<snip>
> > So what clears PG_mlocked on this call path?
>
> See munlock_vma_page(). munlock works by clearing PG_mlocked, then calling
> try_to_munlock to check if any VMAs still need it locked in which case
> PG_mlocked gets set again. There are no other callers of try_to_munlock().
>
> > Something needs attention here..
>
> I think the code is correct, but perhaps the naming could be better. Would be
> interested hearing any thoughts on renaming try_to_munlock() to try_to_mlock()
> as the current name appears based on the context it is called from (munlock)
> rather than what it does (mlock).
Actually Documentation/vm/unevictable-lru.rst contains a better suggestion:
try_to_munlock() Reverse Map Scan
---------------------------------
.. warning::
[!] TODO/FIXME: a better name might be page_mlocked() - analogous to the
page_referenced() reverse map walker.
Thoughts on renaming try_to_unlock() -> page_mlocked() and try_to_munlock_one() -> page_mlock_one()?
> - Alistair
>
> > Jason
> >
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-30 22:16 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 0:07 [PATCH v7 0/8] Add support for SVM atomics in Nouveau Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-26 0:07 ` [Nouveau] " Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-26 0:07 ` [PATCH v7 1/8] mm: Remove special swap entry functions Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-26 0:07 ` [Nouveau] " Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-30 18:38 ` Jason Gunthorpe
2021-03-30 18:38 ` Jason Gunthorpe
2021-03-30 18:38 ` [Nouveau] " Jason Gunthorpe
2021-03-30 18:38 ` Jason Gunthorpe
2021-03-26 0:07 ` [PATCH v7 2/8] mm/swapops: Rework swap entry manipulation code Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-26 0:07 ` [Nouveau] " Alistair Popple
2021-03-26 0:07 ` Alistair Popple
2021-03-26 0:08 ` [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-30 18:49 ` Jason Gunthorpe
2021-03-30 18:49 ` Jason Gunthorpe
2021-03-30 18:49 ` [Nouveau] " Jason Gunthorpe
2021-03-30 18:49 ` Jason Gunthorpe
2021-03-30 22:09 ` Alistair Popple
2021-03-30 22:09 ` Alistair Popple
2021-03-30 22:09 ` [Nouveau] " Alistair Popple
2021-03-30 22:09 ` Alistair Popple
2021-03-30 22:16 ` Alistair Popple [this message]
2021-03-30 22:16 ` Alistair Popple
2021-03-30 22:16 ` [Nouveau] " Alistair Popple
2021-03-30 22:16 ` Alistair Popple
2021-03-30 22:24 ` Jason Gunthorpe
2021-03-30 22:24 ` Jason Gunthorpe
2021-03-30 22:24 ` [Nouveau] " Jason Gunthorpe
2021-03-30 22:24 ` Jason Gunthorpe
2021-03-30 22:43 ` John Hubbard
2021-03-30 22:43 ` John Hubbard
2021-03-30 22:43 ` [Nouveau] " John Hubbard
2021-03-30 22:43 ` John Hubbard
2021-03-30 22:56 ` Alistair Popple
2021-03-30 22:56 ` Alistair Popple
2021-03-30 22:56 ` [Nouveau] " Alistair Popple
2021-03-30 22:56 ` Alistair Popple
2021-03-31 3:56 ` John Hubbard
2021-03-31 3:56 ` John Hubbard
2021-03-31 3:56 ` [Nouveau] " John Hubbard
2021-03-31 3:56 ` John Hubbard
2021-03-31 4:09 ` John Hubbard
2021-03-31 4:09 ` John Hubbard
2021-03-31 4:09 ` [Nouveau] " John Hubbard
2021-03-31 4:09 ` John Hubbard
2021-03-31 4:15 ` Alistair Popple
2021-03-31 4:15 ` Alistair Popple
2021-03-31 4:15 ` [Nouveau] " Alistair Popple
2021-03-31 4:15 ` Alistair Popple
2021-03-31 11:57 ` Jason Gunthorpe
2021-03-31 11:57 ` Jason Gunthorpe
2021-03-31 11:57 ` [Nouveau] " Jason Gunthorpe
2021-03-31 11:57 ` Jason Gunthorpe
2021-04-01 4:36 ` Alistair Popple
2021-04-01 4:36 ` Alistair Popple
2021-04-01 4:36 ` [Nouveau] " Alistair Popple
2021-04-01 4:36 ` Alistair Popple
2021-04-01 19:21 ` Shakeel Butt
2021-04-01 19:21 ` Shakeel Butt
2021-04-01 19:21 ` [Nouveau] " Shakeel Butt
2021-04-01 19:21 ` Shakeel Butt
2021-03-26 0:08 ` [PATCH v7 4/8] mm/rmap: Split migration into its own function Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [PATCH v7 5/8] mm: Device exclusive memory access Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-30 19:32 ` Jason Gunthorpe
2021-03-30 19:32 ` Jason Gunthorpe
2021-03-30 19:32 ` [Nouveau] " Jason Gunthorpe
2021-03-30 19:32 ` Jason Gunthorpe
2021-03-31 12:59 ` Alistair Popple
2021-03-31 12:59 ` Alistair Popple
2021-03-31 12:59 ` [Nouveau] " Alistair Popple
2021-03-31 12:59 ` Alistair Popple
2021-03-31 13:18 ` Jason Gunthorpe
2021-03-31 13:18 ` Jason Gunthorpe
2021-03-31 13:18 ` [Nouveau] " Jason Gunthorpe
2021-03-31 13:18 ` Jason Gunthorpe
2021-03-31 13:27 ` Alistair Popple
2021-03-31 13:27 ` Alistair Popple
2021-03-31 13:27 ` [Nouveau] " Alistair Popple
2021-03-31 13:27 ` Alistair Popple
2021-03-31 13:46 ` Jason Gunthorpe
2021-03-31 13:46 ` Jason Gunthorpe
2021-03-31 13:46 ` [Nouveau] " Jason Gunthorpe
2021-03-31 13:46 ` Jason Gunthorpe
2021-04-01 0:45 ` Alistair Popple
2021-04-01 0:45 ` Alistair Popple
2021-04-01 0:45 ` [Nouveau] " Alistair Popple
2021-04-01 0:45 ` Alistair Popple
2021-04-01 0:48 ` Jason Gunthorpe
2021-04-01 0:48 ` Jason Gunthorpe
2021-04-01 0:48 ` [Nouveau] " Jason Gunthorpe
2021-04-01 0:48 ` Jason Gunthorpe
2021-04-01 2:20 ` Alistair Popple
2021-04-01 2:20 ` Alistair Popple
2021-04-01 2:20 ` [Nouveau] " Alistair Popple
2021-04-01 2:20 ` Alistair Popple
2021-04-01 11:55 ` Jason Gunthorpe
2021-04-01 11:55 ` Jason Gunthorpe
2021-04-01 11:55 ` [Nouveau] " Jason Gunthorpe
2021-04-01 11:55 ` Jason Gunthorpe
2021-03-26 0:08 ` [PATCH v7 6/8] mm: Selftests for exclusive device memory Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [PATCH v7 7/8] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [PATCH v7 8/8] nouveau/svm: Implement atomic SVM access Alistair Popple
2021-03-26 0:08 ` Alistair Popple
2021-03-26 0:08 ` [Nouveau] " Alistair Popple
2021-03-26 0:08 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636116.HIPWbOE89B@nvdebian \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.