From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@mailbox.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml
Date: Sat, 15 Jan 2022 11:22:30 -0600 [thread overview]
Message-ID: <1642267350.954937.119895.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220115093557.30498-2-alexander.stein@mailbox.org>
On Sat, 15 Jan 2022 10:35:57 +0100, Alexander Stein wrote:
> Convert Amlogic FIFO controller documentation to yaml format.
>
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Things to note:
> First of, Jerome, sorry for adding you as maintainer, but
> 1) it's mandatory
> 2) your are the (only) author of amlogic,axg-fifo.txt
>
> Please add your Signed-off-by if that is okay with you.
>
> License is mandated by checkpath, not my choice.
>
> I'm not so sure about the compatible check. Essentially it is either
> * 'amlogic,axg-frddr' OR
> * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr'
> (or 'sm1' instead of 'g12a')
>
> Same goes for *-toddr. Is this schema correct in that regard? At least I
> got no warnings on existing device trees.
>
> .../bindings/sound/amlogic,axg-fifo.txt | 34 -------
> .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++
> 2 files changed, 97 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt
> create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1580333
audio-controller@100: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@140: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@180: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@1c0: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@200: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@240: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@mailbox.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml
Date: Sat, 15 Jan 2022 11:22:30 -0600 [thread overview]
Message-ID: <1642267350.954937.119895.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220115093557.30498-2-alexander.stein@mailbox.org>
On Sat, 15 Jan 2022 10:35:57 +0100, Alexander Stein wrote:
> Convert Amlogic FIFO controller documentation to yaml format.
>
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Things to note:
> First of, Jerome, sorry for adding you as maintainer, but
> 1) it's mandatory
> 2) your are the (only) author of amlogic,axg-fifo.txt
>
> Please add your Signed-off-by if that is okay with you.
>
> License is mandated by checkpath, not my choice.
>
> I'm not so sure about the compatible check. Essentially it is either
> * 'amlogic,axg-frddr' OR
> * 'amlogic,g12a-frddr' + 'amlogic,axg-frddr'
> (or 'sm1' instead of 'g12a')
>
> Same goes for *-toddr. Is this schema correct in that regard? At least I
> got no warnings on existing device trees.
>
> .../bindings/sound/amlogic,axg-fifo.txt | 34 -------
> .../bindings/sound/amlogic,axg-fifo.yaml | 97 +++++++++++++++++++
> 2 files changed, 97 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt
> create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1580333
audio-controller@100: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@140: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@180: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@1c0: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@200: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
audio-controller@240: 'reset-names' is a required property
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
next prev parent reply other threads:[~2022-01-15 17:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 9:35 [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Alexander Stein
2022-01-15 9:35 ` Alexander Stein
2022-01-15 9:35 ` [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml Alexander Stein
2022-01-15 9:35 ` Alexander Stein
2022-01-15 15:16 ` Jerome Brunet
2022-01-15 15:16 ` Jerome Brunet
2022-01-15 17:22 ` Rob Herring [this message]
2022-01-15 17:22 ` Rob Herring
2022-01-15 17:29 ` Rob Herring
2022-01-15 17:29 ` Rob Herring
2022-01-15 15:04 ` [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Jerome Brunet
2022-01-15 15:04 ` Jerome Brunet
2022-01-16 9:49 ` Alexander Stein
2022-01-16 9:49 ` Alexander Stein
2022-01-16 17:30 ` Jerome Brunet
2022-01-16 17:30 ` Jerome Brunet
2022-01-17 9:49 ` Neil Armstrong
2022-01-17 9:49 ` Neil Armstrong
2022-01-17 10:08 ` Jerome Brunet
2022-01-17 10:08 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642267350.954937.119895.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexander.stein@mailbox.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.