From: Alexander Stein <alexander.stein@mailbox.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property
Date: Sun, 16 Jan 2022 10:49:45 +0100 [thread overview]
Message-ID: <4732096.GXAFRqVoOG@kongar> (raw)
In-Reply-To: <1jilulav4u.fsf@starbuckisacylon.baylibre.com>
Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet:
>
> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org>
wrote:
>
> > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required
> > property. Add it.
>
> Binginds *mandates* ?? the bindings you are adding mandates that, not the
> previous doc, nor the driver.
Well, under required properties 'reset-names' is listed as well as 'arb' is
required, only 'rst' is optional.
So when creating the .yaml accordingly this leads to warnings this patch is
about to fix.
> Modifying drivers and DT to accomodate made-up bindings requirement is
> disturbing.
>
> The bindings should not require that because the driver does not, as it
> stands. The driver requires the arb reset to be provided, not the name.
> Please fix the bindings.
Nothing is made up. When creating the .yaml file I took the .txt documentation
for granted. How should I know the bindings documentation is apparently wrong?
When using your older bindings conversion [1] I'm fine with dropping this one.
Best regards,
Alexander
[1] https://patchwork.kernel.org/project/linux-amlogic/list/?
series=246453&state=%2A&archive=both
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@mailbox.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property
Date: Sun, 16 Jan 2022 10:49:45 +0100 [thread overview]
Message-ID: <4732096.GXAFRqVoOG@kongar> (raw)
In-Reply-To: <1jilulav4u.fsf@starbuckisacylon.baylibre.com>
Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet:
>
> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org>
wrote:
>
> > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required
> > property. Add it.
>
> Binginds *mandates* ?? the bindings you are adding mandates that, not the
> previous doc, nor the driver.
Well, under required properties 'reset-names' is listed as well as 'arb' is
required, only 'rst' is optional.
So when creating the .yaml accordingly this leads to warnings this patch is
about to fix.
> Modifying drivers and DT to accomodate made-up bindings requirement is
> disturbing.
>
> The bindings should not require that because the driver does not, as it
> stands. The driver requires the arb reset to be provided, not the name.
> Please fix the bindings.
Nothing is made up. When creating the .yaml file I took the .txt documentation
for granted. How should I know the bindings documentation is apparently wrong?
When using your older bindings conversion [1] I'm fine with dropping this one.
Best regards,
Alexander
[1] https://patchwork.kernel.org/project/linux-amlogic/list/?
series=246453&state=%2A&archive=both
next prev parent reply other threads:[~2022-01-16 9:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 9:35 [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Alexander Stein
2022-01-15 9:35 ` Alexander Stein
2022-01-15 9:35 ` [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml Alexander Stein
2022-01-15 9:35 ` Alexander Stein
2022-01-15 15:16 ` Jerome Brunet
2022-01-15 15:16 ` Jerome Brunet
2022-01-15 17:22 ` Rob Herring
2022-01-15 17:22 ` Rob Herring
2022-01-15 17:29 ` Rob Herring
2022-01-15 17:29 ` Rob Herring
2022-01-15 15:04 ` [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Jerome Brunet
2022-01-15 15:04 ` Jerome Brunet
2022-01-16 9:49 ` Alexander Stein [this message]
2022-01-16 9:49 ` Alexander Stein
2022-01-16 17:30 ` Jerome Brunet
2022-01-16 17:30 ` Jerome Brunet
2022-01-17 9:49 ` Neil Armstrong
2022-01-17 9:49 ` Neil Armstrong
2022-01-17 10:08 ` Jerome Brunet
2022-01-17 10:08 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4732096.GXAFRqVoOG@kongar \
--to=alexander.stein@mailbox.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.